Skip to content

Commit 637cdeb

Browse files
committed
show more images in images.mdx
1 parent 2812ead commit 637cdeb

File tree

3 files changed

+21
-7
lines changed

3 files changed

+21
-7
lines changed

docs/working-notes/todo3.md

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -428,15 +428,19 @@ write typography.mdx
428428
------
429429
// for release
430430
fix button and tags sizes
431+
smaller mobile buttons
431432
define color themes
432433
improve lighthouse, accessibility, aria attrs
433-
write readme and credits, roadmap
434+
write readme and credits, features, roadmap
434435
write home and about pages, one article
435436
open images in new tab and check all sizes
436437
links in md colors
437438
fix table of contents styling
438439
retest vertical spacing, font-size and content width
439440
// maybe
440441
astro transitions
441-
```
442+
--------
442443

444+
ask about optimal max-width image width
445+
fix .mdx live reload
446+
```

src/constants/image.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -64,7 +64,7 @@ export const IMAGE_SIZES = {
6464
},
6565
// doesn't work
6666
MDX_EXPAND_LG: {
67-
widths: [TW_SCREENS.XXS, TW_SCREENS.SM, TW_SCREENS.MD, TW_SCREENS.LG],
67+
widths: [TW_SCREENS.XXS, TW_SCREENS.SM, TW_SCREENS.MD, TW_SCREENS.LG, TW_SCREENS.XL],
6868
sizes: `(max-width: ${TW_SCREENS.XS}px) ${TW_SCREENS.XXS}px, (max-width: ${TW_SCREENS.MD}px) ${TW_SCREENS.SM}px, (max-width: ${TW_SCREENS.LG}px) ${TW_SCREENS.LG}px, ${TW_SCREENS.XL}px`,
6969
},
7070
},

src/pages/design/images.mdx

Lines changed: 14 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -11,10 +11,12 @@ import { IMAGE_SIZES } from '../../constants/image';
1111
import Amfi1Image from '../../assets/images/all-images/amfi1.jpg';
1212
import Bridge1Image from '../../assets/images/all-images/bridge1.jpg';
1313
import Lure2Image from '../../assets/images/all-images/lure2.jpg';
14+
import Lure3Image from '../../assets/images/all-images/lure3.jpg';
1415
import Nis1Image from '../../assets/images/all-images/nis1.jpg';
1516
import Riverside1Image from '../../assets/images/all-images/riverside1.jpg';
16-
import Riverside2Image from '../../assets/images/all-images/riverside2.jpg';
17+
import Raft1Image from '../../assets/images/all-images/raft1.jpg';
1718
import Square1Image from '../../assets/images/all-images/square1.jpg';
19+
import Meadow1Image from '../../assets/images/all-images/meadow1.jpg';
1820

1921
back to [Index](/design)
2022

@@ -28,9 +30,17 @@ back to [Index](/design)
2830

2931
## Image
3032

33+
### Image width=IMAGE_SIZES.FIXED.MDX_XS.width
34+
35+
<Image {...IMAGE_SIZES.FIXED.MDX_XS} src={Nis1Image} alt="This is city" />
36+
3137
### Image width=MDX_SM
3238

33-
<Image {...IMAGE_SIZES.FIXED.MDX_SM} src={Nis1Image} alt="This is city" />
39+
<Image {...IMAGE_SIZES.FIXED.MDX_SM} src={Lure3Image} alt="This is lure" />
40+
41+
### Image width=MDX_MD
42+
43+
<Image {...IMAGE_SIZES.FIXED.MDX_MD} src={Meadow1Image} alt="This is meadow" />
3444

3545
Dolor aliquip Lorem eiusmod reprehenderit sit. Quis eu ea quis pariatur labore consectetur culpa ex
3646
qui eu qui. Aliqua culpa consectetur sit ut. Quis Lorem do tempor cillum esse sit enim culpa
@@ -63,8 +73,8 @@ Adipisicing exercitation enim nostrud aliquip incididunt. Non commodo ad exercit
6373
<div class="expand-lg">
6474
<Image
6575
{...IMAGE_SIZES.RESPONSIVE.MDX_EXPAND_LG}
66-
src={Riverside2Image}
67-
alt="This is lure"
76+
src={Raft1Image}
77+
alt="This is raft"
6878
/>
6979
</div>
7080

0 commit comments

Comments
 (0)