Remove unnecessary iteration

nemanjarogic · nemanjarogic · commit 59b6a14f3ac0 · 2021-09-18T06:53:48.000+02:00
diff --git a/src/CreationalPatterns/AbstractFactory/MealSimpleFactory/Factories/MealFactory.cs b/src/CreationalPatterns/AbstractFactory/MealSimpleFactory/Factories/MealFactory.cs
@@ -32,15 +32,12 @@ public IMeal CreateMeal(string mealName)
 
         private Type GetTypeToCreate(string mealName)
         {
-            foreach (var meal in _meals)
+            if (!_meals.TryGetValue(mealName, out Type type))
             {
-                if (meal.Key.Contains(mealName))
-                {
-                    return _meals[meal.Key];
-                }
+                return null;
             }
 
-            return null;
+            return type;
         }
 
         /// <summary>

Original file line number	Diff line number	Diff line change
`@@ -32,15 +32,12 @@ public IMeal CreateMeal(string mealName)`
`32`	`32`
`33`	`33`	`private Type GetTypeToCreate(string mealName)`
`34`	`34`	`{`
`35`		`- foreach (var meal in _meals)`
	`35`	`+ if (!_meals.TryGetValue(mealName, out Type type))`
`36`	`36`	`{`
`37`		`- if (meal.Key.Contains(mealName))`
`38`		`- {`
`39`		`- return _meals[meal.Key];`
`40`		`- }`
	`37`	`+ return null;`
`41`	`38`	`}`
`42`	`39`
`43`		`- return null;`
	`40`	`+ return type;`
`44`	`41`	`}`
`45`	`42`
`46`	`43`	`/// <summary>`