Skip to content

Commit d2b949a

Browse files
committed
Update facade pattern examples
1 parent 110f3c5 commit d2b949a

File tree

16 files changed

+47
-66
lines changed

16 files changed

+47
-66
lines changed

src/StructuralPatterns/Facade/FacadeLibrary/MortgageExample/Facade/Mortgage.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ public Mortgage()
1919

2020
public bool IsEligible(string customerName, decimal loanAmount)
2121
{
22-
Console.WriteLine($"Customer {customerName} wants to apply for {loanAmount:C} loan.\n");
22+
Console.WriteLine($"The customer {customerName} wants to apply for {loanAmount:C} loan.\n");
2323

2424
var customer = _customerService.Find(customerName);
2525

@@ -40,4 +40,4 @@ public bool IsEligible(string customerName, decimal loanAmount)
4040

4141
return true;
4242
}
43-
}
43+
}

src/StructuralPatterns/Facade/FacadeLibrary/MortgageExample/MortgageExecutor.cs

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -10,12 +10,12 @@ public static void Execute()
1010
ConsoleExtension.WriteSeparator("Mortgage example");
1111

1212
var mortgage = new Mortgage();
13-
var customerName = "Mario Balotelli";
13+
const string customerName = "Mario Balotelli";
1414

1515
// Evaluate mortgage eligibility for the customer.
16-
bool isEligible = mortgage.IsEligible(customerName, 125000);
16+
var isEligible = mortgage.IsEligible(customerName, 125000);
1717

1818
var status = isEligible ? "approved" : "rejected";
1919
Console.WriteLine($"Mortgage for {customerName} has been {status}.");
2020
}
21-
}
21+
}

src/StructuralPatterns/Facade/FacadeLibrary/MortgageExample/Subsystem/Bank.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,8 +4,8 @@ public class Bank
44
{
55
public bool IsUntrustworthy(Customer customer, decimal loanAmount)
66
{
7-
Console.WriteLine($"Check creditworthyness for customer: {customer.Name}");
7+
Console.WriteLine($"Check credit-worthiness for the customer: {customer.Name}");
88

99
return false;
1010
}
11-
}
11+
}

src/StructuralPatterns/Facade/FacadeLibrary/MortgageExample/Subsystem/Credit.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,8 +4,8 @@ public class Credit
44
{
55
public bool HasBadCredit(Customer customer)
66
{
7-
Console.WriteLine($"Check credit for customer: {customer.Name}");
7+
Console.WriteLine($"Check credit for the customer: {customer.Name}");
88

99
return false;
1010
}
11-
}
11+
}

src/StructuralPatterns/Facade/FacadeLibrary/MortgageExample/Subsystem/Customer.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,5 +2,5 @@
22

33
public class Customer
44
{
5-
public string Name { get; set; }
6-
}
5+
public string Name { get; set; } = string.Empty;
6+
}

src/StructuralPatterns/Facade/FacadeLibrary/MortgageExample/Subsystem/CustomerService.cs

Lines changed: 6 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -2,11 +2,9 @@
22

33
public class CustomerService
44
{
5-
public Customer Find(string name)
6-
{
7-
// Naive implementation.
8-
// In real life scenario we would need some customer registry.
9-
// There may be multiple customers with the same name.
10-
return new Customer { Name = name };
11-
}
12-
}
5+
// Naive implementation.
6+
// In a real life scenario we would need some customer registry.
7+
// There may be multiple customers with the same name.
8+
public Customer Find(string name) =>
9+
new() { Name = name };
10+
}

src/StructuralPatterns/Facade/FacadeLibrary/MortgageExample/Subsystem/Loan.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,8 +4,8 @@ public class Loan
44
{
55
public bool HasBadLoans(Customer customer)
66
{
7-
Console.WriteLine($"Check loans for customer: {customer.Name}");
7+
Console.WriteLine($"Check loans for the customer: {customer.Name}");
88

99
return false;
1010
}
11-
}
11+
}
Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
1-
using BuildingBlocks;
1+
using System.Globalization;
2+
using BuildingBlocks;
23
using FacadeLibrary.WeatherServiceExample.After.TemperatureFacade;
34

45
namespace FacadeLibrary.WeatherServiceExample.After;
@@ -9,16 +10,15 @@ public static void Execute()
910
{
1011
ConsoleExtension.WriteSeparator("Weather service example - after");
1112

12-
var zipCode = "83714";
13+
const string zipCode = "83714";
1314
var temperatureService = new TemperatureLookupService();
14-
1515
var localTemperature = temperatureService.GetTemperature(zipCode);
1616

1717
Console.WriteLine(
1818
"The current temperature is {0}F/{1}C in {2}, {3}",
19-
localTemperature.Fahrenheit.ToString("F1"),
20-
localTemperature.Celsius.ToString("F1"),
19+
localTemperature.Fahrenheit.ToString("F1", CultureInfo.InvariantCulture),
20+
localTemperature.Celsius.ToString("F1", CultureInfo.InvariantCulture),
2121
localTemperature.City,
2222
localTemperature.State);
2323
}
24-
}
24+
}

src/StructuralPatterns/Facade/FacadeLibrary/WeatherServiceExample/After/TemperatureFacade/LocalTemperature.cs

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -3,10 +3,7 @@
33
public class LocalTemperature
44
{
55
public double Celsius { get; set; }
6-
76
public double Fahrenheit { get; set; }
8-
9-
public string City { get; set; }
10-
11-
public string State { get; set; }
12-
}
7+
public string City { get; set; } = string.Empty;
8+
public string State { get; set; } = string.Empty;
9+
}

src/StructuralPatterns/Facade/FacadeLibrary/WeatherServiceExample/After/TemperatureFacade/TemperatureLookupService.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -32,12 +32,12 @@ public LocalTemperature GetTemperature(string zipCode)
3232
var fahrenheitDegrees = _weatherService.GetTemperatureFahrenheit(coords.Latitude, coords.Longitude);
3333
var celsiusDegrees = _temperatureConverter.ConvertFahrenheitToCelsius(fahrenheitDegrees);
3434

35-
return new LocalTemperature()
35+
return new LocalTemperature
3636
{
3737
Fahrenheit = fahrenheitDegrees,
3838
Celsius = celsiusDegrees,
3939
City = city,
4040
State = state,
4141
};
4242
}
43-
}
43+
}

0 commit comments

Comments
 (0)