Merge pull request #332 from Philipp91/csfixer

Some PHP CS-Fixer things

Author: nemiah

.php_cs

@@ -1,14 +1,16 @@
 <?php
 
-// This is based on the `@Symfony` rule set in `vendor/friendsofphp/php-cs-fixer/src/RuleSet.php`.
+// This is based on the `@Symfony` rule set documented in `vendor/friendsofphp/php-cs-fixer/doc/ruleSets/Symfony.rst`.
 
 $finder = PhpCsFixer\Finder::create()
     ->in(__DIR__ . '/lib');
 
-return PhpCsFixer\Config::create()
+return (new PhpCsFixer\Config())
     ->setRules([
+        // We essentially use the Symfony style guide.
         '@Symfony' => true,
 
+        // But then we have some exclusions, i.e. we disable some of the checks/rules from Symfony:
         // Logic
         'yoda_style' => null, // Allow both Yoda-style and regular comparisons.
 

composer.json

@@ -18,7 +18,7 @@
   "require-dev": {
     "phpunit/phpunit": "9.5.*",
     "php-mock/php-mock-phpunit": "2.6.*",
-    "friendsofphp/php-cs-fixer": "2.17.*"
+    "friendsofphp/php-cs-fixer": "2.18.*"
   },
   "suggest": {
     "monolog/monolog": "Allow sending log messages to a variety of different handlers",

composer.lock

@@ -73,6 +73,6 @@ public function getMinimalLeadTime(): ?MinimaleVorlaufzeitSEPALastschrift
         if ($parsed instanceof MinimaleVorlaufzeitSEPALastschrift) {
             return $parsed;
         }
-        return  $parsed[$this->directDebitType] ?? null;
+        return $parsed[$this->directDebitType] ?? null;
     }
 }

lib/Fhp/Action/GetSEPADirectDebitParameters.php

@@ -1,4 +1,5 @@
-<?php /** @noinspection PhpUnused */
+<?php
+/** @noinspection PhpUnused */
 
 namespace Fhp\Model;
 

lib/Fhp/Model/Account.php

@@ -1,4 +1,5 @@
-<?php /** @noinspection PhpUnused */
+<?php
+/** @noinspection PhpUnused */
 
 namespace Fhp\Model\StatementOfAccount;
 

lib/Fhp/Model/StatementOfAccount/Transaction.php

@@ -1,4 +1,5 @@
-<?php /** @noinspection PhpUnused */
+<?php
+/** @noinspection PhpUnused */
 
 namespace Fhp\Model;
 

lib/Fhp/Model/TanMedium.php

@@ -1,4 +1,5 @@
-<?php /** @noinspection PhpUnused */
+<?php
+/** @noinspection PhpUnused */
 
 namespace Fhp\Model;
 

lib/Fhp/Model/TanMode.php

@@ -1,4 +1,5 @@
-<?php /** @noinspection PhpUnused */
+<?php
+/** @noinspection PhpUnused */
 
 namespace Fhp\Protocol;
 

lib/Fhp/Protocol/ActionIncompleteException.php

@@ -1,4 +1,5 @@
-<?php /** @noinspection PhpUnused */
+<?php
+/** @noinspection PhpUnused */
 
 namespace Fhp\Protocol;