Simplify name_data_type parsing

nene · nene · commit d13c451ab483 · 2025-11-23T20:56:22.000+02:00
diff --git a/src/parser.pegjs b/src/parser.pegjs
@@ -7056,11 +7056,8 @@ named_data_type
   / &bigquery type:(bigquery_array_type / bigquery_struct_type / bigquery_table_type) {
     return type;
   }
-  / kw:(type_name __) params:paren$list$expr {
-    return loc({ type: "named_data_type", name: read(kw), params });
-  }
-  / kw:type_name {
-    return loc({ type: "named_data_type", name: kw });
+  / kw:type_name params:(__ paren$list$expr)? {
+    return loc({ type: "named_data_type", name: read(kw), params: read(params) });
   }
 
 datetime_data_type
diff --git a/test/ddl/data_types.test.ts b/test/ddl/data_types.test.ts
@@ -425,6 +425,7 @@ describe("data types", () => {
               ],
               "type": "data_type_identifier",
             },
+            "params": undefined,
             "type": "named_data_type",
           },
           "type": "cast_operator_expr",

Original file line number	Diff line number	Diff line change
`@@ -7056,11 +7056,8 @@ named_data_type`
`7056`	`7056`	`/ &bigquery type:(bigquery_array_type / bigquery_struct_type / bigquery_table_type) {`
`7057`	`7057`	`return type;`
`7058`	`7058`	`}`
`7059`		`- / kw:(type_name __) params:paren$list$expr {`
`7060`		`- return loc({ type: "named_data_type", name: read(kw), params });`
`7061`		`- }`
`7062`		`- / kw:type_name {`
`7063`		`- return loc({ type: "named_data_type", name: kw });`
	`7059`	`+ / kw:type_name params:(__ paren$list$expr)? {`
	`7060`	`+ return loc({ type: "named_data_type", name: read(kw), params: read(params) });`
`7064`	`7061`	`}`
`7065`	`7062`
`7066`	`7063`	`datetime_data_type`