Full PostgreSQL operators support

Instead of listing a known list of operators, match all the allowed
operators properly.

Author: nene

src/parser.pegjs

@@ -43,6 +43,7 @@
   } from "./utils/parserState";
   import { isReservedKeyword } from "./utils/keywords";
   import { loc } from "./utils/loc";
+  import { isPostgresqlOtherOperator } from "./utils/pgOperators";
 
   setRangeFunction(() => [peg$savedPos, peg$currPos]);
 
@@ -7486,23 +7487,14 @@ pg_other_expr
     return createBinaryExprChain(head, tail);
   }
 
-// TODO: Actually Postgres allows combinations of all these symbols:
+// Postgres allows combinations of all these symbols:
 //
 //   + - * / < > = ~ ! @ # % ^ & | ` ?
 //
+// But there are some restrictions (see isPostgresqlOtherOperator for details)
+//
 pg_other_op
-  = op:(
-    // multi-letter operators (non-exhaustive list)
-    "||/" / "|/" / "||" / ">>" / "<<" / "!~~*" / "~~*" / "!~~" / "~~" / "!~*" / "~*" / "!~" / "^@"
-    // pgvector operators
-    / "<+>" / "<->" / "<#>" / "<=>" / "<~>" / "<%>"
-    // JSON operators
-    / "->>" / "->" / "#>>" / "#>"
-    // JSONB operators
-    / "@>" / "<@" / "?|" / "?&" / "#-" / "@?" / "@@"
-    // single-letter operators (exhaustive list)
-    / "!" / "~" / "@" / "#" / "&" / "|" / "`" / "?"
-  ) {
+  = op:(postgresql_operator) &{ return isPostgresqlOtherOperator(op); } {
     return op;
   }
 

test/expr/op_postgres.test.ts

@@ -29,7 +29,6 @@ describe("special PostgreSQL operators", () => {
       "#>",
       // JSONB
       "@>",
-      "<@",
       "?",
       "?|",
       "?&",
@@ -44,13 +43,47 @@ describe("special PostgreSQL operators", () => {
       "<=>",
       "<~>",
       "<%>",
+      // Others
+      // discovered by running in Supabase:
+      // SELECT DISTINCT oprname FROM pg_operator WHERE length(oprname) >= 2 ORDER BY oprname;
+      "!!",
+      "##",
+      "&&",
+      "&<",
+      "&>",
+      "*<",
+      "*<=",
+      "*<>",
+      "*=",
+      "*>",
+      "*>=",
+      "-|-",
+      "<<=",
+      "<<|",
+      "<^",
+      ">>=",
+      ">^",
+      "?#",
+      "?-",
+      "?-|",
+      "?||",
+      "@-@",
+      "@@@",
+      "^@",
+      "|&>",
+      "|>>",
+      "~<=~",
+      "~<~",
+      "~=",
+      "~>=~",
+      "~>~",
     ].forEach((op) => {
       it(`parses ${op} operator`, () => {
         testExprWc(`x ${op} y`);
       });
     });
 
-    // Test the currently unused isPostgresqlOtherOperator() predicate
+    // Separately test the isPostgresqlOtherOperator() predicate
     describe("isPostgresqlOtherOperator()", () => {
       it("rejects standard operators", () => {
         expect(isPostgresqlOtherOperator("+")).toBe(false);