Skip to content

Commit 996d3c3

Browse files
committed
made key & secret settings not mandatory
1 parent 1591bad commit 996d3c3

File tree

2 files changed

+18
-7
lines changed

2 files changed

+18
-7
lines changed

pom.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66

77
<groupId>com.neo4j</groupId>
88
<artifactId>aws-ec2-asg-discovery</artifactId>
9-
<version>0.2.1</version>
9+
<version>0.2.2</version>
1010

1111
<properties>
1212
<maven.compiler.source>17</maven.compiler.source>

src/main/java/cs/neo4j/AsgResolver.java

Lines changed: 17 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -34,18 +34,29 @@ public String name() {
3434

3535
@Override
3636
protected void internalInit(Config config, LogService logService, DependencyResolver externalDependencies) {
37+
log = logService.getUserLog(AsgResolver.class);
38+
log.info("Init of discovery plugin "+this.configDescription());
39+
40+
discoveryPort = checkConfig(config, DiscoverySettings.discovery_listen_address).getPort();
41+
3742
selector = checkConfig(config, Ec2Settings.asg_name);
38-
awsKey = checkConfig(config, Ec2Settings.aws_key);
39-
awsSecret = checkConfig(config, Ec2Settings.aws_secret);
4043
awsRegion = checkConfig(config, Ec2Settings.aws_region);
4144

42-
discoveryPort = checkConfig(config, DiscoverySettings.discovery_listen_address).getPort();
45+
awsKey = config.get(Ec2Settings.aws_key);
46+
awsSecret = config.get(Ec2Settings.aws_secret);
4347

44-
log = logService.getUserLog(AsgResolver.class);
45-
log.info("Init of discovery plugin "+this.configDescription());
4648
awsClient = externalDependencies.containsDependency(AwsClient.class)
4749
? externalDependencies.resolveDependency(AwsClient.class)
48-
: new AwsClient(awsKey, awsSecret, awsRegion);
50+
: instantiateAwsClient(awsKey, awsSecret, awsRegion);
51+
52+
}
53+
54+
private AwsClient instantiateAwsClient(String accessKey, String secretKey, String region) {
55+
if (accessKey != null && secretKey != null) {
56+
return new AwsClient(accessKey, secretKey, region);
57+
} else {
58+
return new AwsClient(region);
59+
}
4960
}
5061

5162
@Override

0 commit comments

Comments
 (0)