Skip to content

Commit 0444b75

Browse files
authored
Update moved procedures to have new class names (#4257)
* Update moved procedures to have new class names * PR updates
1 parent 7c6254a commit 0444b75

File tree

7 files changed

+30
-37
lines changed

7 files changed

+30
-37
lines changed

extended/src/main/java/apoc/export/arrow/ExportArrow.java renamed to extended/src/main/java/apoc/export/arrow/ExportArrowExtended.java

Lines changed: 9 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,7 @@
1818
*/
1919
package apoc.export.arrow;
2020

21+
import apoc.Extended;
2122
import apoc.Pools;
2223
import apoc.export.util.NodesAndRelsSubGraph;
2324
import apoc.result.ByteArrayResult;
@@ -45,7 +46,8 @@
4546
import java.util.Map;
4647
import java.util.stream.Stream;
4748

48-
public class ExportArrow {
49+
@Extended
50+
public class ExportArrowExtended {
4951

5052
@Context
5153
public Transaction tx;
@@ -63,8 +65,7 @@ public class ExportArrow {
6365
public TerminationGuard terminationGuard;
6466

6567
@NotThreadSafe
66-
@Procedure(name = "apoc.export.arrow.stream.all", deprecatedBy = "This procedure is being moved to APOC Extended.")
67-
@Deprecated
68+
@Procedure(name = "apoc.export.arrow.stream.all")
6869
@QueryLanguageScope(scope = {QueryLanguage.CYPHER_25})
6970
@Description("Exports the full database as an arrow byte array.")
7071
public Stream<ByteArrayResult> all(
@@ -75,10 +76,7 @@ public Stream<ByteArrayResult> all(
7576
}
7677

7778
@NotThreadSafe
78-
@Procedure(
79-
name = "apoc.export.arrow.stream.graph",
80-
deprecatedBy = "This procedure is being moved to APOC Extended.")
81-
@Deprecated
79+
@Procedure(name = "apoc.export.arrow.stream.graph")
8280
@QueryLanguageScope(scope = {QueryLanguage.CYPHER_25})
8381
@Description("Exports the given graph as an arrow byte array.")
8482
public Stream<ByteArrayResult> graph(
@@ -104,10 +102,7 @@ public Stream<ByteArrayResult> graph(
104102
}
105103

106104
@NotThreadSafe
107-
@Procedure(
108-
name = "apoc.export.arrow.stream.query",
109-
deprecatedBy = "This procedure is being moved to APOC Extended.")
110-
@Deprecated
105+
@Procedure(name = "apoc.export.arrow.stream.query")
111106
@QueryLanguageScope(scope = {QueryLanguage.CYPHER_25})
112107
@Description("Exports the given Cypher query as an arrow byte array.")
113108
public Stream<ByteArrayResult> query(
@@ -122,8 +117,7 @@ public Stream<ByteArrayResult> query(
122117
}
123118

124119
@NotThreadSafe
125-
@Procedure(name = "apoc.export.arrow.all", deprecatedBy = "This procedure is being moved to APOC Extended.")
126-
@Deprecated
120+
@Procedure(name = "apoc.export.arrow.all")
127121
@QueryLanguageScope(scope = {QueryLanguage.CYPHER_25})
128122
@Description("Exports the full database as an arrow file.")
129123
public Stream<ExportProgressInfo> all(
@@ -135,8 +129,7 @@ public Stream<ExportProgressInfo> all(
135129
}
136130

137131
@NotThreadSafe
138-
@Procedure(name = "apoc.export.arrow.graph", deprecatedBy = "This procedure is being moved to APOC Extended.")
139-
@Deprecated
132+
@Procedure(name = "apoc.export.arrow.graph")
140133
@QueryLanguageScope(scope = {QueryLanguage.CYPHER_25})
141134
@Description("Exports the given graph as an arrow file.")
142135
public Stream<ExportProgressInfo> graph(
@@ -164,8 +157,7 @@ public Stream<ExportProgressInfo> graph(
164157
}
165158

166159
@NotThreadSafe
167-
@Procedure(name = "apoc.export.arrow.query", deprecatedBy = "This procedure is being moved to APOC Extended.")
168-
@Deprecated
160+
@Procedure(name = "apoc.export.arrow.query")
169161
@QueryLanguageScope(scope = {QueryLanguage.CYPHER_25})
170162
@Description("Exports the results from the given Cypher query as an arrow file.")
171163
public Stream<ExportProgressInfo> query(

extended/src/main/java/apoc/load/LoadJsonExtended.java

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,7 @@
1818
*/
1919
package apoc.load;
2020

21+
import apoc.Extended;
2122
import apoc.result.LoadDataMapResult;
2223
import apoc.util.CompressionAlgo;
2324
import org.neo4j.graphdb.security.URLAccessChecker;
@@ -37,6 +38,7 @@
3738
import static apoc.load.LoadJsonUtils.loadJsonStream;
3839
import static apoc.util.CompressionConfig.COMPRESSION;
3940

41+
@Extended
4042
public class LoadJsonExtended {
4143

4244
@Context
@@ -46,8 +48,7 @@ public class LoadJsonExtended {
4648
public URLAccessChecker urlAccessChecker;
4749

4850
@SuppressWarnings("unchecked")
49-
@Procedure(name = "apoc.load.jsonParams", deprecatedBy = "This procedure is being moved to APOC Extended.")
50-
@Deprecated
51+
@Procedure(name = "apoc.load.jsonParams")
5152
@QueryLanguageScope(scope = {QueryLanguage.CYPHER_25})
5253
@Description(
5354
"Loads parameters from a JSON URL (e.g. web-API) as a stream of values if the given JSON file is a `LIST<ANY>`.\n"

extended/src/main/java/apoc/load/LoadArrow.java renamed to extended/src/main/java/apoc/load/arrow/LoadArrowExtended.java

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -16,8 +16,9 @@
1616
* See the License for the specific language governing permissions and
1717
* limitations under the License.
1818
*/
19-
package apoc.load;
19+
package apoc.load.arrow;
2020

21+
import apoc.Extended;
2122
import apoc.result.LoadDataMapResult;
2223
import apoc.util.FileUtils;
2324
import apoc.util.JsonUtil;
@@ -58,7 +59,8 @@
5859
import java.util.stream.Stream;
5960
import java.util.stream.StreamSupport;
6061

61-
public class LoadArrow {
62+
@Extended
63+
public class LoadArrowExtended {
6264

6365
@Context
6466
public URLAccessChecker urlAccessChecker;
@@ -101,8 +103,7 @@ public synchronized boolean tryAdvance(Consumer<? super LoadDataMapResult> actio
101103
}
102104
}
103105

104-
@Procedure(name = "apoc.load.arrow.stream", deprecatedBy = "This procedure is being moved to APOC Extended.")
105-
@Deprecated
106+
@Procedure(name = "apoc.load.arrow.stream")
106107
@QueryLanguageScope(scope = {QueryLanguage.CYPHER_25})
107108
@Description("Imports `NODE` and `RELATIONSHIP` values from the provided arrow byte array.")
108109
public Stream<LoadDataMapResult> stream(
@@ -123,8 +124,7 @@ public Stream<LoadDataMapResult> stream(
123124
});
124125
}
125126

126-
@Procedure(name = "apoc.load.arrow", deprecatedBy = "This procedure is being moved to APOC Extended.")
127-
@Deprecated
127+
@Procedure(name = "apoc.load.arrow")
128128
@QueryLanguageScope(scope = {QueryLanguage.CYPHER_25})
129129
@Description("Imports `NODE` and `RELATIONSHIP` values from the provided arrow file.")
130130
public Stream<LoadDataMapResult> file(
@@ -163,7 +163,7 @@ private static Object read(FieldVector fieldVector, int index) {
163163

164164
private static Object getObject(Object object) {
165165
if (object instanceof Collection) {
166-
return ((Collection<?>) object).stream().map(LoadArrow::getObject).collect(Collectors.toList());
166+
return ((Collection<?>) object).stream().map(LoadArrowExtended::getObject).collect(Collectors.toList());
167167
}
168168
if (object instanceof Map) {
169169
return ((Map<String, Object>) object)

extended/src/main/java/apoc/log/Neo4jLogStream.java renamed to extended/src/main/java/apoc/log/Neo4jLogStreamExtended.java

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,7 @@
1818
*/
1919
package apoc.log;
2020

21+
import apoc.Extended;
2122
import apoc.util.FileUtils;
2223
import org.neo4j.kernel.api.QueryLanguage;
2324
import org.neo4j.kernel.api.procedure.QueryLanguageScope;
@@ -41,7 +42,8 @@
4142
* @author moxious
4243
* @since 27.02.19
4344
*/
44-
public class Neo4jLogStream {
45+
@Extended
46+
public class Neo4jLogStreamExtended {
4547

4648
public static class FileEntry implements Comparable<FileEntry> {
4749
@Description("The line number.")
@@ -67,9 +69,7 @@ public int compareTo(FileEntry o) {
6769
@Admin
6870
@Procedure(
6971
name = "apoc.log.stream",
70-
mode = Mode.DBMS,
71-
deprecatedBy = "This procedure is being moved to APOC Extended.")
72-
@Deprecated
72+
mode = Mode.DBMS)
7373
@QueryLanguageScope(scope = {QueryLanguage.CYPHER_25})
7474
@Description("Returns the file contents from the given log, optionally returning only the last n lines.\n"
7575
+ "This procedure requires users to have an admin role.")

extended/src/test/java/apoc/export/arrow/ArrowTest.java renamed to extended/src/test/java/apoc/export/arrow/ArrowExtendedTest.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@
1919
package apoc.export.arrow;
2020

2121
import apoc.graph.Graphs;
22-
import apoc.load.LoadArrow;
22+
import apoc.load.arrow.*;
2323
import apoc.meta.Meta;
2424
import apoc.util.JsonUtil;
2525
import apoc.util.TestUtil;
@@ -50,7 +50,7 @@
5050
import static apoc.ApocConfig.apocConfig;
5151
import static org.junit.Assert.assertEquals;
5252

53-
public class ArrowTest {
53+
public class ArrowExtendedTest {
5454

5555
private static File directory = new File("target/arrow import");
5656

@@ -128,7 +128,7 @@ public class ArrowTest {
128128
public static void beforeClass() {
129129
db.executeTransactionally(
130130
"CREATE (f:User {name:'Adam',age:42,male:true,kids:['Sam','Anna','Grace'], born:localdatetime('2015-05-18T19:32:24.000'), place:point({latitude: 13.1, longitude: 33.46789, height: 100.0})})-[:KNOWS {since: 1993, bffSince: duration('P5M1.5D')}]->(b:User {name:'Jim',age:42})");
131-
TestUtil.registerProcedure(db, ExportArrow.class, LoadArrow.class, Graphs.class, Meta.class);
131+
TestUtil.registerProcedure(db, ExportArrowExtended.class, LoadArrowExtended.class, Graphs.class, Meta.class);
132132
}
133133

134134
@AfterClass

extended/src/test/java/apoc/export/arrow/ImportArrowTest.java renamed to extended/src/test/java/apoc/export/arrow/ImportArrowExtendedTest.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@
3434
import static org.junit.Assert.assertEquals;
3535
import static org.junit.Assert.assertFalse;
3636

37-
public class ImportArrowTest {
37+
public class ImportArrowExtendedTest {
3838
private static File directory = new File("target/arrowImport");
3939
static { //noinspection ResultOfMethodCallIgnored
4040
directory.mkdirs();
@@ -53,7 +53,7 @@ public class ImportArrowTest {
5353

5454
@BeforeClass
5555
public static void beforeClass() {
56-
TestUtil.registerProcedure(db, ExportArrow.class, ImportArrow.class, Meta.class);
56+
TestUtil.registerProcedure(db, ExportArrowExtended.class, ImportArrow.class, Meta.class);
5757
}
5858

5959
@Before

extended/src/test/java/apoc/log/Neo4jLogStreamTest.java renamed to extended/src/test/java/apoc/log/Neo4jLogStreamExtendedTest.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@
3737
import static apoc.util.TestUtil.testResult;
3838
import static org.junit.Assert.assertTrue;
3939

40-
public class Neo4jLogStreamTest {
40+
public class Neo4jLogStreamExtendedTest {
4141

4242
private GraphDatabaseService db;
4343
private DatabaseManagementService dbManagementService;
@@ -50,7 +50,7 @@ public void setUp() {
5050
.build();
5151
apocConfig().setProperty("server.directories.logs", "");
5252
db = dbManagementService.database(GraphDatabaseSettings.DEFAULT_DATABASE_NAME);
53-
TestUtil.registerProcedure(db, Neo4jLogStream.class);
53+
TestUtil.registerProcedure(db, Neo4jLogStreamExtended.class);
5454
}
5555

5656
@After

0 commit comments

Comments
 (0)