Skip to content

Commit 69d2e92

Browse files
committed
fix cheat-sheet scroll and contents offset
1 parent 9a54a42 commit 69d2e92

File tree

2 files changed

+8
-3
lines changed

2 files changed

+8
-3
lines changed

src/js/02-on-this-page.js

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,6 +32,10 @@
3232
var menu = sidebar.querySelector('.toc-menu-placeholder')
3333
if (!menu) (menu = document.createElement('div')).className = 'toc-menu-placeholder'
3434

35+
if (document.querySelector('body.has-banner')) {
36+
document.querySelector('.toc-menu').style.top = 'calc(var(--toc-top) + var(--banner-height))'
37+
}
38+
3539
var title = document.createElement('h2')
3640
title.textContent = sidebar.dataset.title || 'Contents'
3741
menu.appendChild(title)
@@ -87,7 +91,8 @@
8791
if (lastActiveFragment) links[lastActiveFragment].classList.remove('is-active')
8892
var activeLink = links[activeFragment]
8993
activeLink.classList.add('is-active')
90-
if (list.scrollHeight > list.offsetHeight) {
94+
// don't scroll page contents if cheat-sheet
95+
if (list.scrollHeight > list.offsetHeight && !document.querySelector('body.cheat-sheet')) {
9196
list.scrollTop = Math.max(0, activeLink.offsetTop + activeLink.offsetHeight - list.offsetHeight)
9297
}
9398
lastActiveFragment = activeFragment

src/js/12-fragment-jumper.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -33,9 +33,9 @@
3333
var scrollTarget = this.closest('div')
3434
var selectorsTop = document.querySelector('.nav-container .selectors').querySelector('div').getBoundingClientRect().top
3535
if (this.tagName === 'H3') topOffset = selectorsTop
36-
window.scrollTo(0, computePosition(scrollTarget, 0) - topOffset)
36+
window.scrollTo(0, computePosition(scrollTarget, 0) - (topOffset + 20))
3737
} else {
38-
window.scrollTo(0, computePosition(target, 0) - topOffset)
38+
window.scrollTo(0, computePosition(target, 0) - (topOffset + 20))
3939
}
4040
}
4141

0 commit comments

Comments
 (0)