Smells

Author: BennuFire

src/card/settings/CardSettingsContent.tsx

@@ -7,10 +7,7 @@ import NeoCodeEditorComponent, {
 } from '../../component/editor/CodeEditorComponent';
 import { getReportTypes } from '../../extensions/ExtensionUtils';
 import { Dropdown } from '@neo4j-ndl/react';
-import {
-  EXTENSIONS_CARD_SETTINGS_COMPONENT,
-  getExtensionCardSettingsComponents,
-} from '../../extensions/ExtensionConfig';
+import { EXTENSIONS_CARD_SETTINGS_COMPONENT } from '../../extensions/ExtensionConfig';
 import { update } from '../../utils/ObjectManipulation';
 
 const NeoCardSettingsContent = ({
@@ -44,7 +41,7 @@ const NeoCardSettingsContent = ({
 
   const reportTypes = getReportTypes(extensions);
   const report = reportTypes[type];
-  const SettingsComponent = report && report.settingsComponent;
+  const SettingsComponent = report?.settingsComponent || {};
 
   function hasExtensionComponents() {
     return (
@@ -111,8 +108,8 @@ const NeoCardSettingsContent = ({
             value: report && reportTypes[option].label,
           })),
           value: {
-            label: report && report.label,
-            value: report && report.label,
+            label: report?.label || '',
+            value: report?.label || '',
           },
           menuPortalTarget: document.querySelector('body'),
         }}

src/card/settings/custom/CardSettingsContentPropertySelect.tsx

@@ -190,8 +190,8 @@ const NeoCardSettingsContentPropertySelect = ({ query, database, settings, onRep
   // TODO: since this component is only rendered for parameter select, this is technically not needed
   const parameterSelectTypes = ['Node Property', 'Relationship Property', 'Free Text', 'Custom Query', 'Date Picker'];
   const selectedType = settings.type ? settings.type : 'Node Property';
-  const helperText = settings && settings.helperText ? settings.helperText : '';
-  const inputMode = settings && settings.inputMode ? settings.inputMode : 'cypher';
+  const helperText = settings?.helperText || '';
+  const inputMode = settings?.inputMode || 'cypher';
   const overridePropertyDisplayName =
     settings.overridePropertyDisplayName !== undefined ? settings.overridePropertyDisplayName : false;