Skip to content

Commit 3e0e1ad

Browse files
committed
Clean up code, remove old console.log statements
1 parent 468540c commit 3e0e1ad

File tree

3 files changed

+28
-13
lines changed

3 files changed

+28
-13
lines changed

src/application/ApplicationThunks.ts

Lines changed: 27 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -261,24 +261,40 @@ export const handleSharedDashboardsThunk = () => (dispatch: any) => {
261261
const dashboardDatabase = urlParams.get('dashboardDatabase');
262262
dispatch(setStandaloneDashboardDatabase(dashboardDatabase));
263263
if (urlParams.get('credentials')) {
264+
setWelcomeScreenOpen(false);
264265
const connection = decodeURIComponent(urlParams.get('credentials'));
265266
const protocol = connection.split('://')[0];
266267
const username = connection.split('://')[1].split(':')[0];
267268
const password = connection.split('://')[1].split(':')[1].split('@')[0];
268269
const database = connection.split('@')[1].split(':')[0];
269270
const url = connection.split('@')[1].split(':')[1];
270271
const port = connection.split('@')[1].split(':')[2];
271-
if (url == password) {
272-
// Special case where a connect link is generated without a password.
273-
// Here, the format is parsed incorrectly and we open the connection window instead.
274-
275-
dispatch(resetShareDetails());
276-
dispatch(setConnectionProperties(protocol, url, port, database, username.split('@')[0], ''));
277-
dispatch(setWelcomeScreenOpen(false));
278-
dispatch(setConnectionModalOpen(true));
279-
// window.history.pushState({}, document.title, "/");
280-
return;
281-
}
272+
// if (url == password) {
273+
// // Special case where a connect link is generated without a password.
274+
// // Here, the format is parsed incorrectly and we open the connection window instead.
275+
// dispatch(setConnectionProperties(protocol, url, port, database, username.split('@')[0], ''));
276+
// dispatch(
277+
// setShareDetailsFromUrl(
278+
// type,
279+
// id,
280+
// standalone,
281+
// protocol,
282+
// url,
283+
// port,
284+
// database,
285+
// username.split('@')[0],
286+
// '',
287+
// dashboardDatabase,
288+
// true
289+
// )
290+
// );
291+
// setDashboardToLoadAfterConnecting(id);
292+
// window.history.pushState({}, document.title, window.location.pathname);
293+
// dispatch(setConnectionModalOpen(true));
294+
// dispatch(setWelcomeScreenOpen(false));
295+
// // window.history.pushState({}, document.title, "/");
296+
// return;
297+
// }
282298

283299
dispatch(setConnectionModalOpen(false));
284300
dispatch(

src/extensions/actions/ActionsRuleCreationModal.tsx

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -238,7 +238,6 @@ export const NeoCustomReportActionsModal = ({
238238
};
239239

240240
const handleOnInputchange = (customization, index, value) => {
241-
console.log(customization, index, value);
242241
updateRuleField(index, 'value', value);
243242
if (type == 'bar' && customization !== 'set page') {
244243
// For bar charts, duplicate the value to rule.field

src/settings/SettingsModal.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@ export const NeoSettingsModal = ({ dashboardSettings, updateDashboardSetting })
4444
return (
4545
<>
4646
<Tooltip title='Settings' aria-label='settings' disableInteractive>
47-
<IconButton className='n-mx-1' onClick={handleClickOpen} aria-label='Settings' title='Settings'>
47+
<IconButton className='n-mx-1' onClick={handleClickOpen} aria-label='Settings'>
4848
<Cog6ToothIconOutline />
4949
</IconButton>
5050
</Tooltip>

0 commit comments

Comments
 (0)