Merge pull request #633 from neo4j-labs/feature/linksRender

Fix number display

Author: BennuFire

src/chart/ChartUtils.ts

@@ -140,6 +140,11 @@ export function getRecordType(value) {
       return 'objectNumber';
     }
     return 'object';
+  } else if (typeof value === 'string' || value instanceof String) {
+    if (value.startsWith('http') || value.startsWith('https')) {
+      return 'link';
+    }
+    return 'string';
   }
 
   // Use string as default type

src/chart/parameter/component/NodePropertyParameterSelect.tsx

@@ -120,6 +120,7 @@ const NodePropertyParameterSelectComponent = (props: ParameterSelectProps) => {
 
     handleParametersUpdate(newValue, newDisplay, manualParameterSave);
   };
+
   return (
     <div className={'n-flex n-flex-row n-flex-wrap n-items-center'}>
       <Autocomplete
@@ -151,7 +152,7 @@ const NodePropertyParameterSelectComponent = (props: ParameterSelectProps) => {
             variant='outlined'
           />
         )}
-        getOptionLabel={(option) => RenderSubValue(option)}
+        getOptionLabel={(option) => option?.toString() || ''}
       />
       {manualParameterSave ? <SelectionConfirmationButton onClick={() => manualHandleParametersUpdate()} /> : <></>}
     </div>

src/report/ReportRecordProcessing.tsx

@@ -248,7 +248,7 @@ function RenderPath(value) {
 function RenderArray(value) {
   const mapped = value.map((v, i) => {
     return (
-      <div key={String(`k${  i}`) + v}>
+      <div key={String(`k${i}`) + v}>
         {RenderSubValue(v)}
         {i < value.length - 1 && !valueIsNode(v) && !valueIsRelationship(v) ? <span>,&nbsp;</span> : <></>}
       </div>
@@ -269,6 +269,14 @@ function RenderString(value) {
   return str;
 }
 
+function RenderLink(value) {
+  return (
+    <TextLink key={value} externalLink target='_blank' href={value}>
+      {value}
+    </TextLink>
+  );
+}
+
 function RenderPoint(value) {
   return (
     <HtmlTooltip
@@ -379,6 +387,10 @@ export const rendererForType: any = {
     type: 'string',
     renderValue: (c) => RenderString(c.value),
   },
+  link: {
+    type: 'link',
+    renderValue: (c) => RenderLink(c.value),
+  },
 };
 
 export function getRendererForValue(value) {