Merge pull request #710 from hugorplobo/any-type

Refactor any type code smells

Author: alfredorubin96

src/card/settings/CardSettingsFooter.tsx

@@ -37,7 +37,7 @@ const NeoCardSettingsFooter = ({
 
   const debouncedReportSettingUpdate = useCallback(debounce(onReportSettingUpdate, 250), []);
 
-  const updateSpecificReportSetting = (field: string, value: any) => {
+  const updateSpecificReportSetting = (field: string, value: unknown) => {
     const entry = {};
     entry[field] = value;
     setReportSettingsText(update(reportSettingsText, entry));

src/card/view/CardView.tsx

@@ -62,7 +62,7 @@ const NeoCardView = ({
   // e.g. Change of query, type, some advanced settings...
   const [selectorChange, setSelectorChange] = useState(false);
 
-  const getLocalParameters = (parse_string, drilldown = true): any => {
+  const getLocalParameters = (parse_string, drilldown = true): unknown => {
     if (!parse_string || !globalParameters) {
       return {};
     }
@@ -142,7 +142,7 @@ const NeoCardView = ({
       ? reportTypes[type].withoutFooter
       : (reportTypes[type] && !reportTypes[type].selection) || (settings && settings.hideSelections);
 
-  const getGlobalParameter = (key: string): any => {
+  const getGlobalParameter = (key: string): unknown => {
     return globalParameters ? globalParameters[key] : undefined;
   };
 

src/chart/bar/BarChart.tsx

@@ -29,12 +29,12 @@ const NeoBarChart = (props: ChartProps) => {
   const { records, selection } = props;
 
   const [keys, setKeys] = React.useState<string[]>([]);
-  const [data, setData] = React.useState<Record<string, any>[]>([]);
+  const [data, setData] = React.useState<Record<string, unknown>[]>([]);
 
   useEffect(() => {
     let newKeys = {};
-    let newData: Record<string, any>[] = records
-      .reduce((data: Record<string, any>[], row: Record<string, any>) => {
+    let newData: Record<string, unknown>[] = records
+      .reduce((data: Record<string, unknown>[], row: Record<string, any>) => {
         try {
           if (!selection || !selection.index || !selection.value) {
             return data;

src/chart/graph/GraphChart.tsx

@@ -9,7 +9,7 @@ import { NeoGraphChartLockButton } from './component/button/GraphChartLockButton
 import { NeoGraphChartFitViewButton } from './component/button/GraphChartFitViewButton';
 import { buildGraphVisualizationObjectFromRecords } from './util/RecordUtils';
 import { parseNodeIconConfig } from './util/NodeUtils';
-import { GraphChartVisualizationProps, layouts } from './GraphChartVisualization';
+import { GraphChartVisualizationProps, Link, layouts } from './GraphChartVisualization';
 import { handleExpand } from './util/ExplorationUtils';
 import { categoricalColorSchemes } from '../../config/ColorConfig';
 import { IconButtonArray, IconButton } from '@neo4j-ndl/react';
@@ -66,7 +66,7 @@ const NeoGraphChart = (props: ChartProps) => {
 
   let [nodeLabels, setNodeLabels] = useState({});
   let [linkTypes, setLinkTypes] = useState({});
-  const [data, setData] = useState({ nodes: [] as any[], links: [] as any[] });
+  const [data, setData] = useState({ nodes: [] as Node[], links: [] as Link[] });
 
   const setLayoutFrozen = (value) => {
     if (value == false) {

src/chart/graph/GraphChartVisualization2D.tsx

@@ -1,6 +1,5 @@
 import React, { useRef } from 'react';
 import ForceGraph2D from 'react-force-graph-2d';
-import { actionRule } from '../../extensions/actions/ActionsRule';
 import { executeActionRule, getRuleWithFieldPropertyName } from '../../extensions/advancedcharts/Utils';
 import { getTooltip } from './component/GraphChartTooltip';
 import { GraphChartVisualizationProps } from './GraphChartVisualization';

src/chart/scatter/ScatterPlotChart.tsx

@@ -109,7 +109,7 @@ const NeoScatterPlot = (props: ChartProps) => {
         }
       }
 
-      let x: any = row.get(selection.x) || 0;
+      let x: number | Date = row.get(selection.x) || 0;
       let y: any = recordToNative(row.get(key)) || 0;
       if (!isNaN(y)) {
         if (isDateTime(x)) {