Moving circular to dev dep

Author: BennuFire

package.json

@@ -60,7 +60,6 @@
     "@sentry/webpack-plugin": "^2.5.0",
     "babel-runtime": "^6.26.0",
     "chroma-js": "^2.4.2",
-    "circular-dependency-plugin": "^5.2.2",
     "classnames": "^2.3.1",
     "d3-scale-chromatic": "^3.0.0",
     "dayjs": "^1.11.7",
@@ -135,6 +134,7 @@
     "typescript": "^4.8.4",
     "webpack": "^5.77.0",
     "webpack-cli": "^4.9.1",
-    "webpack-dev-server": "^4.7.3"
+    "webpack-dev-server": "^4.7.3",
+    "circular-dependency-plugin": "^5.2.2"
   }
 }

webpack.config.js

@@ -1,6 +1,21 @@
 const ReactRefreshWebpackPlugin = require('@pmmmwh/react-refresh-webpack-plugin');
 const { sentryWebpackPlugin } = require('@sentry/webpack-plugin');
 const CircularDependencyPlugin = require('circular-dependency-plugin');
+
+const circularPlugin = new CircularDependencyPlugin({
+  // exclude detection of files based on a RegExp
+  exclude: /a\.js|node_modules/,
+  // add errors to webpack instead of warnings
+  failOnError: false,
+  // allow import cycles that include an asyncronous import,
+  // e.g. via import(/* webpackMode: "weak" */ './file.js')
+  allowAsyncCycles: false,
+  // set the current working directory for displaying module paths
+  cwd: process.cwd(),
+});
+
+const circularValidation = false;
+
 const rules = [
   {
     test: /\.(js|jsx|ts|tsx)$/,
@@ -61,20 +76,7 @@ module.exports = (env) => {
             project: 'neodash',
           }),
         ]
-      : [
-          new ReactRefreshWebpackPlugin(),
-          // new CircularDependencyPlugin({
-          //   // exclude detection of files based on a RegExp
-          //   exclude: /a\.js|node_modules/,
-          //   // add errors to webpack instead of warnings
-          //   failOnError: false,
-          //   // allow import cycles that include an asyncronous import,
-          //   // e.g. via import(/* webpackMode: "weak" */ './file.js')
-          //   allowAsyncCycles: false,
-          //   // set the current working directory for displaying module paths
-          //   cwd: process.cwd(),
-          // }),
-        ],
+      : [new ReactRefreshWebpackPlugin(), ...(circularValidation ? [circularPlugin] : [])],
     ignoreWarnings: [/Failed to parse source map/],
   };
 };

yarn.lock

@@ -2317,13 +2317,6 @@
   resolved "https://registry.yarnpkg.com/@mui/core-downloads-tracker/-/core-downloads-tracker-5.12.3.tgz#3dffe62dccc065ddd7338e97d7be4b917004287e"
   integrity sha512-yiJZ+knaknPHuRKhRk4L6XiwppwkAahVal3LuYpvBH7GkA2g+D9WLEXOEnNYtVFUggyKf6fWGLGnx0iqzkU5YA==
 
-"@mui/icons-material@^5.11.16":
-  version "5.11.16"
-  resolved "https://registry.yarnpkg.com/@mui/icons-material/-/icons-material-5.11.16.tgz#417fa773c56672e39d6ccfed9ac55591985f0d38"
-  integrity sha512-oKkx9z9Kwg40NtcIajF9uOXhxiyTZrrm9nmIJ4UjkU2IdHpd4QVLbCc/5hZN/y0C6qzi2Zlxyr9TGddQx2vx2A==
-  dependencies:
-    "@babel/runtime" "^7.21.0"
-
 "@mui/material@^5.12.3":
   version "5.12.3"
   resolved "https://registry.yarnpkg.com/@mui/material/-/material-5.12.3.tgz#398c1b123fb065763558bc1f9fc47d1f8cb87d0c"