Merge pull request #890 from neo4j-labs/develop

2.4.8 Release

Author: mariusconjeaud

.github/workflows/master-deployment.yml

@@ -79,7 +79,7 @@ jobs:
           context: .
           file: ./Dockerfile
           push: true
-          tags: ${{ secrets.DOCKER_HUB_LABS_USERNAME }}/neodash:latest,${{ secrets.DOCKER_HUB_LABS_USERNAME }}/neodash:2.4.7
+          tags: ${{ secrets.DOCKER_HUB_LABS_USERNAME }}/neodash:latest,${{ secrets.DOCKER_HUB_LABS_USERNAME }}/neodash:2.4.8
   build-docker-legacy:
     needs: build-test
     runs-on: neodash-runners
@@ -103,7 +103,7 @@ jobs:
           context: .
           file: ./Dockerfile
           push: true
-          tags: ${{ secrets.DOCKER_HUB_USERNAME }}/neodash:latest,${{ secrets.DOCKER_HUB_USERNAME }}/neodash:2.4.7
+          tags: ${{ secrets.DOCKER_HUB_USERNAME }}/neodash:latest,${{ secrets.DOCKER_HUB_USERNAME }}/neodash:2.4.8
   deploy-gallery:
     runs-on: neodash-runners
     strategy:

Dockerfile

@@ -44,4 +44,4 @@ USER nginx
 EXPOSE $NGINX_PORT
 
 HEALTHCHECK cmd curl --fail "http://localhost:$NGINX_PORT" || exit 1
-LABEL version="2.4.7"
+LABEL version="2.4.8"

changelog.md

@@ -1,3 +1,13 @@
+## NeoDash 2.4.8
+This is a minor release containing an important fix and other minor fixes:
+
+- Fixed a bug where loading a dashboard would reset parameters to null ([887](https://github.com/neo4j-labs/neodash/pull/887)).
+- Fix relationship width parameter for Graph report ([889](https://github.com/neo4j-labs/neodash/pull/889)).
+  
+Thanks to all the contributors for this release: 
+- [alfredorubin96](https://github.com/alfredorubin96),
+- [nielsdejong](https://github.com/nielsdejong).
+
 ## NeoDash 2.4.7
 This is a minor release containing a few critical fixes and general code quality improvements:
 

docs/modules/ROOT/pages/developer-guide/deploy-a-build.adoc

@@ -37,7 +37,7 @@ Depending on the webserver type and version, this could be different directory.
 As an example - to copy the files to an nginx webserver using `scp`:
 
 ```bash
-scp neodash-2.4.7 username@host:/usr/share/nginx/html
+scp neodash-2.4.8 username@host:/usr/share/nginx/html
 ```
 
 NeoDash should now be visible by visiting your (sub)domain in the browser.

package.json

@@ -1,6 +1,6 @@
 {
   "name": "neodash",
-  "version": "2.4.7",
+  "version": "2.4.8",
   "description": "NeoDash - Neo4j Dashboard Builder",
   "neo4jDesktop": {
     "apiVersion": "^1.2.0"

release-notes.md

@@ -1,11 +1,9 @@
-## NeoDash 2.4.7
-This is a minor release containing a few critical fixes and general code quality improvements:
+## NeoDash 2.4.8
+This is a minor release containing an important fix and other minor fixes:
 
-- Fix multiple parameter select ([881](https://github.com/neo4j-labs/neodash/pull/881)).
-- Fix parameter casting error when loading dashboards([874](https://github.com/neo4j-labs/neodash/pull/874)).
-- Fix the fraud demo in the [Example Gallery](https://neodash-gallery.graphapp.io/).
+- Fixed a bug where loading a dashboard would reset parameters to null ([887](https://github.com/neo4j-labs/neodash/pull/887)).
+- Fix relationship width parameter for Graph report ([889](https://github.com/neo4j-labs/neodash/pull/889)).
 
 Thanks to all the contributors for this release: 
 - [alfredorubin96](https://github.com/alfredorubin96),
-- [MariusC](https://github.com/mariusconjeaud),
-- [elizarp](https://github.com/elizarp).
+- [nielsdejong](https://github.com/nielsdejong).

src/chart/graph/util/RecordUtils.ts

@@ -69,9 +69,10 @@ function extractGraphEntitiesFromField(
       source: value.start.low,
       target: value.end.low,
       type: value.type,
-      width: !Number.isNaN(value.properties[relWidthProperty])
-        ? toNumber(value.properties[relWidthProperty])
-        : defaultRelWidth,
+      width:
+        value.properties[relWidthProperty] !== undefined && !Number.isNaN(value.properties[relWidthProperty])
+          ? toNumber(value.properties[relWidthProperty])
+          : defaultRelWidth,
       color: value.properties[relColorProperty] ? value.properties[relColorProperty] : defaultRelColor,
       properties: value.properties,
     });

src/modal/AboutModal.tsx

@@ -3,7 +3,7 @@ import { Button, Dialog, TextLink } from '@neo4j-ndl/react';
 import { BookOpenIconOutline, BeakerIconOutline } from '@neo4j-ndl/react/icons';
 import { Section, SectionTitle, SectionContent } from './ModalUtils';
 
-export const version = '2.4.7';
+export const version = '2.4.8';
 
 export const NeoAboutModal = ({ open, handleClose, getDebugState }) => {
   const downloadDebugFile = () => {

src/settings/SettingsThunks.ts

@@ -61,7 +61,6 @@ export const updateGlobalParametersThunk = (newParameters) => (dispatch: any, ge
   try {
     const { settings } = getState().dashboard;
     const parameters = settings.parameters ? settings.parameters : {};
-
     // if new parameters are set...
     if (newParameters) {
       // iterate over the key value pairs in parameters
@@ -92,7 +91,11 @@ export const updateParametersToNeo4jTypeThunk = () => (dispatch: any, getState:
     Object.keys(parameters).forEach((key) => {
       if (isCastableToNeo4jDate(parameters[key])) {
         parameters[key] = castToNeo4jDate(parameters[key]);
-      } else if (parameters[key] && typeof toNumber(parameters[key]) === 'number') {
+      } else if (
+        parameters[key] &&
+        !isNaN(toNumber(parameters[key])) &&
+        typeof toNumber(parameters[key]) === 'number'
+      ) {
         parameters[key] = toNumber(parameters[key]);
       } else if (parameters[key] == undefined) {
         delete parameters[key];