Skip to content

Commit b581e2c

Browse files
adding card refresh
1 parent e51d7c8 commit b581e2c

File tree

2 files changed

+8
-7
lines changed

2 files changed

+8
-7
lines changed

src/card/Card.tsx

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -39,8 +39,8 @@ const NeoCard = ({
3939
extensions, // A set of enabled extensions.
4040
globalParameters, // Query parameters that are globally set for the entire dashboard.
4141
dashboardSettings, // Dictionary of settings for the entire dashboard.
42-
onRemovePressed,// action to take when the card is removed. (passed from parent)
43-
forceRefresh,
42+
onRemovePressed, // action to take when the card is removed. (passed from parent)
43+
forceRefresh, // parameter used to force a refresh of the card (incremental number).
4444
onClonePressed, // action to take when user presses the clone button
4545
onReportHelpButtonPressed, // action to take when someone clicks the 'help' button in the report settings.
4646
onTitleUpdate, // action to take when the card title is updated.
@@ -108,7 +108,7 @@ const NeoCard = ({
108108
if (!report.settingsOpen) {
109109
setActive(report.settings && report.settings.autorun !== undefined ? report.settings.autorun : true);
110110
}
111-
}, [report.query, forceRefresh]);
111+
}, [report.query]);
112112

113113
useEffect(() => {
114114
setSettingsOpen(report.settingsOpen);
@@ -150,7 +150,7 @@ const NeoCard = ({
150150
title={report.title}
151151
expanded={expanded}
152152
onToggleCardExpand={onToggleCardExpand}
153-
onForceRefresh={forceRefreshCard(0,id)}
153+
forceRefresh={forceRefresh}
154154
onGlobalParameterUpdate={onGlobalParameterUpdate}
155155
onSelectionUpdate={(selectable, field) => onSelectionUpdate(id, selectable, field)}
156156
onTitleUpdate={(title) => onTitleUpdate(id, title)}

src/card/view/CardView.tsx

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@ const NeoCardView = ({
4141
onToggleCardSettings,
4242
onTitleUpdate,
4343
onFieldsUpdate,
44-
onForceRefresh,
44+
forceRefresh,
4545
expanded,
4646
onToggleCardExpand,
4747
}) => {
@@ -158,11 +158,12 @@ const NeoCardView = ({
158158
setLastRunTimestamp(Date.now());
159159
}
160160
setSelectorChange(false);
161-
}, [settingsOpen]);
161+
}, [settingsOpen, forceRefresh]);
162162

163163
useEffect(() => {
164+
console.log(forceRefresh);
164165
setSelectorChange(true);
165-
}, [query, type, database, JSON.stringify(settingsSelector)]);
166+
}, [query, type, database, JSON.stringify(settingsSelector), forceRefresh]);
166167

167168
// TODO - understand why CardContent is throwing a warning based on this style config.
168169
const cardContentStyle = {

0 commit comments

Comments
 (0)