Skip to content

Commit ba6a787

Browse files
nielsdejongalfredorubin96dependabot[bot]BennuFireJonanOribe
authored
2.4.0 update (#696)
* Made API keys hidden (password fields) in the query translator module * Added new report action type for tables: multiselect checkboxes (#664) * Work in progress on table checkboxes * Fix handling external updates of parameter values in parameter selector * Improved handling of multiselector parameters for tables with checkboxes * Removed console log statement. Fix invalid behaviour * Updated comments * Added multiselect value limit * Clean up action rule create modal * Added docs on multiple selection with table rows and report actions * Fix handling external updates of parameter values in parameter selector (#663) * Fix handling external updates of parameter values in parameter selector * Removed console log statement. Fix invalid behaviour * Updated comments * Feature/new dashboard load UI (#657) * Added sidebar prototype * Return of the sidebar * Add database selector to sidebar * Iterating on the dashboard sidebar interface * Fixed usage of hardcoded color * Updated dashboard loading mechanism, iterating * Updated dashboard loading mechanism, iterating * Updated file structure for dashboard sidebar * Improved modal/menu handling for dashboard load * Import/export dashboards * New dashboard sharing interface * Removed old save/load modal * Finalized v1 of the new multi-dashboard UI * removing useless imports * Removed old isLoaded in state of dashboard load screen. Updated warning buttons --------- Co-authored-by: Alfred Rubin <[email protected]> * Bump @babel/traverse from 7.21.4 to 7.23.2 in /gallery (#670) Bumps [@babel/traverse](https://github.com/babel/babel/tree/HEAD/packages/babel-traverse) from 7.21.4 to 7.23.2. - [Release notes](https://github.com/babel/babel/releases) - [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md) - [Commits](https://github.com/babel/babel/commits/v7.23.2/packages/babel-traverse) --- updated-dependencies: - dependency-name: "@babel/traverse" dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: Harold Agudelo <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump @babel/traverse from 7.20.13 to 7.23.2 (#669) Bumps [@babel/traverse](https://github.com/babel/babel/tree/HEAD/packages/babel-traverse) from 7.20.13 to 7.23.2. - [Release notes](https://github.com/babel/babel/releases) - [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md) - [Commits](https://github.com/babel/babel/commits/v7.23.2/packages/babel-traverse) --- updated-dependencies: - dependency-name: "@babel/traverse" dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: Harold Agudelo <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Niels de Jong <[email protected]> * Bump postcss from 8.4.23 to 8.4.31 in /gallery (#656) Bumps [postcss](https://github.com/postcss/postcss) from 8.4.23 to 8.4.31. - [Release notes](https://github.com/postcss/postcss/releases) - [Changelog](https://github.com/postcss/postcss/blob/main/CHANGELOG.md) - [Commits](postcss/postcss@8.4.23...8.4.31) --- updated-dependencies: - dependency-name: postcss dependency-type: direct:development ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: Harold Agudelo <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Niels de Jong <[email protected]> * Bump postcss from 8.4.21 to 8.4.31 (#655) Bumps [postcss](https://github.com/postcss/postcss) from 8.4.21 to 8.4.31. - [Release notes](https://github.com/postcss/postcss/releases) - [Changelog](https://github.com/postcss/postcss/blob/main/CHANGELOG.md) - [Commits](postcss/postcss@8.4.21...8.4.31) --- updated-dependencies: - dependency-name: postcss dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: Harold Agudelo <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Niels de Jong <[email protected]> * Text hard to read on dark theme (#668) * Hiding columns in Table does not work #374 * Revert "Hiding columns in Table does not work #374" This reverts commit dc36d84. * Text hard to read on Dark Theme #667 * Fixed code style --------- Co-authored-by: Niels de Jong <[email protected]> * Hotfix for wrong default parameter replacement in markdown * Add back arrow on connection modal (#675) * fix: add back arrow on connection modal * WIP on improved back arrow for connection modal * Fixed dismissable connection modal based on connected state and standalone mode --------- Co-authored-by: Niels de Jong <[email protected]> * VULCAN-126/Override default message (#683) * Override default message * Refactored code * refactored code * Added docs --------- Co-authored-by: Monish <[email protected]> * Fix/hiding columns in table (#685) * fixed the issues with not being able to close columns in table chart * reverted back to orignal testpass --------- Co-authored-by: aleksandarneo4j <[email protected]> * Fix parameters values (#641) Co-authored-by: Niels de Jong <[email protected]> * Updated dashboard format to 2.4. Double resolution for horizontal and vertical card placement. Fixed several small usability issues (#682) * Updated dashboard format to 2.4. Double resolution for horizontal and vertical card placement. Fixed several small usability issues * Handling for dashboards in standalone mode * cleaning code followign SonarCloud code smells * changed migration function to reduce duplication, tested on twitter example dashboard * changed how we fetch the latest version of the code * changed migration function to reduce duplication, to test for applicationThunks --------- Co-authored-by: Alfred Rubin <[email protected]> * Feature/gantt chart (#684) * Added forms skeleton * Completed form skeleton * WIP on forms interface * Form framework (data entry, running, success, error) added * Added comments * Adding fields specification interface * UI for specifying individual parameter in a form * changing Dockerfile to enable args during build * fixing typo on argument in dockerfile * reverting dockerfile to older version * Rendering parameters inside the form component * Added docs for forms. Improved stability on form * Fixed warnings in console * Finished IT test for forms report * Added package * added new field to disable a parameter selector (in this way it works only with actions) * Gantt Chart Visualization * Fixed issue where parameter values were not updated on external changes * Fixed styling on freetext spinner * Workaround for clipping menu selectors in Needle * fix(rule based styling): js doing is magic with parseFloat (some strings were casted to floats event if they were just strings starting with 0 * Added save button to form create UI * removing console logs * Fix for needle dropdowns not showing on modals * Sortable list for form parameters * Improving the drag 'n drop * Iterating on form interface * Final version of forms * Disabling test * Gantt chart with live data * Improved robustness of form / parameter select component * Improve Gantt chart customizability. Added report action for Gantt charts * Added wait-logic for form submission, so that all fields are debounced and set correctly * Added multiline support for freetext parameter selector * Added support for drilled-down parameters used in the forms component * Fixed issues with parameter selector/forms, improve usability * Added default advanced settings to form * hanging if orders to prevent wrong casting to number for certain edge cases (EX: string with numbers and E : 00E1304) * adding more options to gantt chart and adding variable calendar type * Prototype of Frappe Gantt implementation * Improved version of frappe gantt * work in progress on new gantt chart * Clean up code structure * Clean up and documenting Gantt chart * Gantt chart stability & arrow directions * Handling task dependency directions in Gantt chart * Improved styling * More optimization & style fixes. * Added docs for Gantt Chart * Added rule-based styling and actions to Gantt chart * Finalized Gantt chart docs, examples, and fallback date parsing * removing code smells * trying to plug quarter date format and cleaning code * cleaning code accordingly to SonarCloud * Fixed UI not populating correctly for rule-based styling and actions * Gantt - fixed default width/height for bars. Visible labels. Handling quarters * Updated label positions * Fixed inspect modal for Gantt chart, fixed arrow spacing between tasks * Fixed linting issues --------- Co-authored-by: Niels de Jong <[email protected]> Co-authored-by: Alfred Rubin <[email protected]> * adding in advanced config for the graph viz more graph layout config … (#690) * adding in advanced config for the graph viz more graph layout config options * added doc about the new advanced setting --------- Co-authored-by: aleksandarneo4j <[email protected]> * Adding form widget as a new extension (#568) * Added forms skeleton * Completed form skeleton * WIP on forms interface * Form framework (data entry, running, success, error) added * Added comments * Adding fields specification interface * UI for specifying individual parameter in a form * changing Dockerfile to enable args during build * fixing typo on argument in dockerfile * reverting dockerfile to older version * Rendering parameters inside the form component * Added docs for forms. Improved stability on form * Fixed warnings in console * Finished IT test for forms report * added new field to disable a parameter selector (in this way it works only with actions) * Fixed issue where parameter values were not updated on external changes * Fixed styling on freetext spinner * Workaround for clipping menu selectors in Needle * fix(rule based styling): js doing is magic with parseFloat (some strings were casted to floats event if they were just strings starting with 0 * Added save button to form create UI * removing console logs * Fix for needle dropdowns not showing on modals * Sortable list for form parameters * Improving the drag 'n drop * Iterating on form interface * Final version of forms * Disabling test * Improved robustness of form / parameter select component * Updated docs, added clear form button * removing code smells * cleaning code followign SonarCloud code smells * cleaning code followign SonarCloud code smells * removing code smells * Intelligent parameters clearing in forms --------- Co-authored-by: Alfred Rubin <[email protected]> * Model Examples and LLM improvements (#600) * now when changing database in a card the query will retrigger correctly * adding schema sampling with apoc.meta.data and changing system prompt * cleaning code and adding examples management * starting working on plugging examples to the model * examples plugged to state and to the modelClient to add the example prompy * fixed examples in modelCLient because the there was a missing edge case * added Q&A form for AI training * Updated styling, added validation * validation on q&a form (to talk with Marius about UX and styling) * watching smells on sonarqube * Question Answer form updated with tailwind and needle styling * WIP creating edit Q&A modal * working on examples modal * WIP trying to get index prop to pass for ExampleEditorModal to work properly * fix * WIP * latest * plugging modelExamples table to the state and changing folder structure * Issue with addModelExample action call * working on model examples and fixing prompt behaviour * Paginated table implemented. Needs styling. * pagination done * Added cypher code editor. No line numbers right now - would be useful. Also no label for cypher editor * Added loading button when saving, error message if cypher editor is empty upon submission, removed legacy code * latest * ready for review * changing prompt * Updated. Fixed editing. Ready for Review * fixing code smells * WIP * WIP ExampleDisplayTable2 * styling and pagination needed * table done with styling, pagination * deleted old table * code smell 2/7 check * check smells * Checking smells * moving component inside const * Table ready for review * Added initial pageSize * Fixed instructions on 'tweak model' screen * Fixed instructions on 'tweak model' screen * Got rid of show number of queries per page * checking code smells * removing useless row from task definition * changing folder names and changin from lazy import to normal on in ExtensionConfig * removing code smells * removing code smells * removing code smells * Fixed double dependency on react-table * refactoring code according to Sonarcube code smelles and fixed play button on card vie w to rerun the chatCompletion * Improved names * Usability improvements for LLM extension * Updating docs * Added docs for custom LLM examples --------- Co-authored-by: Alfred Rubin <[email protected]> Co-authored-by: jacobbleakley-neo4j <[email protected]> Co-authored-by: Niels de Jong <[email protected]> * Added release notes for 2.4 + bonus feature (keyboard shortcut to run query from the editor) (#694) * Release notes for 2.4 * Updated release notes. Added quick feature to run reports with keyboard shortcuts * Finalized release notes * Hotfix for not clearing disabled parameters in forms * Finalized release notes * Removed old gantt chart dependency * Bump docs version to 2.4 * Fixed issue with CodeMirror editor not capturing keys in Cypress test * Hotfix for automigrated tree layouts * Hotfixes for Sonarqube issues * minor fix in the forms where it wasn't getting the correct value in the settings * Fix hiding column prefix (#695) * fixing missing feature that was hiding columns starting with __ * removing test console log * removing code smell * removing code smell * fixing test * Bumped outdated version numbers --------- Co-authored-by: Alfred Rubin <[email protected]> Co-authored-by: Niels de Jong <[email protected]> * fixing merge --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: Alfred Rubin <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Harold Agudelo <[email protected]> Co-authored-by: Jon Ander Oribe <[email protected]> Co-authored-by: Antônio Hugo <[email protected]> Co-authored-by: Monish <[email protected]> Co-authored-by: Aleksandar <[email protected]> Co-authored-by: aleksandarneo4j <[email protected]> Co-authored-by: alfredorubin96 <[email protected]> Co-authored-by: jacobbleakley-neo4j <[email protected]>
1 parent 31e898b commit ba6a787

File tree

6 files changed

+18
-13
lines changed

6 files changed

+18
-13
lines changed

.github/workflows/master-deployment.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -79,7 +79,7 @@ jobs:
7979
context: .
8080
file: ./Dockerfile
8181
push: true
82-
tags: ${{ secrets.DOCKER_HUB_LABS_USERNAME }}/neodash:latest,${{ secrets.DOCKER_HUB_LABS_USERNAME }}/neodash:2.3.5
82+
tags: ${{ secrets.DOCKER_HUB_LABS_USERNAME }}/neodash:latest,${{ secrets.DOCKER_HUB_LABS_USERNAME }}/neodash:2.4.0
8383
build-docker-legacy:
8484
needs: build-test
8585
runs-on: neodash-runners
@@ -103,7 +103,7 @@ jobs:
103103
context: .
104104
file: ./Dockerfile
105105
push: true
106-
tags: ${{ secrets.DOCKER_HUB_USERNAME }}/neodash:latest,${{ secrets.DOCKER_HUB_USERNAME }}/neodash:2.3.5
106+
tags: ${{ secrets.DOCKER_HUB_USERNAME }}/neodash:latest,${{ secrets.DOCKER_HUB_USERNAME }}/neodash:2.4.0
107107
deploy-gallery:
108108
runs-on: neodash-runners
109109
strategy:

Dockerfile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -43,4 +43,4 @@ USER nginx
4343
EXPOSE $NGINX_PORT
4444

4545
HEALTHCHECK cmd curl --fail "http://localhost:$NGINX_PORT" || exit 1
46-
LABEL version="2.3.5"
46+
LABEL version="2.4.0"

cypress/e2e/start_page.cy.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -87,7 +87,7 @@ describe('NeoDash E2E Tests', () => {
8787
cy.get('main .react-grid-item:eq(2) .MuiDataGrid-columnHeaders', { timeout: WAITING_TIME })
8888
.should('contain', 'title')
8989
.and('contain', 'released')
90-
.and('contain', '__id');
90+
.and('not.contain', '__id');
9191
cy.get('main .react-grid-item:eq(2) .MuiDataGrid-virtualScroller .MuiDataGrid-row').should('have.length', 5);
9292
cy.get('main .react-grid-item:eq(2) .MuiDataGrid-footerContainer').should('contain', '1–5 of 8');
9393
cy.get('main .react-grid-item:eq(2) .MuiDataGrid-footerContainer button[aria-label="Go to next page"]').click();

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "neodash",
3-
"version": "2.3.5",
3+
"version": "2.4.0",
44
"description": "NeoDash - Neo4j Dashboard Builder",
55
"neo4jDesktop": {
66
"apiVersion": "^1.2.0"

src/chart/table/TableChart.tsx

Lines changed: 13 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import React from 'react';
1+
import React, { useEffect } from 'react';
22
import { DataGrid, GridColumnVisibilityModel } from '@mui/x-data-grid';
33
import { ChartProps } from '../Chart';
44
import {
@@ -27,7 +27,7 @@ import { getCheckboxes, hasCheckboxes, updateCheckBoxes } from './TableActionsHe
2727
const TABLE_HEADER_HEIGHT = 32;
2828
const TABLE_FOOTER_HEIGHT = 62;
2929
const TABLE_ROW_HEIGHT = 52;
30-
30+
const HIDDEN_COLUMN_PREFIX = '__';
3131
const theme = createTheme({
3232
typography: {
3333
fontFamily: "'Nunito Sans', sans-serif !important",
@@ -87,10 +87,6 @@ export const NeoTableChart = (props: ChartProps) => {
8787

8888
const useStyles = generateClassDefinitionsBasedOnRules(styleRules);
8989
const classes = useStyles();
90-
if (props.records == null || props.records.length == 0 || props.records[0].keys == null) {
91-
return <>No data, re-run the report.</>;
92-
}
93-
9490
const tableRowHeight = compact ? TABLE_ROW_HEIGHT / 2 : TABLE_ROW_HEIGHT;
9591
const pageSizeReducer = compact ? 3 : 1;
9692

@@ -162,6 +158,17 @@ export const NeoTableChart = (props: ChartProps) => {
162158
);
163159
});
164160

161+
useEffect(() => {
162+
const hiddenColumns = Object.assign(
163+
{},
164+
...columns.filter((x) => x.field.startsWith(HIDDEN_COLUMN_PREFIX)).map((x) => ({ [x.field]: false }))
165+
);
166+
setColumnVisibilityModel(hiddenColumns);
167+
}, [records]);
168+
169+
if (props.records == null || props.records.length == 0 || props.records[0].keys == null) {
170+
return <>No data, re-run the report.</>;
171+
}
165172
const getTransposedRows = (records) => {
166173
// Skip first key
167174
const rowKeys = [...records[0].keys];

src/extensions/forms/chart/NeoForm.tsx

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -31,8 +31,6 @@ const NeoForm = (props: ChartProps) => {
3131
const [status, setStatus] = React.useState(FormStatus.DATA_ENTRY);
3232
const [formResults, setFormResults] = React.useState([]);
3333
const debouncedRunCypherQuery = useCallback(debounce(props.queryCallback, RUN_QUERY_DELAY_MS), []);
34-
console.log(settings.hasSubmitButton);
35-
console.log(hasSubmitButton);
3634

3735
// Helper function to force a refresh on all reports that depend on the form.
3836
// All reports that use one or more parameters used in the form will be refreshed.

0 commit comments

Comments
 (0)