Review + small fixes, LGTM

Author: msenechal

k8s-deploy/neodash/Chart.yaml

@@ -21,4 +21,4 @@ version: 1.0.0
 # incremented each time you make changes to the application. Versions are not expected to
 # follow Semantic Versioning. They should reflect the version the application is using.
 # It is recommended to use it with quotes.
-appVersion: "2.4.8"
+appVersion: "2.4.9"

k8s-deploy/neodash/README.md

@@ -58,13 +58,13 @@ Following are the Kubernetes resources utilized for the NeoDash.
 - To install this helm chart run the following command,
 
     ```bash
-    helm install ./neodash <release-name> -n <namespace-name>
+    helm install <release-name> ./neodash -n <namespace-name>
     ```
 
 - To upgrade the release run the following command,
 
     ```bash
-    helm upgrade ./neodash <release-name> -n <namespace-name>
+    helm upgrade <release-name> ./neodash -n <namespace-name>
     ```
 
 - To uninstall the release run the following command,
@@ -74,3 +74,5 @@ Following are the Kubernetes resources utilized for the NeoDash.
     ```
 
 > **Note:** To use custom values files, pass `-f <path-to-values-file>.yaml` for the above command.
+> **Note:** To use custom values, pass `--set param=value` for the above command.
+For example, to install neodash and set the service type to NodePort, run: `helm install <release-name> ./neodash -n <namespace-name> --set service.type=NodePort`

k8s-deploy/neodash/templates/NOTES.txt

@@ -6,15 +6,19 @@ The NeoDash application has been successfully deployed, here is the application
   {{- end }}
 {{- end }}
 {{- else if contains "NodePort" .Values.service.type }}
+  Run the following command to retrieve the IP address:
   export NODE_PORT=$(kubectl get --namespace {{ .Release.Namespace }} -o jsonpath="{.spec.ports[0].nodePort}" services {{ include "neodash.fullname" . }})
   export NODE_IP=$(kubectl get nodes --namespace {{ .Release.Namespace }} -o jsonpath="{.items[0].status.addresses[0].address}")
   echo http://$NODE_IP:$NODE_PORT
 {{- else if contains "LoadBalancer" .Values.service.type }}
      NOTE: It may take a few minutes for the LoadBalancer IP to be available.
-           You can watch the status of by running 'kubectl get --namespace {{ .Release.Namespace }} svc -w {{ include "neodash.fullname" . }}'
+           You can watch the status of the LoadBalancer by running 'kubectl get --namespace {{ .Release.Namespace }} svc -w {{ include "neodash.fullname" . }}'
+
+  Once available, run the following command to retrieve the IP address:
   export SERVICE_IP=$(kubectl get svc --namespace {{ .Release.Namespace }} {{ include "neodash.fullname" . }} --template "{{"{{ range (index .status.loadBalancer.ingress 0) }}{{.}}{{ end }}"}}")
   echo http://$SERVICE_IP:{{ .Values.service.port }}
 {{- else if contains "ClusterIP" .Values.service.type }}
+  Run the following command to retrieve the IP address:
   export POD_NAME=$(kubectl get pods --namespace {{ .Release.Namespace }} -l "app.kubernetes.io/name={{ include "neodash.name" . }},app.kubernetes.io/instance={{ .Release.Name }}" -o jsonpath="{.items[0].metadata.name}")
   export CONTAINER_PORT=$(kubectl get pod --namespace {{ .Release.Namespace }} $POD_NAME -o jsonpath="{.spec.containers[0].ports[0].containerPort}")
   echo "Visit http://127.0.0.1:8080 to use your application"