[Feature #884] Helm chart for Kubernetes deployments #902
Conversation
- Includes the Helm chart required for the NeoDash deployment for the Kubernetes clusters - Includes the example YAML files for the Kubernetes manifests - Appropriate document changes to include the new Kubernetes deployments. Signed-off-by: Lolla, Venkata <[email protected]>
Signed-off-by: Lolla, Venkata <[email protected]>
Signed-off-by: Lolla, Venkata <[email protected]>
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| metadata: | ||
| labels: | ||
| application: neodash-deploy | ||
| spec: |
Check warning
Code scanning / SonarCloud
Service account tokens should not be mounted in pods
| "helm.sh/hook": test | ||
| spec: | ||
| containers: | ||
| - name: wget |
Check warning
Code scanning / SonarCloud
Memory limits should be enforced
| {{- include "neodash.labels" . | nindent 4 }} | ||
| annotations: | ||
| "helm.sh/hook": test | ||
| spec: |
Check warning
Code scanning / SonarCloud
Service account tokens should not be mounted in pods
| {{- with .Values.podLabels }} | ||
| {{- toYaml . | nindent 8 }} | ||
| {{- end }} | ||
| spec: |
Check warning
Code scanning / SonarCloud
Service account tokens should not be mounted in pods
venkatalolla
changed the title
Signed-off-by: Lolla, Venkata <[email protected]>
|
|
Hi @venkatalolla, thank you for your contribution! Could you please check the warning that are popping up in this page and check whether they are critical or not? Thanks again for helping the project! |
|
Hey @alfredorubin96, thanks a bunch for taking the time to review my pull request! 😄 If you're referring to the SonarCloud warnings, I've already taken care of them in my most recent commit, and they're all gone now. Just wanted to let you know, and also, they weren't critical anyway. |
|
Looked at the code and sounds good to me, could you please provide me an easy way to test it? I'm not an expert in developing helm charts, but there is a way in which we can test the deployment inside our pipelines? |
|
Hello @alfredorubin96, Thank you for the response. For testing the Helm chart deployment, I have put together a GitHub workflow in my own repository, https://github.com/venkatalolla/neodash-kind-helm-workflow, that deploys the Helm chart to a local KinD Kubernetes cluster and validates the 200 response for the NeoDash URL using CURL. For your information, I have tested the above-shared workflow here using the same code from this PR as an example. Let me know if you want me to provide more details on the GitHub workflow or the deployment. |
|
@alfredorubin96, please let me know if you need more information on my last comment. |
|
Moved to PR #971 for small changes/typo |
|
Closing as this is moved to #971, thanks everyone. |
4 participants
PR Description
This is a new feature request to create a Helm chart to support the Kubernetes based deployments in a package pattern. This Helm chart should enable the NeoDash deployment in either editor or reader mode for easy versioning, packaging and installing these dashboards at an enterprise level.
The solution includes a Helm chart with the following Kubernetes resources templates to support the editor or reader mode for ease of deployment,
As an alternative solution I also included the required Kubernetes YAML files to deploy the NeoDash with Kubectl commands.
#884