Skip to content

Change to neo4j+s as default protocol #956

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Feb 11, 2025
Merged

Change to neo4j+s as default protocol #956

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
7650301
added neo4j+s as default protocol and tested it and it works!
AleSim94 Sep 26, 2024
17b9288
fixing tests according to new feature
alfredorubin96 Feb 10, 2025
b470ec5
merging w/ dev and fixing tests
alfredorubin96 Feb 10, 2025
a752a30
changing pagination process
alfredorubin96 Feb 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions docs/modules/ROOT/pages/developer-guide/configuration.adoc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ will look like this:
"ssoProviders": [],
"ssoDiscoveryUrl": "https://example.com",
"standalone": false,
"standaloneProtocol": "neo4j",
"standaloneProtocol": "neo4j+s",
"standaloneHost": "localhost",
"standalonePort": "7687",
"standaloneDatabase": "neo4j",
Expand Down Expand Up @@ -55,7 +55,7 @@ mode (false), or reader mode (true). The terms ``Reader mode'' and
``Standalone mode'' are used interchangibly.

|standaloneProtocol |string |neo4j |When running in standalone mode, the
protocol to used for the Neo4j driver. This shoudl be set to one of
protocol to used for the Neo4j driver. This should be set to one of
`neo4j`, `neo4j+s`, `neo4j+ssc`, `bolt`, `bolt+s`, or `bolt+ssc`.

|standaloneHost |string |localhost |When running in standalone mode, the
Expand Down
2 changes: 1 addition & 1 deletion docs/modules/ROOT/pages/developer-guide/standalone-mode.adoc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ docker run -it --rm -p 5005:5005 \
-e ssoProviders=[] \
-e ssoDiscoveryUrl="https://example.com" \
-e standalone=true \
-e standaloneProtocol="neo4j" \
-e standaloneProtocol="neo4j+s" \
-e standaloneHost="localhost" \
-e standalonePort="7687" \
-e standaloneDatabase="neo4j" \
Expand Down
2 changes: 1 addition & 1 deletion docs/modules/ROOT/pages/developer-guide/state-management.adoc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,7 +129,7 @@ standalone mode.
"ssoEnabled": false,
"ssoProviders": [],
"ssoDiscoveryUrl": "https://example.com",
"standaloneProtocol": "neo4j",
"standaloneProtocol": "neo4j+s",
"standaloneHost": "localhost",
"standalonePort": "7687",
"standaloneDatabase": "neo4j",
Expand Down
2 changes: 1 addition & 1 deletion public/config.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
"ssoProviders": [],
"ssoDiscoveryUrl": "https://example.com",
"standalone": false,
"standaloneProtocol": "neo4j",
"standaloneProtocol": "neo4j+s",
"standaloneHost": "localhost",
"standalonePort": "7687",
"standaloneDatabase": "neo4j",
Expand Down
2 changes: 1 addition & 1 deletion src/application/ApplicationReducer.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ const initialState = {
draft: false,
aboutModalOpen: false,
connection: {
protocol: 'neo4j',
protocol: 'neo4j+s',
url: DEFAULT_NEO4J_URL,
port: '7687',
database: '',
Expand Down
2 changes: 1 addition & 1 deletion src/application/ApplicationThunks.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -265,12 +265,12 @@
if (urlParams.get('credentials')) {
setWelcomeScreenOpen(false);
const connection = decodeURIComponent(urlParams.get('credentials'));
const protocol = connection.split('://')[0];

Check warning on line 268 in src/application/ApplicationThunks.ts

View workflow job for this annotation

GitHub Actions / build-test (18.x) 

Use array destructuring
const username = connection.split('://')[1].split(':')[0];

Check warning on line 269 in src/application/ApplicationThunks.ts

View workflow job for this annotation

GitHub Actions / build-test (18.x) 

Use array destructuring
const password = connection.split('://')[1].split(':')[1].split('@')[0];

Check warning on line 270 in src/application/ApplicationThunks.ts

View workflow job for this annotation

GitHub Actions / build-test (18.x) 

Use array destructuring
const database = connection.split('@')[1].split(':')[0];

Check warning on line 271 in src/application/ApplicationThunks.ts

View workflow job for this annotation

GitHub Actions / build-test (18.x) 

Use array destructuring
const url = connection.split('@')[1].split(':')[1];

Check warning on line 272 in src/application/ApplicationThunks.ts

View workflow job for this annotation

GitHub Actions / build-test (18.x) 

Use array destructuring
const port = connection.split('@')[1].split(':')[2];

Check warning on line 273 in src/application/ApplicationThunks.ts

View workflow job for this annotation

GitHub Actions / build-test (18.x) 

Use array destructuring
// if (url == password) {
// // Special case where a connect link is generated without a password.
// // Here, the format is parsed incorrectly and we open the connection window instead.
Expand Down Expand Up @@ -410,7 +410,7 @@
ssoProviders: [],
ssoDiscoveryUrl: 'http://example.com',
standalone: false,
standaloneProtocol: 'neo4j',
standaloneProtocol: 'neo4j+s',
standaloneHost: 'localhost',
standalonePort: '7687',
standaloneDatabase: 'neo4j',
Expand Down Expand Up @@ -580,7 +580,7 @@
dispatch(initializeApplicationAsEditorThunk(config, paramsToSetAfterConnecting));
}
} catch (e) {
console.log(e);

Check warning on line 583 in src/application/ApplicationThunks.ts

View workflow job for this annotation

GitHub Actions / build-test (18.x) 

Unexpected console statement
dispatch(setWelcomeScreenOpen(false));
dispatch(
createNotificationThunk(
Expand Down
Loading