method has to return hello response, not logon.

Author: stefanak-michal

src/Authentication/BasicAuth.php

@@ -57,30 +57,30 @@ public function authenticateHttp(RequestInterface $request, UriInterface $uri, s
     }
 
     /**
+     * @return array{server: string, connection_id: string, hints: array}
      * @throws Exception
      */
     public function authenticateBolt(V4_4|V5|V5_1|V5_2|V5_3|V5_4 $protocol, string $userAgent): array
     {
         if (method_exists($protocol, 'logon')) {
             $protocol->hello(['user_agent' => $userAgent]);
-            ResponseHelper::getResponse($protocol);
-
+            $response = ResponseHelper::getResponse($protocol);
             $protocol->logon([
                 'scheme' => 'basic',
                 'principal' => $this->username,
                 'credentials' => $this->password,
             ]);
+            ResponseHelper::getResponse($protocol);
+            return $response->content;
         } else {
             $protocol->hello([
                 'user_agent' => $userAgent,
                 'scheme' => 'basic',
                 'principal' => $this->username,
                 'credentials' => $this->password,
             ]);
+            return ResponseHelper::getResponse($protocol)->content;
         }
-
-        /** @var array{server: string, connection_id: string, hints: list} */
-        return ResponseHelper::getResponse($protocol)->content;
     }
 
     public function toString(UriInterface $uri): string

src/Authentication/KerberosAuth.php

@@ -23,6 +23,7 @@
 use Laudis\Neo4j\Contracts\AuthenticateInterface;
 use Psr\Http\Message\RequestInterface;
 use Psr\Http\Message\UriInterface;
+use Exception;
 
 use function sprintf;
 
@@ -52,28 +53,31 @@ public function authenticateHttp(RequestInterface $request, UriInterface $uri, s
             ->withHeader('User-Agent', $userAgent);
     }
 
+    /**
+     * @return array{server: string, connection_id: string, hints: array}
+     * @throws Exception
+     */
     public function authenticateBolt(V4_4|V5|V5_1|V5_2|V5_3|V5_4 $protocol, string $userAgent): array
     {
         if (method_exists($protocol, 'logon')) {
             $protocol->hello(['user_agent' => $userAgent]);
-            ResponseHelper::getResponse($protocol);
-
+            $response = ResponseHelper::getResponse($protocol);
             $protocol->logon([
                 'scheme' => 'kerberos',
                 'principal' => '',
                 'credentials' => $this->token,
             ]);
+            ResponseHelper::getResponse($protocol);
+            return $response->content;
         } else {
             $protocol->hello([
                 'user_agent' => $userAgent,
                 'scheme' => 'kerberos',
                 'principal' => '',
                 'credentials' => $this->token,
             ]);
+            return ResponseHelper::getResponse($protocol)->content;
         }
-
-        /** @var array{server: string, connection_id: string, hints: list} */
-        return ResponseHelper::getResponse($protocol);
     }
 
     public function toString(UriInterface $uri): string

src/Authentication/NoAuth.php

@@ -23,6 +23,7 @@
 use Laudis\Neo4j\Contracts\AuthenticateInterface;
 use Psr\Http\Message\RequestInterface;
 use Psr\Http\Message\UriInterface;
+use Exception;
 
 use function sprintf;
 
@@ -44,24 +45,27 @@ public function authenticateHttp(RequestInterface $request, UriInterface $uri, s
         return $request->withHeader('User-Agent', $userAgent);
     }
 
+    /**
+     * @return array{server: string, connection_id: string, hints: array}
+     * @throws Exception
+     */
     public function authenticateBolt(V4_4|V5|V5_1|V5_2|V5_3|V5_4 $protocol, string $userAgent): array
     {
         if (method_exists($protocol, 'logon')) {
             $protocol->hello(['user_agent' => $userAgent]);
-            ResponseHelper::getResponse($protocol);
-
+            $response = ResponseHelper::getResponse($protocol);
             $protocol->logon([
                 'scheme' => 'none',
             ]);
+            ResponseHelper::getResponse($protocol);
+            return $response->content;
         } else {
             $protocol->hello([
                 'user_agent' => $userAgent,
                 'scheme' => 'none',
             ]);
+            return ResponseHelper::getResponse($protocol)->content;
         }
-
-        /** @var array{server: string, connection_id: string, hints: list} */
-        return ResponseHelper::getResponse($protocol)->content;
     }
 
     public function toString(UriInterface $uri): string

src/Authentication/OpenIDConnectAuth.php

@@ -23,6 +23,7 @@
 use Laudis\Neo4j\Contracts\AuthenticateInterface;
 use Psr\Http\Message\RequestInterface;
 use Psr\Http\Message\UriInterface;
+use Exception;
 
 use function sprintf;
 
@@ -49,26 +50,29 @@ public function authenticateHttp(RequestInterface $request, UriInterface $uri, s
             ->withHeader('User-Agent', $userAgent);
     }
 
+    /**
+     * @return array{server: string, connection_id: string, hints: array}
+     * @throws Exception
+     */
     public function authenticateBolt(V4_4|V5|V5_1|V5_2|V5_3|V5_4 $protocol, string $userAgent): array
     {
         if (method_exists($protocol, 'logon')) {
             $protocol->hello(['user_agent' => $userAgent]);
-            ResponseHelper::getResponse($protocol);
-
+            $response = ResponseHelper::getResponse($protocol);
             $protocol->logon([
                 'scheme' => 'bearer',
                 'credentials' => $this->token,
             ]);
+            ResponseHelper::getResponse($protocol);
+            return $response->content;
         } else {
             $protocol->hello([
                 'user_agent' => $userAgent,
                 'scheme' => 'bearer',
                 'credentials' => $this->token,
             ]);
+            return ResponseHelper::getResponse($protocol)->content;
         }
-
-        /** @var array{server: string, connection_id: string, hints: list} */
-        return ResponseHelper::getResponse($protocol)->content;
     }
 
     public function toString(UriInterface $uri): string