refactor: Create factory for messages

Author: exaby73

src/Bolt/BoltConnection.php

@@ -23,7 +23,6 @@
 use Bolt\protocol\V5_3;
 use Bolt\protocol\V5_4;
 use Exception;
-use Laudis\Neo4j\Bolt\Messages\BoltGoodbyeMessage;
 use Laudis\Neo4j\Common\ConnectionConfiguration;
 use Laudis\Neo4j\Common\Neo4jLogger;
 use Laudis\Neo4j\Contracts\AuthenticateInterface;
@@ -334,10 +333,7 @@ public function close(): void
                     $this->consumeResults();
                 }
 
-                $message = new BoltGoodbyeMessage(
-                    $this->protocol(),
-                    $this->logger
-                );
+                $message = $this->messageFactory->createGoodbyeMessage();
                 $message->send();
 
                 unset($this->boltProtocol); // has to be set to null as the sockets don't recover nicely contrary to what the underlying code might lead you to believe;

src/Bolt/BoltMessageFactory.php

@@ -0,0 +1,82 @@
+<?php
+
+declare(strict_types=1);
+
+/*
+ * This file is part of the Neo4j PHP Client and Driver package.
+ *
+ * (c) Nagels <https://nagels.tech>
+ *
+ * For the full copyright and license information, please view the LICENSE
+ * file that was distributed with this source code.
+ */
+
+namespace Laudis\Neo4j\Bolt;
+
+use Bolt\protocol\V4_4;
+use Bolt\protocol\V5;
+use Bolt\protocol\V5_1;
+use Bolt\protocol\V5_2;
+use Bolt\protocol\V5_3;
+use Bolt\protocol\V5_4;
+use Laudis\Neo4j\Bolt\Messages\BoltBeginMessage;
+use Laudis\Neo4j\Bolt\Messages\BoltCommitMessage;
+use Laudis\Neo4j\Bolt\Messages\BoltDiscardMessage;
+use Laudis\Neo4j\Bolt\Messages\BoltGoodbyeMessage;
+use Laudis\Neo4j\Bolt\Messages\BoltPullMessage;
+use Laudis\Neo4j\Bolt\Messages\BoltResetMessage;
+use Laudis\Neo4j\Bolt\Messages\BoltRollbackMessage;
+use Laudis\Neo4j\Bolt\Messages\BoltRunMessage;
+use Laudis\Neo4j\Common\Neo4jLogger;
+
+/**
+ * Factory class for creating Bolt protocol messages.
+ */
+final class BoltMessageFactory
+{
+    public function __construct(
+        private readonly V4_4|V5|V5_1|V5_2|V5_3|V5_4 $protocol,
+        private readonly ?Neo4jLogger $logger = null,
+    ) {
+    }
+
+    public function createResetMessage(): BoltResetMessage
+    {
+        return new BoltResetMessage($this->protocol, $this->logger);
+    }
+
+    public function createBeginMessage(array $extra): BoltBeginMessage
+    {
+        return new BoltBeginMessage($this->protocol, $extra, $this->logger);
+    }
+
+    public function createDiscardMessage(array $extra): BoltDiscardMessage
+    {
+        return new BoltDiscardMessage($this->protocol, $extra, $this->logger);
+    }
+
+    public function createRunMessage(string $text, array $parameters, array $extra): BoltRunMessage
+    {
+        return new BoltRunMessage($this->protocol, $text, $parameters, $extra, $this->logger);
+    }
+
+    public function createCommitMessage(): BoltCommitMessage
+    {
+        return new BoltCommitMessage($this->protocol, $this->logger);
+    }
+
+    public function createRollbackMessage(): BoltRollbackMessage
+    {
+        return new BoltRollbackMessage($this->protocol, $this->logger);
+    }
+
+    public function createPullMessage(array $extra): BoltPullMessage
+    {
+        return new BoltPullMessage($this->protocol, $extra, $this->logger);
+    }
+
+    public function createGoodbyeMessage(): BoltGoodbyeMessage
+    {
+        return new BoltGoodbyeMessage($this->protocol, $this->logger);
+    }
+}