fixed testkit-backend id in response

Author: transistive

.github/workflows/testkit.yml

@@ -0,0 +1,56 @@
+name: Testkit Tests
+
+on:
+  push:
+    branches: [ '**' ]
+  pull_request:
+    branches: ['**']
+
+jobs:
+  tests:
+    runs-on: ubuntu-latest
+    env:
+      NEO4J_CONNECTIONS: bolt://neo4j:test@localhost,http://neo4j:test@localhost
+    name: "Running Integration tests for PHP 7.4 on Neo4j ${{ matrix.neo4j-version }} with simple config"
+    strategy:
+      fail-fast: false
+      matrix:
+        neo4j-version: ["3.5", "4.0", "4.1", "4.2", "4.3"]
+        php-version: ["7.4", "8.0", "8.1"]
+
+    services:
+      neo4j:
+        image: neo4j:${{ matrix.neo4j-version }}
+        env:
+          NEO4J_AUTH: neo4j/test
+          NEO4JLABS_PLUGINS: '["apoc"]'
+        ports:
+          - 7687:7687
+          - 7474:7474
+        options: >-
+          --health-cmd "wget http://localhost:7474 || exit 1"
+      testkit-backend:
+        image: php:${{ matrix.neo4j-version }}
+        env:
+          NEO4J_AUTH: neo4j/test
+          NEO4JLABS_PLUGINS: '["apoc"]'
+        ports:
+          - 7687:7687
+          - 7474:7474
+        options: >-
+          --health-cmd "wget http://localhost:7474 || exit 1"
+
+    steps:
+      - uses: actions/checkout@v2
+      - uses: php-actions/composer@v6
+        with:
+          progress: yes
+          php_version: 7.4
+          version: 2
+      - uses: php-actions/phpunit@v3
+        with:
+          configuration: phpunit.xml.dist
+          php_version: 7.4
+          php_extensions: bcmath
+          bootstrap: vendor/autoload.php
+          args: --testsuite "Integration"

testkit-backend/src/Handlers/NewDriver.php

@@ -23,6 +23,7 @@
 use Laudis\Neo4j\TestkitBackend\Requests\NewDriverRequest;
 use Laudis\Neo4j\TestkitBackend\Responses\DriverResponse;
 use Symfony\Component\Uid\Uuid;
+use function var_export;
 
 /**
  * @implements RequestHandlerInterface<NewDriverRequest>
@@ -55,6 +56,7 @@ public function handle($request): DriverResponse
         $formatter = SummarizedResultFormatter::create();
         $authenticate = Authenticate::basic($user, $pass);
         $driver = DriverFactory::create($request->getUri(), $config, $authenticate, $timeout, $formatter);
+
         $id = Uuid::v4();
         $this->repository->addDriver($id, $driver);
 

testkit-backend/src/Handlers/RetryablePositive.php

@@ -15,7 +15,6 @@
 
 use Laudis\Neo4j\TestkitBackend\Contracts\RequestHandlerInterface;
 use Laudis\Neo4j\TestkitBackend\Contracts\TestkitResponseInterface;
-use Laudis\Neo4j\TestkitBackend\MainRepository;
 use Laudis\Neo4j\TestkitBackend\Requests\RetryablePositiveRequest;
 use Laudis\Neo4j\TestkitBackend\Responses\RetryableDoneResponse;
 
@@ -24,20 +23,11 @@
  */
 final class RetryablePositive implements RequestHandlerInterface
 {
-    private MainRepository $repository;
-
-    public function __construct(MainRepository $repository)
-    {
-        $this->repository = $repository;
-    }
-
     /**
      * @param RetryablePositiveRequest $request
      */
     public function handle($request): TestkitResponseInterface
     {
-        $id = $this->repository->getTsxIdFromSession($request->getSessionId());
-
-        return new RetryableDoneResponse($id);
+        return new RetryableDoneResponse();
     }
 }

testkit-backend/src/Responses/RetryableDoneResponse.php

@@ -21,20 +21,11 @@
  */
 final class RetryableDoneResponse implements TestkitResponseInterface
 {
-    private Uuid $id;
-
-    public function __construct(Uuid $id)
-    {
-        $this->id = $id;
-    }
-
     public function jsonSerialize(): array
     {
         return [
             'name' => 'RetryableDone',
-            'data' => [
-                'id' => $this->id->toRfc4122(),
-            ],
+            'data' => [],
         ];
     }
 }

testkit-backend/testkit.sh

@@ -1,6 +1,6 @@
 #!/bin/bash
 
-export TEST_NEO4J_HOST=neo4j
+export TEST_NEO4J_HOST=localhost
 export TEST_NEO4J_USER=neo4j
 export TEST_NEO4J_PASS=test
 export TEST_DRIVER_NAME=php