initial kickoff

Author: transistive

docker-compose-neo4j-4.yml

@@ -31,7 +31,7 @@ services:
       context: .
       dockerfile: Dockerfile
       args:
-        PHP_VERSION: ${PHP_VERSION}
+        PHP_VERSION: "${PHP_VERSION-8.1}"
     networks:
       - neo4j
     volumes:
@@ -46,7 +46,7 @@ services:
       context: .
       dockerfile: Dockerfile
       args:
-        PHP_VERSION: ${PHP_VERSION}
+        PHP_VERSION: "${PHP_VERSION-8.1}"
         WITH_XDEBUG: true
     working_dir: /opt/project
     volumes:

docker-compose.yml

@@ -25,7 +25,7 @@ x-definitions:
       context: .
       dockerfile: Dockerfile
       args:
-        PHP_VERSION: ${PHP_VERSION}
+        PHP_VERSION: "${PHP_VERSION-8.1}"
     volumes:
       - .:/opt/project
   x-common-cluster:

src/Bolt/BoltDriver.php

@@ -15,6 +15,7 @@
 
 use Exception;
 
+use Psr\Log\LogLevel;
 use function is_string;
 
 use Laudis\Neo4j\Authentication\Authenticate;
@@ -103,7 +104,8 @@ public function verifyConnectivity(?SessionConfiguration $config = null): bool
         $config ??= SessionConfiguration::default();
         try {
             GeneratorHelper::getReturnFromGenerator($this->pool->acquire($config));
-        } catch (Throwable) {
+        } catch (ConnectException $e) {
+            $this->pool->getLogger()->log(LogLevel::WARNING, 'Could not connect to server on URI ' . $this->parsedUrl->__toString(), ['error' => $e]);
             return false;
         }
 

src/Common/DriverSetupManager.php

@@ -13,6 +13,8 @@
 
 namespace Laudis\Neo4j\Common;
 
+use Bolt\error\ConnectException;
+use Psr\Log\LogLevel;
 use function array_key_exists;
 use function array_key_first;
 use function array_reduce;
@@ -144,7 +146,12 @@ public function verifyConnectivity(SessionConfiguration $config, ?string $alias
     {
         try {
             $this->getDriver($config, $alias);
-        } catch (RuntimeException) {
+        } catch (ConnectException $e) {
+            $this->getLogger()->log(
+                LogLevel::WARNING,
+                sprintf('Could not connect to server using alias (%s)', $alias ?? '<default>'),
+                ['exception' => $e]
+            );
             return false;
         }
 

src/Neo4j/Neo4jDriver.php

@@ -13,8 +13,10 @@
 
 namespace Laudis\Neo4j\Neo4j;
 
+use Bolt\error\ConnectException;
 use Exception;
 
+use Psr\Log\LogLevel;
 use function is_string;
 
 use Laudis\Neo4j\Authentication\Authenticate;
@@ -31,7 +33,6 @@
 use Laudis\Neo4j\Databags\SessionConfiguration;
 use Laudis\Neo4j\Formatter\OGMFormatter;
 use Psr\Http\Message\UriInterface;
-use Throwable;
 
 /**
  * Driver for auto client-side routing.
@@ -105,7 +106,9 @@ public function verifyConnectivity(?SessionConfiguration $config = null): bool
         $config ??= SessionConfiguration::default();
         try {
             GeneratorHelper::getReturnFromGenerator($this->pool->acquire($config));
-        } catch (Throwable) {
+        } catch (ConnectException $e) {
+            $this->pool->getLogger()->log(LogLevel::WARNING, 'Could not connect to server on URI ' . $this->parsedUrl->__toString(), ['error' => $e]);
+
             return false;
         }
 

tests/Integration/ClientIntegrationTest.php

@@ -19,16 +19,48 @@
 use Laudis\Neo4j\Bolt\BoltDriver;
 use Laudis\Neo4j\Bolt\ConnectionPool;
 use Laudis\Neo4j\ClientBuilder;
+use Laudis\Neo4j\Common\Uri;
 use Laudis\Neo4j\Contracts\DriverInterface;
 use Laudis\Neo4j\Contracts\TransactionInterface;
+use Laudis\Neo4j\Databags\DriverConfiguration;
 use Laudis\Neo4j\Databags\SessionConfiguration;
 use Laudis\Neo4j\Databags\Statement;
 use Laudis\Neo4j\Exception\Neo4jException;
 use Laudis\Neo4j\Tests\EnvironmentAwareIntegrationTest;
+use Psr\Log\LoggerInterface;
+use Psr\Log\LogLevel;
 use ReflectionClass;
 
 final class ClientIntegrationTest extends EnvironmentAwareIntegrationTest
 {
+    public function testDriverAuthFailureVerifyConnectivity(): void
+    {
+        $connection = $_ENV['CONNECTION'] ?? false;
+        if (str_starts_with($connection, 'http')) {
+            $this->markTestSkipped('HTTP does not support auth failure connectivity passing');
+        }
+
+        if (!is_string($connection)) {
+            $connection = 'bolt://localhost';
+        }
+
+        $uri = Uri::create($connection);
+        $uri = $uri->withUserInfo('neo4j', 'absolutelyonehundredpercentawrongpassword');
+
+        /** @noinspection PhpUnhandledExceptionInspection */
+        $conf = DriverConfiguration::default()->withLogger(LogLevel::DEBUG, $this->createMock(LoggerInterface::class));
+        $logger = $conf->getLogger();
+        if ($logger === null) {
+            throw new RuntimeException('Logger not set');
+        }
+
+        $driver = Driver::create($uri, $conf);
+
+        $this->expectException(Neo4jException::class);
+        $this->expectExceptionMessage('Neo4j errors detected. First one with code "Neo.ClientError.Security.Unauthorized" and message "The client is unauthorized due to authentication failure."');
+        $driver->verifyConnectivity();
+    }
+
     public function testDifferentAuth(): void
     {
         $auth = Authenticate::fromUrl($this->getUri());