fixed static analysis

Author: transistive

src/Bolt/BoltConnectionPool.php

@@ -13,7 +13,9 @@
 
 namespace Laudis\Neo4j\Bolt;
 
+use Bolt\protocol\V3;
 use Exception;
+use function explode;
 use Laudis\Neo4j\BoltFactory;
 use Laudis\Neo4j\Common\ConnectionConfiguration;
 use Laudis\Neo4j\Contracts\AuthenticateInterface;
@@ -24,9 +26,7 @@
 use Laudis\Neo4j\Enum\ConnectionProtocol;
 use Laudis\Neo4j\Neo4j\RoutingTable;
 use Psr\Http\Message\UriInterface;
-use Bolt\protocol\V3;
 use Throwable;
-use function explode;
 
 /**
  * Manages singular Bolt connections.

src/Bolt/BoltResult.php

@@ -13,13 +13,13 @@
 
 namespace Laudis\Neo4j\Bolt;
 
+use function array_splice;
 use BadMethodCallException;
+use function call_user_func;
+use function count;
 use Generator;
 use Iterator;
 use Laudis\Neo4j\Enum\ConnectionProtocol;
-use function array_splice;
-use function call_user_func;
-use function count;
 
 /**
  * @psalm-import-type BoltCypherStats from \Laudis\Neo4j\Contracts\FormatterInterface

src/Bolt/BoltUnmanagedTransaction.php

@@ -25,8 +25,8 @@
 use Laudis\Neo4j\ParameterHelper;
 use Laudis\Neo4j\Types\AbstractCypherSequence;
 use Laudis\Neo4j\Types\CypherList;
-use Throwable;
 use function microtime;
+use Throwable;
 
 /**
  * Manages a transaction over the bolt protocol.

src/Contracts/FormatterInterface.php

@@ -14,7 +14,6 @@
 namespace Laudis\Neo4j\Contracts;
 
 use Bolt\Bolt;
-use Bolt\protocol\V3;
 use JsonException;
 use Laudis\Neo4j\Bolt\BoltConnection;
 use Laudis\Neo4j\Bolt\BoltResult;
@@ -74,7 +73,7 @@ interface FormatterInterface
     /**
      * Formats the results of the bolt protocol to the unified format.
      *
-     * @param BoltMeta                $meta
+     * @param BoltMeta $meta
      *
      * @return ResultFormat
      */

src/Formatter/SummarizedResultFormatter.php

@@ -13,13 +13,13 @@
 
 namespace Laudis\Neo4j\Formatter;
 
-use Laudis\Neo4j\Bolt\BoltConnection;
-use Laudis\Neo4j\Databags\DatabaseInfo;
 use function in_array;
 use function is_int;
+use Laudis\Neo4j\Bolt\BoltConnection;
 use Laudis\Neo4j\Bolt\BoltResult;
 use Laudis\Neo4j\Contracts\ConnectionInterface;
 use Laudis\Neo4j\Contracts\FormatterInterface;
+use Laudis\Neo4j\Databags\DatabaseInfo;
 use Laudis\Neo4j\Databags\ResultSummary;
 use Laudis\Neo4j\Databags\ServerInfo;
 use Laudis\Neo4j\Databags\Statement;

src/Http/HttpConnectionPool.php

@@ -13,14 +13,13 @@
 
 namespace Laudis\Neo4j\Http;
 
-use Laudis\Neo4j\Common\ConnectionConfiguration;
-use Laudis\Neo4j\Databags\DriverConfiguration;
 use function json_encode;
+use Laudis\Neo4j\Common\ConnectionConfiguration;
 use Laudis\Neo4j\Common\Resolvable;
 use Laudis\Neo4j\Contracts\AuthenticateInterface;
-use Laudis\Neo4j\Contracts\ConnectionInterface;
 use Laudis\Neo4j\Contracts\ConnectionPoolInterface;
 use Laudis\Neo4j\Databags\DatabaseInfo;
+use Laudis\Neo4j\Databags\DriverConfiguration;
 use Laudis\Neo4j\Databags\SessionConfiguration;
 use Laudis\Neo4j\Enum\ConnectionProtocol;
 use Laudis\Neo4j\Formatter\BasicFormatter;

src/Http/HttpDriver.php

@@ -118,7 +118,7 @@ public function createSession(?SessionConfiguration $config = null): SessionInte
             $this->formatter,
             $factory,
             Resolvable::once($this->key.':tsxUrl', function () use ($config, $factory) {
-                $database = $config->getDatabase();
+                $database = $config->getDatabase() ?? '';
                 $request = $factory->resolve()->createRequest('GET', $this->uri);
                 $client = $this->config->getHttpPsrBindings()->getClient();
 

src/Http/HttpSession.php

@@ -17,7 +17,6 @@
 use Laudis\Neo4j\Common\Resolvable;
 use Laudis\Neo4j\Common\TransactionHelper;
 use Laudis\Neo4j\Contracts\AuthenticateInterface;
-use Laudis\Neo4j\Contracts\ConnectionInterface;
 use Laudis\Neo4j\Contracts\FormatterInterface;
 use Laudis\Neo4j\Contracts\SessionInterface;
 use Laudis\Neo4j\Contracts\UnmanagedTransactionInterface;
@@ -29,7 +28,6 @@
 use function microtime;
 use function parse_url;
 use const PHP_URL_PATH;
-use Psr\Http\Client\ClientInterface;
 use Psr\Http\Message\RequestInterface;
 use Psr\Http\Message\StreamFactoryInterface;
 use stdClass;
@@ -193,11 +191,9 @@ public function beginTransaction(?iterable $statements = null, ?TransactionConfi
     }
 
     /**
-     * @param ConnectionInterface<ClientInterface> $connection
-     *
      * @return HttpUnmanagedTransaction<T>
      */
-    private function makeTransaction(ConnectionInterface $connection, RequestInterface $request): HttpUnmanagedTransaction
+    private function makeTransaction(HttpConnection $connection, RequestInterface $request): HttpUnmanagedTransaction
     {
         return new HttpUnmanagedTransaction(
             $request,

src/Neo4j/Neo4jConnectionPool.php

@@ -13,10 +13,13 @@
 
 namespace Laudis\Neo4j\Neo4j;
 
+use function array_slice;
+use function array_unique;
 use Bolt\protocol\V3;
 use Bolt\protocol\V4;
 use Bolt\protocol\V4_3;
 use Bolt\protocol\V4_4;
+use function count;
 use Exception;
 use Laudis\Neo4j\Bolt\BoltConnection;
 use Laudis\Neo4j\Bolt\BoltConnectionPool;
@@ -28,9 +31,6 @@
 use Laudis\Neo4j\Enum\AccessMode;
 use Laudis\Neo4j\Enum\RoutingRoles;
 use Psr\Http\Message\UriInterface;
-use function array_slice;
-use function array_unique;
-use function count;
 use function random_int;
 use function str_starts_with;
 use function time;

tests/Integration/BoltResultIntegrationTest.php

@@ -14,6 +14,8 @@
 use Bolt\Bolt;
 use Bolt\connection\StreamSocket;
 use Dotenv\Dotenv;
+use function explode;
+use function is_string;
 use Laudis\Neo4j\Authentication\Authenticate;
 use Laudis\Neo4j\Bolt\BoltConnection;
 use Laudis\Neo4j\Bolt\BoltResult;
@@ -24,8 +26,6 @@
 use Laudis\Neo4j\Enum\AccessMode;
 use Laudis\Neo4j\Enum\ConnectionProtocol;
 use PHPUnit\Framework\TestCase;
-use function explode;
-use function is_string;
 
 final class BoltResultIntegrationTest extends TestCase
 {