feat: Add explicit close() method to BoltConnection instead of relying on __destruct

Author: exaby73

src/Bolt/BoltConnection.php

@@ -143,7 +143,23 @@ public function getAuthentication(): AuthenticateInterface
      */
     public function isOpen(): bool
     {
-        return !in_array($this->protocol()->serverState, [ServerState::DISCONNECTED, ServerState::DEFUNCT], true);
+        return !in_array(
+            $this->protocol()->serverState,
+            [ServerState::DISCONNECTED, ServerState::DEFUNCT],
+            true
+        );
+    }
+
+    /**
+     * @psalm-mutation-free
+     */
+    public function isStreaming(): bool
+    {
+        return in_array(
+            $this->protocol()->serverState,
+            [ServerState::STREAMING, ServerState::TX_STREAMING],
+            true
+        );
     }
 
     public function setTimeout(float $timeout): void
@@ -154,7 +170,8 @@ public function setTimeout(float $timeout): void
     public function consumeResults(): void
     {
         $this->logger?->log(LogLevel::DEBUG, 'Consuming results');
-        if ($this->protocol()->serverState !== ServerState::STREAMING && $this->protocol()->serverState !== ServerState::TX_STREAMING) {
+        if ($this->protocol()->serverState !== ServerState::STREAMING && $this->protocol(
+        )->serverState !== ServerState::TX_STREAMING) {
             $this->subscribedResults = [];
 
             return;
@@ -225,8 +242,14 @@ public function discard(?int $qid): void
      *
      * @return BoltMeta
      */
-    public function run(string $text, array $parameters, ?string $database, ?float $timeout, BookmarkHolder $holder, ?AccessMode $mode): array
-    {
+    public function run(
+        string $text,
+        array $parameters,
+        ?string $database,
+        ?float $timeout,
+        BookmarkHolder $holder,
+        ?AccessMode $mode
+    ): array {
         $extra = $this->buildRunExtra($database, $timeout, $holder, $mode);
         $this->logger?->log(LogLevel::DEBUG, 'RUN', $extra);
         $response = $this->protocol()
@@ -298,10 +321,15 @@ public function pull(?int $qid, ?int $fetchSize): array
     }
 
     public function __destruct()
+    {
+        $this->close();
+    }
+
+    public function close(): void
     {
         try {
             if ($this->isOpen()) {
-                if ($this->protocol()->serverState === ServerState::STREAMING || $this->protocol()->serverState === ServerState::TX_STREAMING) {
+                if ($this->isStreaming()) {
                     $this->consumeResults();
                 }
 

src/Bolt/ConnectionPool.php

@@ -172,6 +172,9 @@ private function returnAnyAvailableConnection(SessionConfiguration $config): ?Co
 
     public function close(): void
     {
+        foreach ($this->activeConnections as $activeConnection) {
+            $activeConnection->close();
+        }
         $this->activeConnections = [];
     }
 }

src/Contracts/ConnectionInterface.php

@@ -112,4 +112,9 @@ public function getEncryptionLevel(): string;
      * Returns the user agent handling this connection.
      */
     public function getUserAgent(): string;
+
+    /**
+     * Closes the connection.
+     */
+    public function close(): void;
 }