Skip to content

Commit 6f78e9a

Browse files
transistivetransistive
committed
fixed unused default driver config member variable
Fixes #191
1 parent b8e7662 commit 6f78e9a

File tree

3 files changed

+183
-5
lines changed

3 files changed

+183
-5
lines changed

‎psalm-baseline.xml

Lines changed: 180 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,2 +1,181 @@
11
<?xml version="1.0" encoding="UTF-8"?>
2-
<files psalm-version="5.15.0@5c774aca4746caf3d239d9c8cadb9f882ca29352"/>
2+
<files psalm-version="5.15.0@5c774aca4746caf3d239d9c8cadb9f882ca29352">
3+
<file src="src/Authentication/Authenticate.php">
4+
<PossiblyUndefinedIntArrayOffset>
5+
<code>$pass</code>
6+
</PossiblyUndefinedIntArrayOffset>
7+
</file>
8+
<file src="src/Bolt/SslConfigurationFactory.php">
9+
<LessSpecificReturnStatement>
10+
<code><![CDATA[[$sslConfig, $this->enableSsl($uri->getHost(), $sslConfig, $config)]]]></code>
11+
<code>[$sslConfig, []]</code>
12+
</LessSpecificReturnStatement>
13+
<MoreSpecificReturnType>
14+
<code><![CDATA[array{0: 's'|'ssc'|'', 1: array{verify_peer?: bool, peer_name?: string, SNI_enabled?: bool, allow_self_signed?: bool}}]]></code>
15+
</MoreSpecificReturnType>
16+
</file>
17+
<file src="src/Common/SysVSemaphore.php">
18+
<InvalidArgument>
19+
<code><![CDATA[$this->semaphore]]></code>
20+
<code><![CDATA[$this->semaphore]]></code>
21+
<code>sem_get(hexdec($key), $max)</code>
22+
</InvalidArgument>
23+
</file>
24+
<file src="src/Databags/DatabaseInfo.php">
25+
<MissingTemplateParam>
26+
<code>DatabaseInfo</code>
27+
</MissingTemplateParam>
28+
</file>
29+
<file src="src/Databags/Plan.php">
30+
<MissingTemplateParam>
31+
<code>Plan</code>
32+
</MissingTemplateParam>
33+
</file>
34+
<file src="src/Databags/ProfiledPlan.php">
35+
<MissingTemplateParam>
36+
<code>ProfiledPlan</code>
37+
</MissingTemplateParam>
38+
</file>
39+
<file src="src/Databags/ResultSummary.php">
40+
<MissingTemplateParam>
41+
<code>ResultSummary</code>
42+
</MissingTemplateParam>
43+
</file>
44+
<file src="src/Databags/ServerInfo.php">
45+
<MissingTemplateParam>
46+
<code>ServerInfo</code>
47+
</MissingTemplateParam>
48+
</file>
49+
<file src="src/Databags/Statement.php">
50+
<MissingTemplateParam>
51+
<code>Statement</code>
52+
</MissingTemplateParam>
53+
</file>
54+
<file src="src/Databags/SummaryCounters.php">
55+
<MissingTemplateParam>
56+
<code>SummaryCounters</code>
57+
</MissingTemplateParam>
58+
</file>
59+
<file src="src/Formatter/BasicFormatter.php">
60+
<ImplementedParamTypeMismatch>
61+
<code>$meta</code>
62+
</ImplementedParamTypeMismatch>
63+
</file>
64+
<file src="src/Formatter/Specialised/JoltHttpOGMTranslator.php">
65+
<PossiblyUndefinedArrayOffset>
66+
<code>$coordinates</code>
67+
</PossiblyUndefinedArrayOffset>
68+
</file>
69+
<file src="src/Formatter/Specialised/LegacyHttpOGMTranslator.php">
70+
<ArgumentTypeCoercion>
71+
<code>$value</code>
72+
<code>$value</code>
73+
</ArgumentTypeCoercion>
74+
<InvalidReturnStatement>
75+
<code><![CDATA[$this->translateCypherList($value, $meta)]]></code>
76+
<code>[new CypherList($tbr), $meta]</code>
77+
</InvalidReturnStatement>
78+
<InvalidReturnType>
79+
<code>array{0: OGMTypes, 1: HttpMetaInfo}</code>
80+
</InvalidReturnType>
81+
<PossiblyUndefinedIntArrayOffset>
82+
<code>$milliseconds</code>
83+
<code>$milliseconds</code>
84+
<code>$secondsFraction</code>
85+
<code>$time</code>
86+
<code>$time</code>
87+
<code>$timezone</code>
88+
<code>$tzMinutes</code>
89+
</PossiblyUndefinedIntArrayOffset>
90+
</file>
91+
<file src="src/Formatter/SummarizedResultFormatter.php">
92+
<InvalidArgument>
93+
<code>$response</code>
94+
</InvalidArgument>
95+
<InvalidArrayOffset>
96+
<code><![CDATA[$response['db']]]></code>
97+
</InvalidArrayOffset>
98+
</file>
99+
<file src="src/Types/Abstract3DPoint.php">
100+
<ImplementedReturnTypeMismatch>
101+
<code>array{x: float, y: float, z: float, srid: int, crs: Crs}</code>
102+
</ImplementedReturnTypeMismatch>
103+
</file>
104+
<file src="src/Types/AbstractCypherSequence.php">
105+
<InvalidPropertyAssignmentValue>
106+
<code><![CDATA[$this->keyCache]]></code>
107+
<code><![CDATA[$this->keyCache]]></code>
108+
</InvalidPropertyAssignmentValue>
109+
</file>
110+
<file src="src/Types/AbstractPoint.php">
111+
<MissingTemplateParam>
112+
<code>AbstractPoint</code>
113+
</MissingTemplateParam>
114+
</file>
115+
<file src="src/Types/ArrayList.php">
116+
<ImplementedReturnTypeMismatch>
117+
<code><![CDATA[static<TValue|NewValue>]]></code>
118+
</ImplementedReturnTypeMismatch>
119+
</file>
120+
<file src="src/Types/Map.php">
121+
<ImplementedReturnTypeMismatch>
122+
<code><![CDATA[static<TValue|NewValue>]]></code>
123+
</ImplementedReturnTypeMismatch>
124+
</file>
125+
<file src="tests/Unit/BoltFactoryTest.php">
126+
<InvalidArgument>
127+
<code>$connection</code>
128+
<code>new Packer()</code>
129+
<code>new Unpacker()</code>
130+
</InvalidArgument>
131+
<TooManyArguments>
132+
<code>new V5(new Packer(), new Unpacker(), $connection, new ServerState())</code>
133+
</TooManyArguments>
134+
</file>
135+
<file src="tests/Unit/CypherListTest.php">
136+
<NoValue>
137+
<code>$item</code>
138+
</NoValue>
139+
<UnevaluatedCode>
140+
<code>++$counter;</code>
141+
<code>self::assertEquals(0, $counter);</code>
142+
<code><![CDATA[self::assertEquals(['A', 'B', 'C'][$key], $item);]]></code>
143+
</UnevaluatedCode>
144+
<UnusedVariable>
145+
<code>$counter</code>
146+
<code>$key</code>
147+
</UnusedVariable>
148+
</file>
149+
<file src="tests/Unit/CypherMapTest.php">
150+
<MissingTemplateParam>
151+
<code>IteratorAggregate</code>
152+
</MissingTemplateParam>
153+
<NoValue>
154+
<code>$item</code>
155+
</NoValue>
156+
<UnevaluatedCode>
157+
<code>++$counter;</code>
158+
<code>self::assertEquals(0, $counter);</code>
159+
<code><![CDATA[self::assertEquals(['A' => 'x'][$key], $item);]]></code>
160+
</UnevaluatedCode>
161+
<UnusedVariable>
162+
<code>$counter</code>
163+
<code>$key</code>
164+
</UnusedVariable>
165+
</file>
166+
<file src="tests/Unit/DNSAddressResolverTest.php">
167+
<InvalidOperand>
168+
<code><![CDATA[$this->resolver->getAddresses('8.8.8.8')]]></code>
169+
<code><![CDATA[$this->resolver->getAddresses('bogus')]]></code>
170+
<code><![CDATA[$this->resolver->getAddresses('test.ghlen.com')]]></code>
171+
</InvalidOperand>
172+
<NoValue>
173+
<code>$records</code>
174+
</NoValue>
175+
</file>
176+
<file src="tests/Unit/ParameterHelperTest.php">
177+
<MissingTemplateParam>
178+
<code>Iterator</code>
179+
</MissingTemplateParam>
180+
</file>
181+
</files>

‎src/ClientBuilder.php

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -48,8 +48,6 @@ final class ClientBuilder
4848
* @param DriverSetupManager<T> $driverSetups
4949
*/
5050
public function __construct(
51-
/** @psalm-readonly */
52-
private DriverConfiguration $defaultDriverConfig,
5351
/** @psalm-readonly */
5452
private SessionConfiguration $defaultSessionConfig,
5553
/** @psalm-readonly */
@@ -67,7 +65,6 @@ public function __construct(
6765
public static function create(): ClientBuilder
6866
{
6967
return new self(
70-
DriverConfiguration::default(),
7168
SessionConfiguration::default(),
7269
TransactionConfiguration::default(),
7370
new DriverSetupManager(SummarizedResultFormatter::create(), DriverConfiguration::default())
@@ -134,7 +131,6 @@ public function withDefaultDriver(string $alias): self
134131
public function withFormatter(FormatterInterface $formatter): self
135132
{
136133
return new self(
137-
$this->defaultDriverConfig,
138134
$this->defaultSessionConfig,
139135
$this->defaultTransactionConfig,
140136
$this->driverSetups->withFormatter($formatter)

‎src/Common/DriverSetupManager.php

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -62,6 +62,9 @@ public function getDriverConfiguration(): DriverConfiguration
6262
return $this->configuration;
6363
}
6464

65+
/**
66+
* @psalm-mutation-free
67+
*/
6568
public function withDriverConfiguration(DriverConfiguration $config): self
6669
{
6770
$tbr = clone $this;

0 commit comments

Comments
 (0)