white box test to test connection recycling

Author: transistive

src/Bolt/BoltUnmanagedTransaction.php

@@ -163,4 +163,9 @@ private function getBolt(): Bolt
     {
         return $this->connection->getImplementation();
     }
+
+    public function __destruct()
+    {
+        $this->connection->close();
+    }
 }

src/Http/HttpUnmanagedTransaction.php

@@ -130,4 +130,9 @@ public function rollback(): void
 
         HttpHelper::interpretResponse($response);
     }
+
+    public function __destruct()
+    {
+        $this->connection->close();
+    }
 }

tests/Integration/TransactionIntegrationTest.php

@@ -13,11 +13,15 @@
 
 namespace Laudis\Neo4j\Tests\Integration;
 
+use Laudis\Neo4j\Bolt\BoltConnectionPool;
+use Laudis\Neo4j\Bolt\BoltDriver;
 use Laudis\Neo4j\Contracts\FormatterInterface;
 use Laudis\Neo4j\Databags\Statement;
 use Laudis\Neo4j\Exception\InvalidTransactionStateException;
 use Laudis\Neo4j\Exception\Neo4jException;
 use Laudis\Neo4j\Formatter\BasicFormatter;
+use ReflectionClass;
+use function str_starts_with;
 
 /**
  * @psalm-import-type BasicResults from \Laudis\Neo4j\Formatter\BasicFormatter
@@ -298,4 +302,38 @@ public function testRollbackInvalid(string $alias): void
         }
         self::assertTrue($exception);
     }
+
+    /**
+     * @dataProvider connectionAliases
+     * @noinspection PhpUnusedLocalVariableInspection
+     * @psalm-suppress UnusedVariable
+     */
+    public function testCorrectConnectionReuse(string $alias): void
+    {
+        $driver = $this->getClient()->getDriver($alias);
+        if (!$driver instanceof BoltDriver) {
+            self::markTestSkipped('Can only white box test bolt driver');
+        }
+
+        $poolReflection = new ReflectionClass(BoltConnectionPool::class);
+        $poolReflection->setStaticPropertyValue('connectionCache', []);
+
+        $this->getClient()->run('MATCH (x) RETURN x', [], $alias);
+        $this->getClient()->run('MATCH (x) RETURN x', [], $alias);
+        $this->getClient()->run('MATCH (x) RETURN x', [], $alias);
+        $this->getClient()->run('MATCH (x) RETURN x', [], $alias);
+        $a = $this->getClient()->beginTransaction([], $alias);
+        $b = $this->getClient()->beginTransaction([], $alias);
+        $this->getClient()->run('MATCH (x) RETURN x', [], $alias);
+
+        $poolReflection = new ReflectionClass(BoltConnectionPool::class);
+        /** @var array $cache */
+        $cache = $poolReflection->getStaticPropertyValue('connectionCache');
+
+        $key = array_key_first($cache);
+        self::assertIsString($key);
+        self::assertArrayHasKey($key, $cache);
+        /** @psalm-suppress MixedArgument */
+        self::assertCount(3, $cache[$key]);
+    }
 }