fixed psalm in src

Author: transistive

src/Http/HttpDriver.php

@@ -35,33 +35,6 @@
  *
  * @implements DriverInterface<T>
  *
- * @psalm-type DiscoveryResult = array{
- *      bolt_routing:string,
- *      transaction: string,
- *      bolt_direct: string,
- *      neo4j_version: string,
- *      neo4j_edition: string,
- *      db/cluster?: string,
- *      dbms/cluster?: string,
- *      data?: string
- * }
- * @psalm-type DiscoveryResultLegacy = array{
- *     extensions: array,
- *     node: string,
- *     relationship: string,
- *     node_index: string,
- *     relationship_index: string,
- *     extensions_info: string,
- *     relationship_types: string,
- *     batch: string,
- *     cypher: string,
- *     indexed: string,
- *     constraints: string,
- *     transaction: string,
- *     node_labels: string,
- *     neo4j_version: string
- * }
- *
  * @psalm-import-type OGMResults from \Laudis\Neo4j\Formatter\OGMFormatter
  */
 final class HttpDriver implements DriverInterface
@@ -153,15 +126,17 @@ public function createSession(?SessionConfiguration $config = null): SessionInte
                 $response = $client->sendRequest($request);
 
                 $discovery = HttpHelper::interpretResponse($response);
+                /** @var string|null */
                 $version = $discovery->neo4j_version;
 
                 if ($version === null) {
-                    /** @psalm-suppress PossiblyUndefinedArrayOffset */
-                    $request = $request->withUri(Uri::create($discovery->data));
-                    /** @var DiscoveryResultLegacy|DiscoveryResult */
+                    /** @var string */
+                    $uri = $discovery->data;
+                    $request = $request->withUri(Uri::create($uri));
                     $discovery = HttpHelper::interpretResponse($client->sendRequest($request));
                 }
 
+                /** @var string */
                 $tsx = $discovery->transaction;
 
                 return str_replace('{databaseName}', $database, $tsx);

src/Http/HttpHelper.php

@@ -46,11 +46,18 @@ public static function interpretResponse(ResponseInterface $response): stdClass
             throw new Neo4jException([new Neo4jError((string) $response->getStatusCode(), $contents)]);
         }
 
+        /** @var stdClass $body */
         $body = json_decode($contents, false, 512, JSON_THROW_ON_ERROR);
 
         $errors = [];
-        foreach (($body->errors ?? []) as $error) {
-            $errors[] = new Neo4jError($error->code, $error->message);
+        /** @var list<stdClass> $bodyErrors */
+        $bodyErrors = $body->errors ?? [];
+        foreach ($bodyErrors as $error) {
+            /** @var string */
+            $code = $error->code;
+            /** @var string */
+            $message = $error->message;
+            $errors[] = new Neo4jError($code, $message);
         }
 
         if (count($errors) !== 0) {

src/Http/HttpSession.php

@@ -181,9 +181,9 @@ public function beginTransaction(?iterable $statements = null, ?TransactionConfi
         $connection = $this->pool->acquire($request->getUri(), $this->auth, $config->getTimeout(), $this->userAgent, $this->config);
         $response = $connection->getImplementation()->sendRequest($request);
 
-        $data = HttpHelper::interpretResponse($response);
-
-        $path = str_replace('/commit', '', parse_url($data->commit, PHP_URL_PATH));
+        /** @var string */
+        $url = HttpHelper::interpretResponse($response)->commit;
+        $path = str_replace('/commit', '', parse_url($url, PHP_URL_PATH));
         $uri = $request->getUri()->withPath($path);
         $request = $request->withUri($uri);