fixed bug when destructing a result set in READY state

Author: transistive

Dockerfile

@@ -1,4 +1,4 @@
-FROM php:8.1.7-cli
+FROM php:8.1-cli
 RUN apt-get update \
     && apt-get install -y \
         libzip-dev \

src/Bolt/BoltConnection.php

@@ -363,7 +363,9 @@ public function pull(?int $qid, ?int $fetchSize): array
     public function __destruct()
     {
         if ($this->serverState !== 'FAILED' && $this->isOpen()) {
-            $this->consumeResults();
+            if (in_array($this->serverState, ['STREAMING', 'TX_STREAMING'])) {
+                $this->consumeResults();
+            }
 
             $this->protocol()->goodbye();
 

src/Bolt/BoltResult.php

@@ -13,13 +13,14 @@
 
 namespace Laudis\Neo4j\Bolt;
 
+use Laudis\Neo4j\Contracts\FormatterInterface;
 use function array_splice;
 use function count;
 use Generator;
 use Iterator;
 
 /**
- * @psalm-import-type BoltCypherStats from \Laudis\Neo4j\Contracts\FormatterInterface
+ * @psalm-import-type BoltCypherStats from FormatterInterface
  *
  * @implements Iterator<int, list>
  */

src/Bolt/ConnectionPool.php

@@ -109,6 +109,11 @@ public function release(ConnectionInterface $connection): void
         }
     }
 
+    public function __destruct()
+    {
+        echo 'Destructing connection pool';
+    }
+
     /**
      * @return BoltConnection|null
      */
@@ -117,7 +122,7 @@ private function returnAnyAvailableConnection(SessionConfiguration $config): ?Co
         $streamingConnection = null;
         $requiresReconnectConnection = null;
         // Ensure random connection reuse before picking one.
-        shuffle($this->activeConnections);
+//        shuffle($this->activeConnections);
 
         foreach ($this->activeConnections as $activeConnection) {
             // We prefer a connection that is just ready

src/Bolt/Session.php

@@ -194,4 +194,9 @@ public function getLastBookmark(): Bookmark
     {
         return $this->bookmarkHolder->getBookmark();
     }
+
+    public function __destruct()
+    {
+        echo 'destroyed session';
+    }
 }