fix: Psalm and CS Fix

Author: exaby73

src/Authentication/BasicAuth.php

@@ -43,9 +43,6 @@ public function __construct(
         private readonly ?Neo4jLogger $logger,
     ) {}
 
-    /**
-     * @psalm-mutation-free
-     */
     public function authenticateHttp(RequestInterface $request, UriInterface $uri, string $userAgent): RequestInterface
     {
         $this->logger?->log(LogLevel::DEBUG, 'Authenticating using BasicAuth');

src/Authentication/KerberosAuth.php

@@ -42,9 +42,6 @@ public function __construct(
         private readonly ?Neo4jLogger $logger,
     ) {}
 
-    /**
-     * @psalm-mutation-free
-     */
     public function authenticateHttp(RequestInterface $request, UriInterface $uri, string $userAgent): RequestInterface
     {
         $this->logger?->log(LogLevel::DEBUG, 'Authenticating using KerberosAuth');

src/Authentication/NoAuth.php

@@ -41,9 +41,6 @@ public function __construct(
         private readonly ?Neo4jLogger $logger
     ) {}
 
-    /**
-     * @psalm-mutation-free
-     */
     public function authenticateHttp(RequestInterface $request, UriInterface $uri, string $userAgent): RequestInterface
     {
         $this->logger?->log(LogLevel::DEBUG, 'Authentication disabled');
@@ -63,10 +60,10 @@ public function authenticateHttp(RequestInterface $request, UriInterface $uri, s
     public function authenticateBolt(V4_4|V5|V5_1|V5_2|V5_3|V5_4 $protocol, string $userAgent): array
     {
         if (method_exists($protocol, 'logon')) {
-            $this->logger->log(LogLevel::DEBUG, 'HELLO', ['user_agent' => $userAgent]);
+            $this->logger?->log(LogLevel::DEBUG, 'HELLO', ['user_agent' => $userAgent]);
             $protocol->hello(['user_agent' => $userAgent]);
             $response = ResponseHelper::getResponse($protocol);
-            $this->logger->log(LogLevel::DEBUG, 'LOGON', ['scheme' => 'none']);
+            $this->logger?->log(LogLevel::DEBUG, 'LOGON', ['scheme' => 'none']);
             $protocol->logon([
                 'scheme' => 'none',
             ]);
@@ -75,7 +72,7 @@ public function authenticateBolt(V4_4|V5|V5_1|V5_2|V5_3|V5_4 $protocol, string $
             /** @var array{server: string, connection_id: string, hints: list} */
             return $response->content;
         } else {
-            $this->logger->log(LogLevel::DEBUG, 'HELLO', ['user_agent' => $userAgent, 'scheme' => 'none']);
+            $this->logger?->log(LogLevel::DEBUG, 'HELLO', ['user_agent' => $userAgent, 'scheme' => 'none']);
             $protocol->hello([
                 'user_agent' => $userAgent,
                 'scheme' => 'none',

src/Authentication/OpenIDConnectAuth.php

@@ -25,6 +25,7 @@
 use Laudis\Neo4j\Contracts\AuthenticateInterface;
 use Psr\Http\Message\RequestInterface;
 use Psr\Http\Message\UriInterface;
+use Psr\Log\LogLevel;
 
 use function sprintf;
 
@@ -38,9 +39,6 @@ public function __construct(
         private readonly ?Neo4jLogger $logger
     ) {}
 
-    /**
-     * @psalm-mutation-free
-     */
     public function authenticateHttp(RequestInterface $request, UriInterface $uri, string $userAgent): RequestInterface
     {
         $this->logger?->log(LogLevel::DEBUG, 'Authenticating using OpenIDConnectAuth');

src/BoltFactory.php

@@ -42,7 +42,7 @@ public function __construct(
         private readonly BasicConnectionFactoryInterface $connectionFactory,
         private readonly ProtocolFactory $protocolFactory,
         private readonly SslConfigurationFactory $sslConfigurationFactory,
-        private readonly ?Neo4jLogger $logger
+        private readonly ?Neo4jLogger $logger = null
     ) {}
 
     public static function create(?Neo4jLogger $logger): self

src/Common/DriverSetupManager.php

@@ -193,6 +193,9 @@ public function withFormatter(FormatterInterface $formatter): self
         return $tbr;
     }
 
+    /**
+     * @psalm-mutation-free
+     */
     public function getLogger(): ?Neo4jLogger
     {
         return $this->configuration->getLogger();

src/Common/Neo4jLogger.php

@@ -35,9 +35,6 @@ public function __construct(
         private readonly ?LoggerInterface $logger,
     ) {}
 
-    /**
-     * @psalm-mutation-free
-     */
     public function log(string $level, string $message, array $context = []): void
     {
         if ($this->logger === null || !$this->shouldLog($level)) {

src/Contracts/AuthenticateInterface.php

@@ -25,8 +25,6 @@
 interface AuthenticateInterface
 {
     /**
-     * @psalm-mutation-free
-     *
      * Authenticates a RequestInterface with the provided configuration Uri and userAgent.
      */
     public function authenticateHttp(RequestInterface $request, UriInterface $uri, string $userAgent): RequestInterface;

src/Http/HttpDriver.php

@@ -76,18 +76,19 @@ public static function create(string|UriInterface $uri, ?DriverConfiguration $co
             $uri = Uri::create($uri);
         }
 
+        $configuration ??= DriverConfiguration::default();
         if ($formatter !== null) {
             return new self(
                 $uri,
-                $configuration ?? DriverConfiguration::default(),
+                $configuration,
                 $formatter,
                 $authenticate ?? Authenticate::fromUrl($uri, $configuration->getLogger())
             );
         }
 
         return new self(
             $uri,
-            $configuration ?? DriverConfiguration::default(),
+            $configuration,
             OGMFormatter::create(),
             $authenticate ?? Authenticate::fromUrl($uri, $configuration->getLogger())
         );