static analysis

Author: transistive

src/Authentication/BasicAuth.php

@@ -57,8 +57,9 @@ public function authenticateHttp(RequestInterface $request, UriInterface $uri, s
     }
 
     /**
-     * @return array{server: string, connection_id: string, hints: array}
      * @throws Exception
+     *
+     * @return array{server: string, connection_id: string, hints: list}
      */
     public function authenticateBolt(V4_4|V5|V5_1|V5_2|V5_3|V5_4 $protocol, string $userAgent): array
     {
@@ -71,6 +72,8 @@ public function authenticateBolt(V4_4|V5|V5_1|V5_2|V5_3|V5_4 $protocol, string $
                 'credentials' => $this->password,
             ]);
             ResponseHelper::getResponse($protocol);
+
+            /** @var array{server: string, connection_id: string, hints: list} */
             return $response->content;
         } else {
             $protocol->hello([
@@ -79,6 +82,8 @@ public function authenticateBolt(V4_4|V5|V5_1|V5_2|V5_3|V5_4 $protocol, string $
                 'principal' => $this->username,
                 'credentials' => $this->password,
             ]);
+
+            /** @var array{server: string, connection_id: string, hints: list} */
             return ResponseHelper::getResponse($protocol)->content;
         }
     }

src/Authentication/KerberosAuth.php

@@ -19,11 +19,11 @@
 use Bolt\protocol\V5_2;
 use Bolt\protocol\V5_3;
 use Bolt\protocol\V5_4;
+use Exception;
 use Laudis\Neo4j\Common\ResponseHelper;
 use Laudis\Neo4j\Contracts\AuthenticateInterface;
 use Psr\Http\Message\RequestInterface;
 use Psr\Http\Message\UriInterface;
-use Exception;
 
 use function sprintf;
 
@@ -54,8 +54,9 @@ public function authenticateHttp(RequestInterface $request, UriInterface $uri, s
     }
 
     /**
-     * @return array{server: string, connection_id: string, hints: array}
      * @throws Exception
+     *
+     * @return array{server: string, connection_id: string, hints: list}
      */
     public function authenticateBolt(V4_4|V5|V5_1|V5_2|V5_3|V5_4 $protocol, string $userAgent): array
     {
@@ -68,6 +69,8 @@ public function authenticateBolt(V4_4|V5|V5_1|V5_2|V5_3|V5_4 $protocol, string $
                 'credentials' => $this->token,
             ]);
             ResponseHelper::getResponse($protocol);
+
+            /** @var array{server: string, connection_id: string, hints: list} */
             return $response->content;
         } else {
             $protocol->hello([
@@ -76,6 +79,8 @@ public function authenticateBolt(V4_4|V5|V5_1|V5_2|V5_3|V5_4 $protocol, string $
                 'principal' => '',
                 'credentials' => $this->token,
             ]);
+
+            /** @var array{server: string, connection_id: string, hints: list} */
             return ResponseHelper::getResponse($protocol)->content;
         }
     }

src/Authentication/NoAuth.php

@@ -19,11 +19,11 @@
 use Bolt\protocol\V5_2;
 use Bolt\protocol\V5_3;
 use Bolt\protocol\V5_4;
+use Exception;
 use Laudis\Neo4j\Common\ResponseHelper;
 use Laudis\Neo4j\Contracts\AuthenticateInterface;
 use Psr\Http\Message\RequestInterface;
 use Psr\Http\Message\UriInterface;
-use Exception;
 
 use function sprintf;
 
@@ -46,8 +46,9 @@ public function authenticateHttp(RequestInterface $request, UriInterface $uri, s
     }
 
     /**
-     * @return array{server: string, connection_id: string, hints: array}
      * @throws Exception
+     *
+     * @return array{server: string, connection_id: string, hints: list}
      */
     public function authenticateBolt(V4_4|V5|V5_1|V5_2|V5_3|V5_4 $protocol, string $userAgent): array
     {
@@ -58,12 +59,16 @@ public function authenticateBolt(V4_4|V5|V5_1|V5_2|V5_3|V5_4 $protocol, string $
                 'scheme' => 'none',
             ]);
             ResponseHelper::getResponse($protocol);
+
+            /** @var array{server: string, connection_id: string, hints: list} */
             return $response->content;
         } else {
             $protocol->hello([
                 'user_agent' => $userAgent,
                 'scheme' => 'none',
             ]);
+
+            /** @var array{server: string, connection_id: string, hints: list} */
             return ResponseHelper::getResponse($protocol)->content;
         }
     }

src/Authentication/OpenIDConnectAuth.php

@@ -19,11 +19,11 @@
 use Bolt\protocol\V5_2;
 use Bolt\protocol\V5_3;
 use Bolt\protocol\V5_4;
+use Exception;
 use Laudis\Neo4j\Common\ResponseHelper;
 use Laudis\Neo4j\Contracts\AuthenticateInterface;
 use Psr\Http\Message\RequestInterface;
 use Psr\Http\Message\UriInterface;
-use Exception;
 
 use function sprintf;
 
@@ -51,8 +51,9 @@ public function authenticateHttp(RequestInterface $request, UriInterface $uri, s
     }
 
     /**
-     * @return array{server: string, connection_id: string, hints: array}
      * @throws Exception
+     *
+     * @return array{server: string, connection_id: string, hints: list}
      */
     public function authenticateBolt(V4_4|V5|V5_1|V5_2|V5_3|V5_4 $protocol, string $userAgent): array
     {
@@ -64,13 +65,17 @@ public function authenticateBolt(V4_4|V5|V5_1|V5_2|V5_3|V5_4 $protocol, string $
                 'credentials' => $this->token,
             ]);
             ResponseHelper::getResponse($protocol);
+
+            /** @var array{server: string, connection_id: string, hints: list} */
             return $response->content;
         } else {
             $protocol->hello([
                 'user_agent' => $userAgent,
                 'scheme' => 'bearer',
                 'credentials' => $this->token,
             ]);
+
+            /** @var array{server: string, connection_id: string, hints: list} */
             return ResponseHelper::getResponse($protocol)->content;
         }
     }

src/Bolt/BoltConnection.php

@@ -16,7 +16,10 @@
 use Bolt\enum\ServerState;
 use Bolt\enum\Signature;
 use Bolt\protocol\Response;
-use Bolt\protocol\{V4_4, V5, V5_3, V5_4};
+use Bolt\protocol\V4_4;
+use Bolt\protocol\V5;
+use Bolt\protocol\V5_3;
+use Bolt\protocol\V5_4;
 use Laudis\Neo4j\Common\ConnectionConfiguration;
 use Laudis\Neo4j\Contracts\AuthenticateInterface;
 use Laudis\Neo4j\Contracts\ConnectionInterface;

src/Bolt/ProtocolFactory.php

@@ -15,7 +15,10 @@
 
 use Bolt\Bolt;
 use Bolt\connection\IConnection;
-use Bolt\protocol\{V4_4, V5, V5_3, V5_4};
+use Bolt\protocol\V4_4;
+use Bolt\protocol\V5;
+use Bolt\protocol\V5_3;
+use Bolt\protocol\V5_4;
 use Laudis\Neo4j\Contracts\AuthenticateInterface;
 use RuntimeException;