Skip to content

Commit ddbd1ee

Browse files
committed
set OGMFormatter as the default
1 parent 1af0e7d commit ddbd1ee

File tree

7 files changed

+29
-5
lines changed

7 files changed

+29
-5
lines changed

src/ClientBuilder.php

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,6 @@
1414
namespace Laudis\Neo4j;
1515

1616
use Ds\Map;
17-
use Ds\Vector;
1817
use function http_build_query;
1918
use function in_array;
2019
use Laudis\Neo4j\Authentication\Authenticate;
@@ -26,13 +25,15 @@
2625
use Laudis\Neo4j\Databags\DriverConfiguration;
2726
use Laudis\Neo4j\Databags\HttpPsrBindings;
2827
use Laudis\Neo4j\Exception\UnsupportedScheme;
29-
use Laudis\Neo4j\Formatter\BasicFormatter;
28+
use Laudis\Neo4j\Formatter\OGMFormatter;
3029
use Laudis\Neo4j\Http\HttpConfig;
30+
use Laudis\Neo4j\Types\CypherList;
31+
use Laudis\Neo4j\Types\CypherMap;
3132

3233
/**
3334
* @template T
3435
*
35-
* @see Client::create()
36+
* @psalm-import-type OGMTypes from \Laudis\Neo4j\Formatter\OGMFormatter
3637
*/
3738
final class ClientBuilder
3839
{
@@ -57,11 +58,11 @@ public function __construct(DriverConfiguration $configuration, FormatterInterfa
5758
}
5859

5960
/**
60-
* @return ClientBuilder<Vector<Map<string, scalar|array|null>>>
61+
* @return ClientBuilder<CypherList<CypherMap<OGMTypes>>>
6162
*/
6263
public static function create(): ClientBuilder
6364
{
64-
return new self(DriverConfiguration::default(), new BasicFormatter(), new Map(), null);
65+
return new self(DriverConfiguration::default(), OGMFormatter::create(), new Map(), null);
6566
}
6667

6768
/**

src/Formatter/OGMFormatter.php

Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,8 @@
2222
use Exception;
2323
use Laudis\Neo4j\Contracts\FormatterInterface;
2424
use Laudis\Neo4j\Formatter\Specialised\BoltOGMTranslator;
25+
use Laudis\Neo4j\Formatter\Specialised\HttpOGMArrayTranslator;
26+
use Laudis\Neo4j\Formatter\Specialised\HttpOGMStringTranslator;
2527
use Laudis\Neo4j\Formatter\Specialised\HttpOGMTranslator;
2628
use Laudis\Neo4j\Types\CypherList;
2729
use Laudis\Neo4j\Types\CypherMap;
@@ -52,6 +54,17 @@ public function __construct(BoltOGMTranslator $boltTranslator, HttpOGMTranslator
5254
$this->httpTranslator = $httpTranslator;
5355
}
5456

57+
public static function create(): OGMFormatter
58+
{
59+
return new self(
60+
new BoltOGMTranslator(),
61+
new HttpOGMTranslator(
62+
new HttpOGMArrayTranslator(),
63+
new HttpOGMStringTranslator()
64+
)
65+
);
66+
}
67+
5568
/**
5669
* @param BoltMeta $meta
5770
*

tests/Integration/ClientIntegrationTest.php

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,7 @@
2222
use Laudis\Neo4j\Contracts\TransactionInterface;
2323
use Laudis\Neo4j\Databags\Statement;
2424
use Laudis\Neo4j\Exception\Neo4jException;
25+
use Laudis\Neo4j\Formatter\BasicFormatter;
2526
use PHPUnit\Framework\TestCase;
2627

2728
final class ClientIntegrationTest extends TestCase
@@ -52,6 +53,7 @@ public function createClient(): ClientInterface
5253
->addBoltConnection('bolt', 'bolt://neo4j:test@neo4j')
5354
->addHttpConnection('http', 'http://neo4j:test@neo4j')
5455
->addBoltConnection('cluster', 'bolt://neo4j:test@core1', BoltConfiguration::create()->withAutoRouting(true))
56+
->withFormatter(new BasicFormatter())
5557
->build();
5658
}
5759

tests/Integration/ClusterIntegrationTest.php

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,7 @@
1818
use Laudis\Neo4j\Bolt\BoltConfiguration;
1919
use Laudis\Neo4j\ClientBuilder;
2020
use Laudis\Neo4j\Contracts\ClientInterface;
21+
use Laudis\Neo4j\Formatter\BasicFormatter;
2122
use PHPUnit\Framework\TestCase;
2223

2324
final class ClusterIntegrationTest extends TestCase
@@ -31,6 +32,7 @@ protected function setUp(): void
3132
$boltInjections = BoltConfiguration::create()->withAutoRouting(true);
3233
$this->client = ClientBuilder::create()
3334
->addBoltConnection('cluster', 'bolt://neo4j:test@core1', $boltInjections)
35+
->withFormatter(new BasicFormatter())
3436
->build();
3537
}
3638

tests/Integration/ComplexQueryTests.php

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,7 @@
1919
use InvalidArgumentException;
2020
use Laudis\Neo4j\ClientBuilder;
2121
use Laudis\Neo4j\Contracts\ClientInterface;
22+
use Laudis\Neo4j\Formatter\BasicFormatter;
2223
use Laudis\Neo4j\ParameterHelper;
2324
use PHPUnit\Framework\TestCase;
2425

@@ -34,6 +35,7 @@ protected function setUp(): void
3435
->withDriver('bolt', 'bolt://neo4j:test@neo4j')
3536
->withDriver('http', 'http://neo4j:test@neo4j')
3637
->withDriver('cluster', 'neo4j://neo4j:test@core1')
38+
->withFormatter(new BasicFormatter())
3739
->build();
3840
}
3941

tests/Integration/ConsistencyTest.php

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,7 @@
1818
use Laudis\Neo4j\ClientBuilder;
1919
use Laudis\Neo4j\Contracts\ClientInterface;
2020
use Laudis\Neo4j\Databags\Statement;
21+
use Laudis\Neo4j\Formatter\BasicFormatter;
2122
use PHPUnit\Framework\TestCase;
2223

2324
final class ConsistencyTest extends TestCase
@@ -32,6 +33,7 @@ protected function setUp(): void
3233
->withDriver('http', 'http://neo4j:test@neo4j')
3334
->withDriver('bolt', 'bolt://neo4j:test@neo4j')
3435
->withDriver('cluster', 'neo4j://neo4j:test@core1')
36+
->withFormatter(new BasicFormatter())
3537
->build();
3638
}
3739

tests/Integration/TransactionIntegrationTest.php

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,7 @@
1919
use Laudis\Neo4j\Contracts\ClientInterface;
2020
use Laudis\Neo4j\Databags\Statement;
2121
use Laudis\Neo4j\Exception\Neo4jException;
22+
use Laudis\Neo4j\Formatter\BasicFormatter;
2223
use PHPUnit\Framework\TestCase;
2324

2425
final class TransactionIntegrationTest extends TestCase
@@ -34,6 +35,7 @@ public function setUp(): void
3435
->withDriver('bolt', 'bolt://neo4j:test@neo4j')
3536
->withDriver('cluster', 'neo4j://neo4j:test@core1')
3637
->withDriver('http', 'http://neo4j:test@neo4j')
38+
->withFormatter(new BasicFormatter())
3739
->build();
3840
}
3941

0 commit comments

Comments
 (0)