introduce legacy parameter in datetime

Author: transistive

src/Formatter/Specialised/BoltOGMTranslator.php

@@ -142,7 +142,12 @@ private function makeFromBoltDuration(BoltDuration $duration): Duration
 
     private function makeFromBoltDateTime(BoltDateTime $datetime): DateTime
     {
-        return new DateTime($datetime->seconds(), $datetime->nanoseconds(), $datetime->tz_offset_seconds());
+        return new DateTime(
+            $datetime->seconds(),
+            $datetime->nanoseconds(),
+            $datetime->tz_offset_seconds(),
+            !$datetime instanceof \Bolt\protocol\v5\structures\DateTime
+        );
     }
 
     private function makeFromBoltTime(BoltTime $time): Time

src/Formatter/Specialised/JoltHttpOGMTranslator.php

@@ -371,7 +371,7 @@ private function translateDateTime(string $datetime): Date|LocalDateTime|LocalTi
 
             $offset = $this->offsetFromMatches($matches);
 
-            return new DateTime($seconds, $nanoseconds, $offset);
+            return new DateTime($seconds, $nanoseconds, $offset, true);
         }
 
         if (str_starts_with($datetime, 'P')) {

src/Formatter/Specialised/LegacyHttpOGMTranslator.php

@@ -480,10 +480,10 @@ private function translateDateTime(string $value): DateTime
         }
 
         if ($tz !== null) {
-            return new DateTime($dateTime->getTimestamp(), (int) $milliseconds * 1_000_000, $tz);
+            return new DateTime($dateTime->getTimestamp(), (int) $milliseconds * 1_000_000, $tz, true);
         }
 
-        return new DateTime($dateTime->getTimestamp(), (int) $milliseconds * 1_000_000, 0);
+        return new DateTime($dateTime->getTimestamp(), (int) $milliseconds * 1_000_000, 0, true);
     }
 
     private function translateLocalDateTime(string $value): LocalDateTime

src/Types/DateTime.php

@@ -34,7 +34,8 @@ final class DateTime extends AbstractPropertyObject implements BoltConvertibleIn
     public function __construct(
         private int $seconds,
         private int $nanoseconds,
-        private int $tzOffsetSeconds
+        private int $tzOffsetSeconds,
+        private bool $legacy
     ) {}
 
     /**
@@ -72,9 +73,13 @@ public function toDateTime(): DateTimeImmutable
         foreach (DateTimeZone::listAbbreviations() as $tz) {
             /** @psalm-suppress all */
             if ($tz[0]['offset'] === $this->getTimeZoneOffsetSeconds()) {
-                return (new DateTimeImmutable(sprintf('@%s', $this->getSeconds())))
-                    ->modify(sprintf('+%s microseconds', $this->nanoseconds / 1000))
-                    ->setTimezone(new DateTimeZone($tz[0]['timezone_id']));
+                $dateTime = new DateTimeImmutable(sprintf('@%s', $this->getSeconds()));
+
+                if ($this->legacy) {
+                    $dateTime = $dateTime->modify(sprintf('+%s microseconds', $this->nanoseconds / 1000));
+                }
+
+                return $dateTime->setTimezone(new DateTimeZone($tz[0]['timezone_id']));
             }
         }