psalm formatter

Author: transistive

src/Contracts/FormatterInterface.php

@@ -58,7 +58,8 @@
  *     constraints-removed?: int,
  *     contains-updates?: bool,
  *     contains-system-updates?: bool,
- *     system-updates?: int
+ *     system-updates?: int,
+ *     db?: string
  * }
  * @psalm-type CypherError = array{code: string, message: string}
  * @psalm-type CypherRowResponse = array{row: list<scalar|null|array<array-key,scalar|null|array>>}

src/Formatter/BasicFormatter.php

@@ -58,7 +58,7 @@ public static function create(): self
     }
 
     /**
-     * @param array{fields: array<int, string>} $meta
+     * @param array{fields: array<int, string>, qid?: int, t_first: int} $meta
      *
      * @return CypherList<CypherMap<array|scalar|null>>
      */
@@ -127,7 +127,7 @@ private function buildResult(stdClass $result): CypherList
     }
 
     /**
-     * @param array{fields: array<int, string>} $meta
+     * @param array{fields: array<int, string>, qid?: int, t_first: int} $meta
      *
      * @return CypherMap<scalar|array|null>
      */

src/Formatter/Specialised/BoltOGMTranslator.php

@@ -54,6 +54,7 @@
  * @psalm-import-type OGMTypes from OGMFormatter
  *
  * @psalm-immutable
+ * @psalm-pure
  */
 final class BoltOGMTranslator
 {
@@ -64,6 +65,7 @@ final class BoltOGMTranslator
 
     public function __construct()
     {
+        /** @psalm-suppress InvalidPropertyAssignmentValue */
         $this->rawToTypes = [
             BoltNode::class => $this->makeFromBoltNode(...),
             BoltDate::class => $this->makeFromBoltDate(...),

src/Formatter/Specialised/JoltHttpOGMTranslator.php

@@ -64,6 +64,8 @@
  * @psalm-immutable
  *
  * @psalm-import-type OGMTypes from OGMFormatter
+ *
+ * @psalm-suppress PossiblyUndefinedArrayOffset
  */
 final class JoltHttpOGMTranslator
 {

src/Formatter/Specialised/LegacyHttpOGMTranslator.php

@@ -154,15 +154,18 @@ public function translateCypherMap(array $row, HttpMetaInfo $meta): array
     }
 
     /**
-     * @param stdClass|array|scalar|null $value
+     * @param array|scalar|stdClass|null $value
      *
      * @return array{0: OGMTypes, 1: HttpMetaInfo}
      *
      * @psalm-suppress MixedArgumentTypeCoercion
      * @psalm-suppress MixedArgument
      * @psalm-suppress MixedAssignment
+     * @psalm-suppress InvalidReturnStatement
+     * @psalm-suppress ArgumentTypeCoercion
+     * @psalm-suppress InvalidReturnType
      */
-    private function translateValue($value, HttpMetaInfo $meta): array
+    private function translateValue(float|array|bool|int|string|stdClass|null $value, HttpMetaInfo $meta): array
     {
         if (is_object($value)) {
             return $this->translateObject($value, $meta);
@@ -416,6 +419,7 @@ private function translateDuration(string $value): Duration
     {
         /** @psalm-suppress ImpureFunctionCall false positive in version php 7.4 */
         if (str_contains($value, '.')) {
+            /** @psalm-suppress PossiblyUndefinedIntArrayOffset */
             [$format, $secondsFraction] = explode('.', $value);
             $nanoseconds = (int) substr($secondsFraction, 6);
             $microseconds = (int) str_pad((string) ((int) substr($secondsFraction, 0, 6)), 6, '0');
@@ -464,14 +468,19 @@ private function translateTime(string $value): Time
      */
     private function translateDateTime(string $value): DateTime
     {
+        /** @psalm-suppress PossiblyUndefinedIntArrayOffset */
         [$date, $time] = explode('T', $value);
         $tz = null;
-        /** @psalm-suppress ImpureFunctionCall false positive in version php 7.4 */
         if (str_contains($time, '+')) {
+            /** @psalm-suppress PossiblyUndefinedIntArrayOffset */
             [$time, $timezone] = explode('+', $time);
+
+            /** @psalm-suppress PossiblyUndefinedIntArrayOffset */
             [$tzHours, $tzMinutes] = explode(':', $timezone);
             $tz = (int) $tzHours * 60 * 60 + (int) $tzMinutes * 60;
         }
+
+        /** @psalm-suppress PossiblyUndefinedIntArrayOffset */
         [$time, $milliseconds] = explode('.', $time);
 
         $dateTime = DateTimeImmutable::createFromFormat('Y-m-d H:i:s', $date.' '.$time);
@@ -488,7 +497,9 @@ private function translateDateTime(string $value): DateTime
 
     private function translateLocalDateTime(string $value): LocalDateTime
     {
+        /** @psalm-suppress PossiblyUndefinedIntArrayOffset */
         [$date, $time] = explode('T', $value);
+        /** @psalm-suppress PossiblyUndefinedIntArrayOffset */
         [$time, $milliseconds] = explode('.', $time);
 
         $dateTime = DateTimeImmutable::createFromFormat('Y-m-d H:i:s', $date.' '.$time);

src/Formatter/SummarizedResultFormatter.php

@@ -129,7 +129,7 @@ public function formatHttpStats(stdClass $response, HttpConnection $connection,
     }
 
     /**
-     * @param array{stats?: BoltCypherStats} $response
+     * @param array{stats?: BoltCypherStats}&array $response
      *
      * @psalm-mutation-free
      */
@@ -173,7 +173,6 @@ public function formatBoltResult(array $meta, BoltResult $result, BoltConnection
             /** @var BoltCypherStats $response */
             $stats = $this->formatBoltStats($response);
             $resultConsumedAfter = microtime(true) - $runStart;
-            /** @var string */
             $db = $response['db'] ?? '';
             $summary = new ResultSummary(
                 $stats,