reworked driver parity test to use envirementawareintegrationtest

Author: transistive

tests/Integration/DriverParityTest.php

@@ -13,7 +13,6 @@
 
 namespace Laudis\Neo4j\Tests\Integration;
 
-use Laudis\Neo4j\Contracts\ClientInterface;
 use Laudis\Neo4j\Contracts\FormatterInterface;
 use Laudis\Neo4j\Formatter\SummarizedResultFormatter;
 use Laudis\Neo4j\Tests\Fixtures\MoviesFixture;
@@ -22,46 +21,36 @@
 /**
  * @psalm-suppress all
  */
-final class DriverParityTest extends SelectableDriverIntegrationTestCase
+final class DriverParityTest extends EnvironmentAwareIntegrationTest
 {
-    private const TESTABLE_SCHEMES = ['bolt', 'http'];
-
-    protected function setUp(): void
+    public static function setUpBeforeClass(): void
     {
-        parent::setUp();
-        $client = $this->getClient();
-
-        $client->run('MATCH (n) DETACH DELETE n');
-        $client->run(MoviesFixture::CQL);
+        parent::setUpBeforeClass();
+        foreach (self::connectionAliases() as $alias) {
+            $session = self::$client->getDriver($alias[0])->createSession();
+            $session->run('MATCH (x) DETACH DELETE x', []);
+            $session->run(MoviesFixture::CQL, []);
+        }
     }
 
     protected static function formatter(): FormatterInterface
     {
         return SummarizedResultFormatter::create();
     }
 
-    public function testCanHandleMapLiterals(): void
+    /**
+     * @dataProvider connectionAliases
+     */
+    public function testCanHandleMapLiterals(string $alias): void
     {
-        $this->runParityTest(function (ClientInterface $client) {
-            $results = $client->run('MATCH (n:Person)-[r:ACTED_IN]->(m) RETURN n, {movie: m, roles: r.roles} AS actInfo LIMIT 5');
+        $results = $this->getClient()->run('MATCH (n:Person)-[r:ACTED_IN]->(m) RETURN n, {movie: m, roles: r.roles} AS actInfo LIMIT 5', [], $alias);
 
-            foreach ($results as $result) {
-                $actorInfo = $result->get('actInfo');
+        foreach ($results as $result) {
+            $actorInfo = $result->get('actInfo');
 
-                $this->assertInstanceOf(CypherMap::class, $actorInfo);
-                $this->assertTrue($actorInfo->hasKey('roles'));
-                $this->assertTrue($actorInfo->hasKey('movie'));
-            }
-        });
-    }
-
-    private function runParityTest(callable $test): void
-    {
-        foreach (self::TESTABLE_SCHEMES as $scheme) {
-            $client = $this->getClientForScheme($scheme);
-            echo 'Testing '.$scheme.' for '.$this->getName().PHP_EOL;
-            $test($client);
-            echo $scheme.' passed'.PHP_EOL;
+            $this->assertInstanceOf(CypherMap::class, $actorInfo);
+            $this->assertTrue($actorInfo->hasKey('roles'));
+            $this->assertTrue($actorInfo->hasKey('movie'));
         }
     }
 }

tests/Integration/EnvironmentAwareIntegrationTest.php

@@ -66,10 +66,10 @@ protected static function createClient(): ClientInterface
     /**
      * @return non-empty-array<array-key, array{0: string}>
      */
-    public function connectionAliases(): iterable
+    public static function connectionAliases(): iterable
     {
         Dotenv::createImmutable(__DIR__.'/../../')->safeLoad();
-        $connections = $this->getConnections();
+        $connections = static::getConnections();
 
         $tbr = [];
         foreach ($connections as $i => $connection) {
@@ -97,7 +97,7 @@ protected static function buildConnections(): array
     /**
      * @return list<string>
      */
-    protected function getConnections(): array
+    protected static function getConnections(): array
     {
         return self::buildConnections();
     }