enum is applied for accessmodes

Author: 123kiran17

src/Enums/AccessMode.php

@@ -0,0 +1,9 @@
+<?php
+
+namespace src\Enums;
+
+enum AccessMode: string
+{
+    case READ = 'READ';
+    case WRITE = 'WRITE';
+}

src/Neo4jQueryAPI.php

@@ -18,6 +18,7 @@
 use RuntimeException;
 use stdClass;
 use Neo4j\QueryAPI\Objects\Bookmarks;
+use src\Enums\AccessMode;
 
 class Neo4jQueryAPI
 {
@@ -53,19 +54,18 @@ public static function login(string $address, string $username, string $password
      * @throws RequestExceptionInterface
      * @api
      */
-    public function run(string $cypher, array $parameters = [], string $database = 'neo4j', Bookmarks $bookmark = null, ?string $impersonatedUser = null, string $accessMode = 'WRITE' ): ResultSet
+    public function run(string $cypher, array $parameters = [], string $database = 'neo4j', Bookmarks $bookmark = null, ?string $impersonatedUser = null, AccessMode $accessMode = AccessMode::WRITE ): ResultSet
     {
         $validAccessModes = ['READ', 'WRITE', 'ROUTE'];
-        if (!in_array(strtoupper($accessMode), $validAccessModes, true)) {
-            throw new InvalidArgumentException("Invalid access mode: $accessMode. Allowed values are 'READ', 'WRITE', or 'ROUTE'.");
-        }
+
         try {
             $payload = [
                 'statement' => $cypher,
                 'parameters' => empty($parameters) ? new stdClass() : $parameters,
                 'includeCounters' => true,
-                'routing' => strtoupper($accessMode)
+                'accessMode' => $accessMode->value,
             ];
+
             error_log("Request Payload: " . json_encode($payload));
 
             if ($bookmark !== null) {
@@ -74,8 +74,12 @@ public function run(string $cypher, array $parameters = [], string $database = '
             if ($impersonatedUser !== null) {
                 $payload['impersonatedUser'] = $impersonatedUser;
             }
-
-//
+            if ($accessMode) {
+                $payload['accessMode'] = $accessMode->value;
+            }
+            if (!in_array($accessMode, AccessMode::cases(), true)) {
+                throw new RuntimeException("Invalid AccessMode: " . print_r($accessMode, true));
+            }
 
 
             $response = $this->client->post('/db/' . $database . '/query/v2', [
@@ -126,7 +130,8 @@ public function run(string $cypher, array $parameters = [], string $database = '
                 $rows,
                 $resultCounters,
                 new Bookmarks($data['bookmarks'] ?? []),
-                $profile
+                $profile,
+                $accessMode
             );
         } catch (RequestExceptionInterface $e) {
             error_log("Request Exception: " . $e->getMessage());

src/Results/ResultSet.php

@@ -9,6 +9,7 @@
 use Neo4j\QueryAPI\Objects\ResultCounters;
 use Neo4j\QueryAPI\Objects\Bookmarks;
 use Traversable;
+use src\Enums\AccessMode;
 
 /**
  * @api
@@ -25,7 +26,8 @@ public function __construct(
         private readonly array     $rows,
         private ResultCounters     $counters,
         private Bookmarks          $bookmarks,
-        private ?ProfiledQueryPlan $profiledQueryPlan = null
+        private ?ProfiledQueryPlan $profiledQueryPlan = null,
+        private ?AccessMode $accessMode= null
     )
     {
 
@@ -77,10 +79,9 @@ public function getBookmarks(): ?Bookmarks
      * @api
      */
 
-    public function testAccessMode()
+    public function getAccessMode(): ?AccessMode
     {
-        $resultSet = new ResultSet([], null, 'WRITE');
-        $this->assertEquals('WRITE', $resultSet->getAccessMode());
+        return $this->accessMode;
     }
 
 

tests/Integration/Neo4jQueryAPIIntegrationTest.php

@@ -14,6 +14,7 @@
 use PHPUnit\Framework\TestCase;
 use Neo4j\QueryAPI\Transaction;
 use Psr\Http\Message\ResponseInterface;
+use src\Enums\AccessMode;
 
 class Neo4jQueryAPIIntegrationTest extends TestCase
 {
@@ -230,12 +231,16 @@ public function testImpersonatedUserFailure(): void
 
 //
 
-    public function testRunWithDefaultAccessMode(): void
+    public function testRunWithWriteAccessMode(): void
     {
-        $result = $this->api->run("MATCH (n) RETURN COUNT(n)");
+        $result = $this->api->run(
+            "CREATE (n:Person {name: 'Alice'}) RETURN n",
+            [],
+            null,
+            AccessMode::WRITE // why its considered as bookmark
+        );
 
-        $this->assertInstanceOf(ResultSet::class, $result);
-        // Default mode is WRITE;
+        $this->assertNotEmpty($result->getData());
     }
 
     public function testRunWithAccessMode(): void