winp

Author: Pratiksha

src/Configuration.php

@@ -2,17 +2,34 @@
 
 namespace Neo4j\QueryAPI;
 
+use InvalidArgumentException;
 use Neo4j\QueryAPI\Objects\Bookmarks;
 use Neo4j\QueryAPI\Enums\AccessMode;
 
 class Configuration
 {
+    /**
+     * Constructor for Configuration class.
+     *
+     * @param string $baseUri     The base URI for the Neo4j instance.
+     * @param string $database    The name of the database to connect to.
+     * @param bool   $includeCounters Whether to include counters in the response.
+     * @param Bookmarks $bookmarks Bookmarks for tracking queries.
+     * @param AccessMode $accessMode The access mode for the connection (read/write).
+     *
+     * @throws InvalidArgumentException if $baseUri is empty.
+     */
     public function __construct(
         public readonly string     $baseUri,
         public readonly string     $database = 'neo4j',
         public readonly bool       $includeCounters = true,
         public readonly Bookmarks  $bookmarks = new Bookmarks([]),
         public readonly AccessMode $accessMode = AccessMode::WRITE,
     ) {
+        // Validate that baseUri is not empty
+        if (empty($this->baseUri)) {
+            throw new InvalidArgumentException("Address (baseUri) must be provided.");
+        }
     }
 }
+

src/Neo4jQueryAPI.php

@@ -34,6 +34,12 @@ public static function login(string $address, ?AuthenticateInterface $auth = nul
         $client = new Client();
         $config = $config ?? new Configuration(baseUri: $address);
 
+
+       /* if the user now passes a config object without an address it will break.
+
+$config = new Configuration(database: 'mydb');
+
+QueryApi::login('http://myaddress', Authentication::fromEnvironment(), $config);*/
         return new self(
             client: $client,
             responseParser: new ResponseParser(new OGM()),
@@ -44,6 +50,7 @@ public static function login(string $address, ?AuthenticateInterface $auth = nul
                 auth: $auth ?? Authentication::fromEnvironment()
             ),
             config: $config
+
         );
     }
 

tests/Integration/Neo4jQueryAPITest.php

@@ -0,0 +1,44 @@
+<?php
+namespace Neo4j\QueryAPI\Tests\Integration;
+
+use InvalidArgumentException;
+use PHPUnit\Framework\TestCase;
+use Neo4j\QueryAPI\Neo4jQueryAPI;
+use Neo4j\QueryAPI\Objects\Authentication;
+use Neo4j\QueryAPI\Configuration;
+
+class Neo4jQueryAPITest extends TestCase
+{
+    public function testLoginWithConfigurationWithoutAddress()
+    {
+        $this->expectException(InvalidArgumentException::class);
+        $this->expectExceptionMessage("Address (baseUri) must be provided.");
+        $config = new Configuration(baseUri: "");
+
+        Neo4jQueryAPI::login('http://myaddress', Authentication::fromEnvironment(), $config);
+    }
+
+    public function testLoginWithValidConfiguration()
+    {
+        $config = new Configuration(baseUri: 'http://valid.address');
+
+        $api = Neo4jQueryAPI::login('http://myaddress', Authentication::fromEnvironment(), $config);
+
+        $this->assertInstanceOf(Neo4jQueryAPI::class, $api);
+        $this->assertEquals('http://valid.address', $config->baseUri);
+    }
+    public function testLoginWithEmptyAddress()
+    {
+        $this->expectException(InvalidArgumentException::class);
+        $this->expectExceptionMessage("Address (baseUri) must be provided.");
+
+        $config = new Configuration(baseUri: "");
+
+        Neo4jQueryAPI::login('http://myaddress', Authentication::fromEnvironment(), $config);
+    }
+    /**
+     * Test to ensure that an exception is thrown when baseUri is empty.
+     */
+
+
+}