fixed static analysis

Author: transistive

.github/workflows/static.yml

@@ -17,14 +17,6 @@ jobs:
       - name: Download dependencies
         run: composer update --no-interaction --prefer-dist --optimize-autoloader --prefer-stable
 
-      - name: PHPStan
-        uses: docker://oskarstark/phpstan-ga
-        env:
-          REQUIRE_DEV: false
-          CHECK_PLATFORM_REQUIREMENTS: false
-        with:
-          args: analyze --no-progress
-
   php-cs-fixer:
     name: PHP-CS-Fixer
     runs-on: ubuntu-latest

Collector/QueryLogger.php

@@ -73,7 +73,7 @@ public function finish(SummarizedResult $result): void
         $summary = $result->getSummary();
         $this->statements[$id] = array_merge($this->statements[$id], [
             'end_time' => $summary->getResultConsumedAfter(),
-            'nb_results' => $result->getResult()->count(),
+            'nb_results' => $result->count(),
             'statistics' => iterator_to_array($summary->getCounters()->getIterator(), true),
             'scheme' => $summary->getServerInfo()->getAddress()->getScheme(),
             'success' => true,

DependencyInjection/Configuration.php

@@ -30,17 +30,19 @@ public function __construct(bool $debug)
     }
 
     /**
+     * @psalm-suppress All
      * {@inheritdoc}
      */
     public function getConfigTreeBuilder(): TreeBuilder
     {
         $treeBuilder = new TreeBuilder('neo4j');
 
         /*
-         * @psalm-suppress all
          * @phpstan-ignore-next-line
+         * @psalm-suppress All
          */
-        $treeBuilder->getRootNode()->children()
+        $treeBuilder->getRootNode()
+            ->children()
             ->arrayNode('profiling')
                 ->addDefaultsIfNotSet()
                 ->treatFalseLike(['enabled' => false])

SymfonyClient.php

@@ -80,8 +80,7 @@ public function writeTransaction(callable $tsxHandler, ?string $alias = null, ?T
 
         return TransactionHelper::retry(
             fn () => new SymfonyTransaction($session->beginTransaction([], $config), $this->handler),
-            $tsxHandler,
-            $config ?? TransactionConfiguration::default()
+            $tsxHandler
         );
     }
 
@@ -92,8 +91,7 @@ public function readTransaction(callable $tsxHandler, ?string $alias = null, ?Tr
 
         return TransactionHelper::retry(
             fn () => new SymfonyTransaction($session->beginTransaction([], $config), $this->handler),
-            $tsxHandler,
-            $config ?? TransactionConfiguration::default()
+            $tsxHandler
         );
     }
 

SymfonyTransaction.php

@@ -58,4 +58,19 @@ public function rollback(): void
     {
         $this->tsx->rollback();
     }
+
+    public function isRolledBack(): bool
+    {
+        return $this->tsx->isRolledBack();
+    }
+
+    public function isCommitted(): bool
+    {
+        return $this->tsx->isCommitted();
+    }
+
+    public function isFinished(): bool
+    {
+        return $this->tsx->isFinished();
+    }
 }