fixed php cs fixer static analysis

Author: transistive

.github/workflows/static.yml

@@ -33,7 +33,7 @@ jobs:
       - name: PHP-CS-Fixer
         uses: docker://oskarstark/php-cs-fixer-ga
         with:
-          args: --dry-run --diff-format udiff
+          args: --dry-run
 
   psalm:
     name: Psalm

.gitignore

@@ -8,3 +8,4 @@
 .phpunit.result.cache
 .idea
 .env
+.php-cs-fixer.cache

.php_cs renamed to .php-cs-fixer.php

@@ -1,11 +1,16 @@
 <?php
 
-$finder = PhpCsFixer\Finder::create()
+use PhpCsFixer\Config;
+use PhpCsFixer\Finder;
+
+require __DIR__ . '/vendor/autoload.php';
+
+$finder = Finder::create()
     ->in(__DIR__.'/')
     ->exclude(__DIR__.'/vendor')
 ;
 
-return PhpCsFixer\Config::create()
+return (new Config())
     ->setRules([
         '@Symfony' => true,
     ])

Collector/Neo4jDataCollector.php

@@ -40,18 +40,13 @@ public function reset(): void
         $this->queryLogger->reset();
     }
 
-    /**
-     * @return int
-     */
     public function getQueryCount(): int
     {
         return $this->data['nb_queries'];
     }
 
     /**
      * Return all statements, successful and not successful.
-     *
-     * @return array
      */
     public function getStatements(): array
     {
@@ -60,33 +55,22 @@ public function getStatements(): array
 
     /**
      * Return not successful statements.
-     *
-     * @return array
      */
     public function getFailedStatements(): array
     {
         return $this->data['failed_statements'];
     }
 
-    /**
-     * @return float
-     */
     public function getTime(): float
     {
         return $this->data['time'];
     }
 
-    /**
-     * @return float
-     */
     public function getTimeForQuery(): float
     {
         return $this->data['time'];
     }
 
-    /**
-     * @return string
-     */
     public function getName(): string
     {
         return 'neo4j';

Collector/QueryLogger.php

@@ -6,12 +6,12 @@
 
 use Countable;
 use Exception;
+use function iterator_to_array;
 use Laudis\Neo4j\Databags\Statement;
 use Laudis\Neo4j\Databags\SummarizedResult;
 use Laudis\Neo4j\Exception\Neo4jException;
 use Laudis\Neo4j\Types\CypherList;
 use Laudis\Neo4j\Types\CypherMap;
-use function iterator_to_array;
 
 /**
  * @author Xavier Coureau <[email protected]>
@@ -63,6 +63,7 @@ public function record(Statement $statement): void
 
     /**
      * @param SummarizedResult<CypherList<CypherMap<OGMTypes>>> $result
+     *
      * @throws Exception
      */
     public function finish(SummarizedResult $result): void

DependencyInjection/Configuration.php

@@ -36,7 +36,7 @@ public function getConfigTreeBuilder(): TreeBuilder
     {
         $treeBuilder = new TreeBuilder('neo4j');
 
-        /** @phpstan-ignore-next-line */
+        /* @phpstan-ignore-next-line */
         $treeBuilder->getRootNode()->children()
             ->arrayNode('profiling')
                 ->addDefaultsIfNotSet()

DependencyInjection/Neo4jExtension.php

@@ -5,13 +5,13 @@
 namespace Neo4j\Neo4jBundle\DependencyInjection;
 
 use Laudis\Neo4j\Contracts\ClientInterface;
+use function sprintf;
 use Symfony\Component\Config\Definition\Exception\InvalidConfigurationException;
 use Symfony\Component\Config\FileLocator;
 use Symfony\Component\DependencyInjection\ChildDefinition;
 use Symfony\Component\DependencyInjection\ContainerBuilder;
 use Symfony\Component\DependencyInjection\Loader\XmlFileLoader;
 use Symfony\Component\HttpKernel\DependencyInjection\Extension;
-use function sprintf;
 
 /**
  * @author Tobias Nyholm <[email protected]>
@@ -62,7 +62,7 @@ private function handleClients(array &$config, ContainerBuilder $container): voi
     {
         $firstName = '';
         foreach ($config['connections'] as $name => $data) {
-            if ($firstName === '' || 'default' === $name) {
+            if ('' === $firstName || 'default' === $name) {
                 $firstName = $name;
             }
         }

EventHandler.php

@@ -20,7 +20,7 @@ public function __construct(?EventDispatcherInterface $dispatcher)
 
     public function handle(callable $runHandler, iterable $statements): ?CypherList
     {
-        if ($this->dispatcher === null) {
+        if (null === $this->dispatcher) {
             return $runHandler();
         }
 

Events/FailureEvent.php

@@ -2,7 +2,6 @@
 
 namespace Neo4j\Neo4jBundle\Events;
 
-use GraphAware\Neo4j\Client\Exception\Neo4jExceptionInterface;
 use Laudis\Neo4j\Exception\Neo4jException;
 use Symfony\Contracts\EventDispatcher\Event;
 

Factory/ClientFactory.php

@@ -5,11 +5,11 @@
 namespace Neo4j\Neo4jBundle\Factory;
 
 use Laudis\Neo4j\ClientBuilder;
+use Laudis\Neo4j\Contracts\ClientInterface;
 use Neo4j\Neo4jBundle\EventHandler;
 use Neo4j\Neo4jBundle\SymfonyClient;
-use Laudis\Neo4j\Contracts\ClientInterface;
-use Symfony\Contracts\EventDispatcher\EventDispatcherInterface;
 use function sprintf;
+use Symfony\Contracts\EventDispatcher\EventDispatcherInterface;
 
 /**
  * @author Tobias Nyholm <[email protected]>