setup typing correctly

Author: transistive

composer.json

@@ -37,7 +37,8 @@
         "symfony/yaml": "^6.2",
         "vimeo/psalm": "^5.12",
         "kubawerlos/php-cs-fixer-custom-fixers": "^3.0",
-        "friendsofphp/php-cs-fixer": "^3.0"
+        "friendsofphp/php-cs-fixer": "^3.0",
+        "psalm/plugin-phpunit": "^0.18"
     },
     "autoload": {
         "psr-4": {

psalm.xml

@@ -4,7 +4,7 @@
         xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
         xmlns="https://getpsalm.org/schema/config"
         xsi:schemaLocation="https://getpsalm.org/schema/config vendor/vimeo/psalm/config.xsd"
-        findUnusedCode="true"
+        findUnusedCode="false"
         findUnusedBaselineEntry="true"
 >
     <projectFiles>
@@ -18,5 +18,6 @@
         <pluginClass class="Psalm\SymfonyPsalmPlugin\Plugin">
             <containerXml>var/cache/test/Neo4j_Neo4jBundle_Tests_App_TestKernelTestDebugContainer.xml</containerXml>
         </pluginClass>
+        <pluginClass class="Psalm\PhpUnitPlugin\Plugin"/>
     </plugins>
 </psalm>

src/Collector/Twig/Neo4jResultExtension.php

@@ -23,7 +23,7 @@ public function getFilters(): array
         ];
     }
 
-    public function getType($object): string
+    public function getType(mixed $object): string
     {
         return $this->doGetType($object, true);
     }
@@ -33,7 +33,7 @@ public function getName(): string
         return 'neo4j.result';
     }
 
-    private function doGetType($object, bool $recursive): string
+    private function doGetType(mixed $object, bool $recursive): string
     {
         if ($object instanceof Node) {
             return sprintf('%s: %s', $object->getId(), $object->getLabels()->join(', '));

tests/Unit/Collector/Twig/Neo4jResultExtensionTest.php

@@ -15,47 +15,47 @@
  */
 class Neo4jResultExtensionTest extends TestCase
 {
-    public function testEmptyArray()
+    public function testEmptyArray(): void
     {
         $o = new Neo4jResultExtension();
         $result = $o->getType([]);
 
         $this->assertEquals('Empty array', $result);
     }
 
-    public function testObject()
+    public function testObject(): void
     {
         $o = new Neo4jResultExtension();
         $result = $o->getType($o);
 
         $this->assertEquals(Neo4jResultExtension::class, $result);
     }
 
-    public function testScalar()
+    public function testScalar(): void
     {
         $o = new Neo4jResultExtension();
         $result = $o->getType(3);
 
         $this->assertEquals('int', $result);
     }
 
-    public function testScalarArray()
+    public function testScalarArray(): void
     {
         $o = new Neo4jResultExtension();
         $result = $o->getType([3, 6.3]);
 
         $this->assertEquals('[int, float]', $result);
     }
 
-    public function testArrayArray()
+    public function testArrayArray(): void
     {
         $o = new Neo4jResultExtension();
         $result = $o->getType([[]]);
 
         $this->assertEquals('[array]', $result);
     }
 
-    public function testNode()
+    public function testNode(): void
     {
         $o = new Neo4jResultExtension();
         $result = $o->getType(new Node(1, new CypherList(['Label']), new CypherMap(), null));

tests/Unit/DependencyInjection/Neo4jExtensionTest.php

@@ -19,7 +19,7 @@ protected function getMinimalConfiguration(): array
         return ['drivers' => ['default' => ['dsn' => 'bolt://localhost']]];
     }
 
-    public function testDataCollectorLoaded()
+    public function testDataCollectorLoaded(): void
     {
         $this->setParameter('kernel.debug', true);
         $this->load();
@@ -29,15 +29,15 @@ public function testDataCollectorLoaded()
         );
     }
 
-    public function testDataCollectorNotLoadedInNonDebug()
+    public function testDataCollectorNotLoadedInNonDebug(): void
     {
         $this->setParameter('kernel.debug', false);
         $this->load();
 
         $this->assertContainerBuilderNotHasService('neo4j.collector.debug_collector');
     }
 
-    public function testDataCollectorNotLoadedWhenDisabled()
+    public function testDataCollectorNotLoadedWhenDisabled(): void
     {
         $this->setParameter('kernel.debug', true);
         $this->load(['profiling' => ['enabled' => false]]);