Skip to content

Commit af5178c

Browse files
Fixes to type hints in tests
1 parent 05952ec commit af5178c

File tree

6 files changed

+19
-35
lines changed

6 files changed

+19
-35
lines changed

tests/unit/Expressions/Operators/InequalityTest.php

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,7 @@
1313
use WikibaseSolutions\CypherDSL\Expressions\Operators\Inequality;
1414
use WikibaseSolutions\CypherDSL\Expressions\Property;
1515
use WikibaseSolutions\CypherDSL\Expressions\Variable;
16+
use WikibaseSolutions\CypherDSL\Types\PropertyTypes\BooleanType;
1617

1718
/**
1819
* @covers \WikibaseSolutions\CypherDSL\Expressions\Operators\Inequality
@@ -40,4 +41,11 @@ public function testToQueryNoParentheses(): void
4041

4142
$this->assertSame("(v.a <> v.b <> v.a <> v.b)", $inequality->toQuery());
4243
}
44+
45+
public function testInstanceOfBooleanType(): void
46+
{
47+
$inequality = new Inequality(new Variable('a'), new Variable('b'));
48+
49+
$this->assertInstanceOf(BooleanType::class, $inequality);
50+
}
4351
}

tests/unit/Traits/TypeTraits/CompositeTypeTraits/ListTypeTraitTest.php

Lines changed: 6 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -15,31 +15,26 @@
1515
use WikibaseSolutions\CypherDSL\Expressions\Operators\In;
1616
use WikibaseSolutions\CypherDSL\Expressions\Property;
1717
use WikibaseSolutions\CypherDSL\Expressions\Variable;
18+
use WikibaseSolutions\CypherDSL\Types\CompositeTypes\ListType;
19+
use WikibaseSolutions\CypherDSL\Types\PropertyTypes\PropertyType;
1820

1921
/**
2022
* @covers \WikibaseSolutions\CypherDSL\Traits\TypeTraits\CompositeTypeTraits\ListTypeTrait
2123
*/
2224
final class ListTypeTraitTest extends TestCase
2325
{
24-
/**
25-
* @var MockObject|PropertyType
26-
*/
27-
private $a;
28-
29-
/**
30-
* @var ListType|MockObject
31-
*/
32-
private $b;
26+
private PropertyType $a;
27+
private ListType $list;
3328

3429
protected function setUp(): void
3530
{
3631
$this->a = new Property(new Variable('foo'), 'bar');
37-
$this->b = new List_;
32+
$this->list = new List_;
3833
}
3934

4035
public function testHas(): void
4136
{
42-
$has = $this->b->has($this->a);
37+
$has = $this->list->has($this->a);
4338

4439
$this->assertInstanceOf(In::class, $has);
4540
}

tests/unit/Traits/TypeTraits/MethodTraits/PropertyMethodTraitTest.php

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -20,10 +20,7 @@
2020
*/
2121
final class PropertyMethodTraitTest extends TestCase
2222
{
23-
/**
24-
* @var MapType|MockObject
25-
*/
26-
private $a;
23+
private MapType $a;
2724

2825
protected function setUp(): void
2926
{

tests/unit/Traits/TypeTraits/PropertyTypeTraits/BooleanTypeTraitTest.php

Lines changed: 2 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,6 @@
99
*/
1010
namespace WikibaseSolutions\CypherDSL\Tests\Unit\Traits\TypeTraits\PropertyTypeTraits;
1111

12-
use PHPUnit\Framework\MockObject\MockObject;
1312
use PHPUnit\Framework\TestCase;
1413
use WikibaseSolutions\CypherDSL\Expressions\Literals\Boolean;
1514
use WikibaseSolutions\CypherDSL\Expressions\Operators\Conjunction;
@@ -24,15 +23,8 @@
2423
*/
2524
final class BooleanTypeTraitTest extends TestCase
2625
{
27-
/**
28-
* @var BooleanType|MockObject
29-
*/
30-
private $a;
31-
32-
/**
33-
* @var BooleanType|MockObject
34-
*/
35-
private $b;
26+
private BooleanType $a;
27+
private BooleanType $b;
3628

3729
protected function setUp(): void
3830
{

tests/unit/Traits/TypeTraits/PropertyTypeTraits/PropertyTypeTraitTest.php

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,6 @@
2323
final class PropertyTypeTraitTest extends TestCase
2424
{
2525
private PropertyType $a;
26-
private Property $b;
2726
private List_ $list;
2827

2928
protected function setUp(): void

tests/unit/Traits/TypeTraits/PropertyTypeTraits/StringTypeTraitTest.php

Lines changed: 2 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -24,15 +24,8 @@
2424
*/
2525
final class StringTypeTraitTest extends TestCase
2626
{
27-
/**
28-
* @var MockObject|StringType
29-
*/
30-
private $a;
31-
32-
/**
33-
* @var MockObject|StringType
34-
*/
35-
private $b;
27+
private StringType $a;
28+
private StringType $b;
3629

3730
protected function setUp(): void
3831
{

0 commit comments

Comments
 (0)