Run php-cs-fixer and slightly decrease minimum MSI

Author: marijnvanwezel

.github/workflows/test.yml

@@ -20,7 +20,7 @@ jobs:
       COMPOSER_VERSION: 2
       COVERAGE_DRIVER: xdebug
       MINIMUM_COVERAGE_PERCENTAGE: 90
-      MINIMUM_MSI_PERCENTAGE: 84.27
+      MINIMUM_MSI_PERCENTAGE: 82
 
     steps:
       - name: Checkout repository

src/Expressions/Literals/List_.php

@@ -11,7 +11,6 @@
 
 use WikibaseSolutions\CypherDSL\Patterns\Pattern;
 use WikibaseSolutions\CypherDSL\Traits\CastTrait;
-use WikibaseSolutions\CypherDSL\Traits\ErrorTrait;
 use WikibaseSolutions\CypherDSL\Traits\TypeTraits\CompositeTypeTraits\ListTypeTrait;
 use WikibaseSolutions\CypherDSL\Types\AnyType;
 use WikibaseSolutions\CypherDSL\Types\CompositeTypes\ListType;

src/Expressions/Literals/Literal.php

@@ -19,7 +19,6 @@
 use WikibaseSolutions\CypherDSL\Expressions\Procedures\Point;
 use WikibaseSolutions\CypherDSL\Expressions\Procedures\Procedure;
 use WikibaseSolutions\CypherDSL\Expressions\Procedures\Time;
-use WikibaseSolutions\CypherDSL\Query;
 use WikibaseSolutions\CypherDSL\Traits\ErrorTrait;
 use WikibaseSolutions\CypherDSL\Types\PropertyTypes\NumeralType;
 use WikibaseSolutions\CypherDSL\Types\PropertyTypes\StringType;

src/Expressions/Literals/Map.php

@@ -10,7 +10,6 @@
 namespace WikibaseSolutions\CypherDSL\Expressions\Literals;
 
 use WikibaseSolutions\CypherDSL\Traits\CastTrait;
-use WikibaseSolutions\CypherDSL\Traits\ErrorTrait;
 use WikibaseSolutions\CypherDSL\Traits\EscapeTrait;
 use WikibaseSolutions\CypherDSL\Traits\TypeTraits\CompositeTypeTraits\MapTypeTrait;
 use WikibaseSolutions\CypherDSL\Types\AnyType;

src/Expressions/Procedures/Procedure.php

@@ -35,7 +35,7 @@ abstract class Procedure implements QueryConvertible
      * Produces a raw function call. This enables the usage of unimplemented functions in your
      * Cypher queries. The parameters of this function are not type-checked.
      *
-     * @param string                                                                                                                                                      $functionName The name of the function to call
+     * @param string $functionName The name of the function to call
      * @param AnyType|AnyType[]|bool|bool[]|float|float[]|int|int[]|mixed[]|mixed[][]|Pattern|Pattern[]|string|string[]|(AnyType|bool|float|int|mixed[]|Pattern|string)[] $parameters   The parameters to pass to the function call
      */
     public static function raw(string $functionName, $parameters): Raw

src/Patterns/Relationship.php

@@ -266,7 +266,7 @@ private function relationshipDetailToString(): string
 
         if (count($types) !== 0) {
             // If we have at least one condition type, escape them and insert them into the query
-            $escapedTypes = array_map(fn (string $type): string => self::escape($type), $types);
+            $escapedTypes = array_map(static fn (string $type): string => self::escape($type), $types);
             $conditionInner .= sprintf(":%s", implode("|", $escapedTypes));
         }
 

src/Query.php

@@ -362,7 +362,7 @@ public function __toString(): string
      *
      * @note This feature is not part of the openCypher standard.
      *
-     * @param callable|Query                                        $query     A callable decorating a Query, or an instance of Query
+     * @param callable|Query $query A callable decorating a Query, or an instance of Query
      * @param Pattern|Pattern[]|string|string[]|Variable|Variable[]|(Pattern|string|Variable)[] $variables The variables to include in the WITH clause for correlation (optional)
      *
      * @return $this
@@ -396,7 +396,7 @@ public function call($query, $variables = []): self
     /**
      * Creates the CALL procedure clause.
      *
-     * @param Procedure                                         $procedure The procedure to call
+     * @param Procedure $procedure The procedure to call
      * @param Alias|Alias[]|string|string[]|Variable|Variable[]|(Alias|string|Variable)[] $yields    The result fields that should be returned (optional)
      *
      * @return $this
@@ -447,7 +447,7 @@ public function match($patterns): self
      * Creates the RETURN clause.
      *
      * @param Alias|Alias[]|AnyType|AnyType[]|mixed[]|bool|bool[]|float|float[]|int|int[]|Pattern|Pattern[]|string|string[]|(Alias|AnyType|mixed[]|bool|float|int|Pattern|string)[] $expressions A single expression to return, or a non-empty list of expressions to return
-     * @param bool                                                                                                        $distinct    Whether to be a RETURN DISTINCT clause (optional, default: false)
+     * @param bool $distinct Whether to be a RETURN DISTINCT clause (optional, default: false)
      *
      * @return $this
      *
@@ -497,7 +497,7 @@ public function create($patterns): self
      * Creates the DELETE clause.
      *
      * @param Pattern|Pattern[]|StructuralType|StructuralType[]|(Pattern|StructuralType)[] $structures A single structure to delete, or a non-empty list of structures to delete
-     * @param bool                                              $detach     Whether to DETACH DELETE (optional, default: false)
+     * @param bool $detach Whether to DETACH DELETE (optional, default: false)
      *
      * @return $this
      *
@@ -691,8 +691,8 @@ public function set($expressions): self
      * Creates the WHERE clause.
      *
      * @param bool|bool[]|BooleanType|BooleanType[]|(bool|BooleanType)[] $expressions A boolean expression to evaluate, or a non-empty list of boolean expression to evaluate
-     * @param string                                $operator    The operator with which to unify the given expressions, should be either WhereClause::OR,
-     *                                                           WhereClause::AND or WhereClause::XOR (optional, default: 'and')
+     * @param string $operator The operator with which to unify the given expressions, should be either WhereClause::OR,
+     *                         WhereClause::AND or WhereClause::XOR (optional, default: 'and')
      *
      * @return $this
      *

tests/unit/Expressions/Procedures/ProcedureTest.php

@@ -10,10 +10,6 @@
 namespace WikibaseSolutions\CypherDSL\Tests\Unit\Expressions\Procedures;
 
 use PHPUnit\Framework\TestCase;
-use WikibaseSolutions\CypherDSL\Expressions\Literals\Boolean;
-use WikibaseSolutions\CypherDSL\Expressions\Literals\List_;
-use WikibaseSolutions\CypherDSL\Expressions\Literals\Literal;
-use WikibaseSolutions\CypherDSL\Expressions\Literals\Map;
 use WikibaseSolutions\CypherDSL\Expressions\Procedures\All;
 use WikibaseSolutions\CypherDSL\Expressions\Procedures\Any;
 use WikibaseSolutions\CypherDSL\Expressions\Procedures\Date;
@@ -28,9 +24,7 @@
 use WikibaseSolutions\CypherDSL\Expressions\Procedures\Raw;
 use WikibaseSolutions\CypherDSL\Expressions\Procedures\Single;
 use WikibaseSolutions\CypherDSL\Expressions\Procedures\Time;
-use WikibaseSolutions\CypherDSL\Expressions\Variable;
 use WikibaseSolutions\CypherDSL\Query;
-use WikibaseSolutions\CypherDSL\Types\AnyType;
 
 /**
  * @covers \WikibaseSolutions\CypherDSL\Expressions\Procedures\Procedure

tests/unit/Traits/EscapeTraitTest.php

@@ -9,6 +9,7 @@
  */
 namespace WikibaseSolutions\CypherDSL\Tests\Unit\Traits;
 
+use InvalidArgumentException;
 use PHPUnit\Framework\TestCase;
 use WikibaseSolutions\CypherDSL\Traits\EscapeTrait;
 
@@ -64,7 +65,7 @@ public function testValueWithMoreThan65534CharactersCannotBeEscaped(): void
     {
         $value = str_repeat('a', 65535);
 
-        $this->expectException(\InvalidArgumentException::class);
+        $this->expectException(InvalidArgumentException::class);
 
         $this->trait->escape($value);
     }