expanded CallProcedureClauseTest

Author: transistive

src/Clauses/CallProcedureClause.php

@@ -37,7 +37,7 @@ class CallProcedureClause extends Clause
     /**
      * @var string|null The procedure to call
      */
-    private ?string $procedure;
+    private ?string $procedure = null;
 
     /**
      * @var AnyType[] The arguments passed to the procedure

tests/Unit/Clauses/CallProcedureClauseTest.php

@@ -35,32 +35,42 @@ class CallProcedureClauseTest extends TestCase
 {
     use TestHelper;
 
-    public function testEmptyClause()
+    public function testEmptyClause(): void
     {
         $callProcedureClause = new CallProcedureClause();
 
         $this->assertSame("", $callProcedureClause->toQuery());
+        $this->assertEquals([], $callProcedureClause->getArguments());
+        $this->assertNull($callProcedureClause->getProcedure());
+        $this->assertEquals([], $callProcedureClause->getYieldVariables());
     }
 
-    public function testZeroArguments()
+    public function testZeroArguments(): void
     {
         $callProcedureClause = new CallProcedureClause();
         $callProcedureClause->setProcedure("apoc.json");
 
         $this->assertSame("CALL apoc.json()", $callProcedureClause->toQuery());
+        $this->assertEquals([], $callProcedureClause->getArguments());
+        $this->assertEquals('apoc.json', $callProcedureClause->getProcedure());
+        $this->assertEquals([], $callProcedureClause->getYieldVariables());
     }
 
-    public function testOneArgument()
+    public function testOneArgument(): void
     {
         $callProcedureClause = new CallProcedureClause();
         $callProcedureClause->setProcedure("apoc.json");
 
-        $callProcedureClause->addArgument($this->getQueryConvertableMock(AnyType::class, "'text'"));
+        $param = $this->getQueryConvertableMock(AnyType::class, "'text'");
+        $callProcedureClause->addArgument($param);
 
         $this->assertSame("CALL apoc.json('text')", $callProcedureClause->toQuery());
+        $this->assertEquals('apoc.json', $callProcedureClause->getProcedure());
+        $this->assertEquals([$param], $callProcedureClause->getArguments());
+        $this->assertEquals([], $callProcedureClause->getYieldVariables());
     }
 
-    public function testMultipleArgument()
+    public function testMultipleArgument(): void
     {
         $callProcedureClause = new CallProcedureClause();
         $callProcedureClause->setProcedure("apoc.json");
@@ -72,9 +82,12 @@ public function testMultipleArgument()
         $callProcedureClause->addArgument($expression);
 
         $this->assertSame("CALL apoc.json('text', 'text', 'text')", $callProcedureClause->toQuery());
+        $this->assertEquals([$expression, $expression, $expression], $callProcedureClause->getArguments());
+        $this->assertEquals('apoc.json', $callProcedureClause->getProcedure());
+        $this->assertEquals([], $callProcedureClause->getYieldVariables());
     }
 
-    public function testWithArguments()
+    public function testWithArguments(): void
     {
         $callProcedureClause = new CallProcedureClause();
         $callProcedureClause->setProcedure("apoc.json");
@@ -89,9 +102,12 @@ public function testWithArguments()
         $callProcedureClause->withArguments([$expression]);
 
         $this->assertSame("CALL apoc.json('text')", $callProcedureClause->toQuery());
+        $this->assertEquals([$expression], $callProcedureClause->getArguments());
+        $this->assertEquals('apoc.json', $callProcedureClause->getProcedure());
+        $this->assertEquals([], $callProcedureClause->getYieldVariables());
     }
 
-    public function testWithYield()
+    public function testWithYield(): void
     {
         $callProcedureClause = new CallProcedureClause();
 
@@ -105,9 +121,12 @@ public function testWithYield()
         $callProcedureClause->yields([$a, $b, $c]);
 
         $this->assertSame("CALL apoc.json() YIELD a, b, c", $callProcedureClause->toQuery());
+        $this->assertEquals([], $callProcedureClause->getArguments());
+        $this->assertEquals('apoc.json', $callProcedureClause->getProcedure());
+        $this->assertEquals([$a, $b, $c], $callProcedureClause->getYieldVariables());
     }
 
-    public function testYieldDoesNotAcceptAnyType()
+    public function testYieldDoesNotAcceptAnyType(): void
     {
         $callProcedureClause = new CallProcedureClause();
 
@@ -119,7 +138,7 @@ public function testYieldDoesNotAcceptAnyType()
         $callProcedureClause->yields([$a]);
     }
 
-    public function testArgumentsOnlyAcceptsAnyType()
+    public function testArgumentsOnlyAcceptsAnyType(): void
     {
         $callProcedureClause = new CallProcedureClause();
 

tests/Unit/Clauses/CreateClauseTest.php

@@ -38,14 +38,14 @@ class CreateClauseTest extends TestCase
 {
     use TestHelper;
 
-    public function testEmptyClause()
+    public function testEmptyClause(): void
     {
         $createClause = new CreateClause();
 
         $this->assertSame("", $createClause->toQuery());
     }
 
-    public function testSinglePattern()
+    public function testSinglePattern(): void
     {
         $createClause = new CreateClause();
         $pattern = $this->getQueryConvertableMock(StructuralType::class, "(a)");
@@ -55,7 +55,7 @@ public function testSinglePattern()
         $this->assertSame("CREATE (a)", $createClause->toQuery());
     }
 
-    public function testMultiplePatterns()
+    public function testMultiplePatterns(): void
     {
         $createClause = new CreateClause();
 
@@ -71,7 +71,7 @@ public function testMultiplePatterns()
     /**
      * @doesNotPerformAssertions
      */
-    public function testAcceptsNodeType()
+    public function testAcceptsNodeType(): void
     {
         $createClause = new CreateClause();
 
@@ -84,7 +84,7 @@ public function testAcceptsNodeType()
     /**
      * @doesNotPerformAssertions
      */
-    public function testAcceptsPathType()
+    public function testAcceptsPathType(): void
     {
         $createClause = new CreateClause();
 
@@ -97,7 +97,7 @@ public function testAcceptsPathType()
     /**
      * @doesNotPerformAssertions
      */
-    public function testAcceptsAssignment()
+    public function testAcceptsAssignment(): void
     {
         $createClause = new CreateClause();
 
@@ -107,7 +107,7 @@ public function testAcceptsAssignment()
         $createClause->toQuery();
     }
 
-    public function testDoesNotAcceptAnyType()
+    public function testDoesNotAcceptAnyType(): void
     {
         $createClause = new CreateClause();