Slighly improve MSI

Author: marijnvanwezel

.github/workflows/test.yml

@@ -20,7 +20,7 @@ jobs:
       COMPOSER_VERSION: 2
       COVERAGE_DRIVER: xdebug
       MINIMUM_COVERAGE_PERCENTAGE: 90
-      MINIMUM_MSI_PERCENTAGE: 90
+      MINIMUM_MSI_PERCENTAGE: 84.27
 
     steps:
       - name: Checkout repository

tests/unit/Traits/EscapeTraitTest.php

@@ -60,6 +60,15 @@ public function testValueWithBacktickIsProperlyEscaped($input, $expected): void
         $this->assertSame('`foo``bar`', $this->trait->escape("foo`bar"));
     }
 
+    public function testValueWithMoreThan65534CharactersCannotBeEscaped(): void
+    {
+        $value = str_repeat('a', 65535);
+
+        $this->expectException(\InvalidArgumentException::class);
+
+        $this->trait->escape($value);
+    }
+
     public function provideSafeValueIsNotEscapedData(): array
     {
         return [

tests/unit/Traits/NameGenerationTraitTest.php

@@ -31,16 +31,16 @@ protected function setUp(): void
 
     public function testGenerateIdentifierWithoutPrefix(): void
     {
-        $this->assertMatchesRegularExpression('/var\w{32}/', $this->trait->generateIdentifier());
+        $this->assertMatchesRegularExpression('/^var\w{32}$/', $this->trait->generateIdentifier());
     }
 
     public function testGenerateIdentifierWithPrefix(): void
     {
-        $this->assertMatchesRegularExpression('/x\w{32}/', $this->trait->generateIdentifier('x'));
+        $this->assertMatchesRegularExpression('/^x\w{32}$/', $this->trait->generateIdentifier('x'));
     }
 
     public function testGenerateIdentifierWithPrefixAndLength(): void
     {
-        $this->assertMatchesRegularExpression('/x\w{16}/', $this->trait->generateIdentifier('x', 16));
+        $this->assertMatchesRegularExpression('/^x\w{16}$/', $this->trait->generateIdentifier('x', 16));
     }
 }

tests/unit/Traits/PatternTraits/PropertyPatternTraitTest.php

@@ -111,6 +111,13 @@ public function testAddPropertiesReturnsSameInstance(): void
         $this->assertSame($this->stub, $actual);
     }
 
+    public function testAddPropertiesDoesNotAcceptMapType(): void
+    {
+        $this->expectException(TypeError::class);
+
+        $this->stub->addProperties(Query::variable('foobar'));
+    }
+
     /**
      * @doesNotPerformAssertions
      */