Merge pull request #589 from neo4j/remove-apoc

Remove apoc functions and procedures

Author: angrykoala

.changeset/fine-roses-film.md

@@ -0,0 +1,30 @@
+---
+"@neo4j/cypher-builder": major
+---
+
+Remove all apoc functions and procedures:
+
+- `apoc.util.validate`
+- `apoc.util.validatePredicate`
+- `apoc.date.convertFormat`
+- `apoc.cypher.runFirstColumnMany`
+- `apoc.cypher.runFirstColumnSingle`
+
+In order to use apoc methods, create a custom function or procedure. For example:
+
+```js
+function validate(
+    predicate: Predicate,
+    message: string,
+    params: List | Literal | Map
+): VoidCypherProcedure {
+    return new VoidCypherProcedure("apoc.util.validate", [predicate,  new Literal(message), params]);
+}
+```
+
+```js
+function validatePredicate(predicate: Predicate, message: string): CypherFunction {
+    return new CypherFunction("apoc.util.validatePredicate", [predicate, new Literal(message), new Literal([0])]);
+}
+
+```

src/Cypher.ts

@@ -63,11 +63,6 @@ export { Collect } from "./expressions/subquery/Collect";
 export { Count } from "./expressions/subquery/Count";
 export { Exists } from "./expressions/subquery/Exists";
 
-/**
- * @hideGroups
- */
-export * as apoc from "./namespaces/apoc/apoc";
-
 export * as db from "./namespaces/db/db";
 /**
  * @hideGroups

src/clauses/With.test.ts

@@ -286,12 +286,15 @@ CALL db.labels() YIELD label"
         });
 
         test("With * and cypher void procedure", () => {
-            const withQuery = new Cypher.With("*").callProcedure(Cypher.apoc.util.validate(Cypher.true, "message"));
+            const targetNode = new Cypher.Node();
+            const customProcedure = new Cypher.VoidProcedure("customProcedure", [targetNode]);
+
+            const withQuery = new Cypher.With("*").callProcedure(customProcedure);
 
             const queryResult = withQuery.build();
             expect(queryResult.cypher).toMatchInlineSnapshot(`
 "WITH *
-CALL apoc.util.validate(true, \\"message\\", [0])"
+CALL customProcedure(this0)"
 `);
             expect(queryResult.params).toMatchInlineSnapshot(`{}`);
         });