Remove extra parameters in Foreach

Author: angrykoala

.changeset/violet-sloths-hug.md

@@ -0,0 +1,45 @@
+---
+"@neo4j/cypher-builder": major
+---
+
+Remove extra parameters in `Cypher.Foreach` in favor of methods `in` and `do`.
+
+For example, to create the following Cypher:
+
+```cypher
+FOREACH (var0 IN [1, 2, 3] |
+        CREATE (this1:Movie)
+        SET
+            this1.id = var0
+    )
+```
+
+_before_
+
+```js
+const list = new Cypher.Literal([1, 2, 3]);
+const variable = new Cypher.Variable();
+
+const movieNode = new Cypher.Node();
+const createMovie = new Cypher.Create(new Cypher.Pattern(movieNode, { labels: ["Movie"] })).set([
+    movieNode.property("id"),
+    variable,
+]);
+
+const foreachClause = new Cypher.Foreach(variable, list, createMovie);
+```
+
+_after_
+
+```js
+const list = new Cypher.Literal([1, 2, 3]);
+const variable = new Cypher.Variable();
+
+const movieNode = new Cypher.Node();
+const createMovie = new Cypher.Create(new Cypher.Pattern(movieNode, { labels: ["Movie"] })).set([
+    movieNode.property("id"),
+    variable,
+]);
+
+const foreachClause = new Cypher.Foreach(variable).in(list).do(createMovie);
+```

src/clauses/Foreach.ts

@@ -51,13 +51,9 @@ export class Foreach extends Clause {
     private mapClause: ForeachClauses | undefined;
 
     constructor(variable: Variable);
-    /** @deprecated Use `in` and `do` instead of passing the constructor */
-    constructor(variable: Variable, listExpr: Expr, mapClause: ForeachClauses);
-    constructor(variable: Variable, listExpr?: Expr, mapClause?: ForeachClauses) {
+    constructor(variable: Variable) {
         super();
         this.variable = variable;
-        this.listExpr = listExpr;
-        this.mapClause = mapClause;
     }
 
     public in(listExpr: Expr): this {

tests/clause-chaining.test.ts

@@ -99,7 +99,7 @@ describe("Clause chaining", () => {
         const movieNode = new Cypher.Node();
         const createMovie = new Cypher.Create(new Cypher.Pattern(movieNode)).set([movieNode.property("id"), variable]);
 
-        const clause = new Cypher.Foreach(variable, list, createMovie);
+        const clause = new Cypher.Foreach(variable).in(list).do(createMovie);
 
         it.each(["return", "remove", "set", "delete", "detachDelete", "with", "merge", "create"] as const)(
             "Foreach.%s",