Merge pull request #552 from neo4j/small-code-smells-fix

Fix a few code smells

Author: angrykoala

package.json

@@ -58,7 +58,7 @@
         "jest-extended": "^6.0.0",
         "prettier": "^3.4.1",
         "ts-jest": "^29.2.5",
-        "typedoc": "^0.28.5",
+        "typedoc": "^0.28.7",
         "typescript": "^5.6.3"
     }
 }

src/clauses/sub-clauses/Delete.ts

@@ -32,7 +32,7 @@ export class DeleteClause extends CypherASTNode {
     private readonly deleteInput: DeleteInput;
     private detachKeyword: DetachKeyword | undefined;
 
-    constructor(parent: CypherASTNode | undefined, deleteInput: DeleteInput) {
+    constructor(parent: CypherASTNode, deleteInput: DeleteInput) {
         super(parent);
         this.deleteInput = deleteInput;
     }

src/clauses/sub-clauses/ImportWith.ts

@@ -22,7 +22,6 @@ import type { CypherEnvironment } from "../../Environment";
 import type { Param } from "../../references/Param";
 import type { PropertyRef } from "../../references/PropertyRef";
 import type { Variable } from "../../references/Variable";
-import type { Call } from "../Call";
 
 export type SetParam = [PropertyRef, Param<unknown>];
 
@@ -31,7 +30,7 @@ export class ImportWith extends CypherASTNode {
     private readonly params: Variable[];
     private hasStar = false;
 
-    constructor(parent: Call, params: Array<"*" | Variable>) {
+    constructor(parent: CypherASTNode, params: Array<"*" | Variable>) {
         super(parent);
         this.params = this.filterParams(params);
     }

src/expressions/functions/string.ts

@@ -163,13 +163,16 @@ export function toUpper(original: Expr): CypherFunction {
     return new CypherFunction("toUpper", [original]);
 }
 
+/** @inline */
+type TrimOption = "BOTH" | "LEADING" | "TRAILING";
+
 /** Implements a trim function with a trim expression `trim(BOTH 'x' FROM 'xxxhelloxxx')` */
 class TrimFunction extends CypherFunction {
-    private readonly typeOrInput: "BOTH" | "LEADING" | "TRAILING";
+    private readonly typeOrInput: TrimOption;
     private readonly trimChar: Expr;
     private readonly input: Expr;
 
-    constructor(typeOrInput: "BOTH" | "LEADING" | "TRAILING", trimChar: Expr, input: Expr) {
+    constructor(typeOrInput: TrimOption, trimChar: Expr, input: Expr) {
         super("trim");
         this.typeOrInput = typeOrInput;
         this.trimChar = trimChar;
@@ -189,13 +192,9 @@ class TrimFunction extends CypherFunction {
  * @group Functions
  * @category String
  */
-export function trim(type: "BOTH" | "LEADING" | "TRAILING", trimChar: Expr, input: Expr): CypherFunction;
+export function trim(type: TrimOption, trimChar: Expr, input: Expr): CypherFunction;
 export function trim(input: Expr): CypherFunction;
-export function trim(
-    typeOrInput: "BOTH" | "LEADING" | "TRAILING" | Expr,
-    trimChar?: Expr,
-    input?: Expr
-): CypherFunction {
+export function trim(typeOrInput: TrimOption | Expr, trimChar?: Expr, input?: Expr): CypherFunction {
     if (typeof typeOrInput === "string") {
         if (!trimChar || !input) {
             throw new Error("Invalid parameters in trim. trimChar and input must be valid Expr");