Skip to content
This repository was archived by the owner on Jul 6, 2023. It is now read-only.

Commit 58a701e

Browse files
committed
Update to java driver 2.0.0-alpha03
1 parent 3e58a04 commit 58a701e

File tree

3 files changed

+28
-18
lines changed

3 files changed

+28
-18
lines changed

build.gradle

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -72,7 +72,7 @@ ext {
7272
argparse4jVersion = '0.7.0'
7373
junitVersion = '4.12'
7474
evaluatorVersion = '3.5.4'
75-
neo4jJavaDriverVersion = '2.0.0-alpha02'
75+
neo4jJavaDriverVersion = '2.0.0-alpha03'
7676
findbugsVersion = '3.0.0'
7777
jansiVersion = '1.13'
7878
jlineVersion = '2.14.6'

cypher-shell/src/main/java/org/neo4j/shell/state/BoltStateHandler.java

Lines changed: 12 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,6 @@
55
import java.util.Map;
66
import java.util.Optional;
77
import java.util.function.BiFunction;
8-
import java.util.function.Consumer;
98
import java.util.stream.Collectors;
109
import javax.annotation.Nonnull;
1110
import javax.annotation.Nullable;
@@ -17,12 +16,12 @@
1716
import org.neo4j.driver.Driver;
1817
import org.neo4j.driver.GraphDatabase;
1918
import org.neo4j.driver.Session;
20-
import org.neo4j.driver.SessionParametersTemplate;
2119
import org.neo4j.driver.Statement;
2220
import org.neo4j.driver.StatementResult;
2321
import org.neo4j.driver.Transaction;
2422
import org.neo4j.driver.exceptions.ClientException;
2523
import org.neo4j.driver.exceptions.SessionExpiredException;
24+
import org.neo4j.driver.internal.SessionConfig;
2625
import org.neo4j.driver.summary.DatabaseInfo;
2726
import org.neo4j.shell.ConnectionConfig;
2827
import org.neo4j.shell.Connector;
@@ -173,20 +172,21 @@ private void reconnect() {
173172
}
174173

175174
private void reconnect(boolean keepBookmark) {
176-
Consumer<SessionParametersTemplate> sessionOptionalArgs = t -> {};
177-
if (session != null && keepBookmark) {
175+
SessionConfig.Builder builder = SessionConfig.builder();
176+
builder.withDefaultAccessMode( AccessMode.WRITE );
177+
if ( !ABSENT_DB_NAME.equals( activeDatabaseNameAsSetByUser ) )
178+
{
179+
builder.withDatabase( activeDatabaseNameAsSetByUser );
180+
}
181+
if ( session != null && keepBookmark )
182+
{
178183
// Save the last bookmark and close the session
179184
final String bookmark = session.lastBookmark();
180185
session.close();
181-
sessionOptionalArgs = t -> t.withBookmarks(bookmark);
186+
builder.withBookmarks( bookmark );
182187
}
183-
Consumer<SessionParametersTemplate> sessionArgs = t -> {
184-
t.withDefaultAccessMode(AccessMode.WRITE);
185-
if (!ABSENT_DB_NAME.equals(activeDatabaseNameAsSetByUser)) {
186-
t.withDatabase(activeDatabaseNameAsSetByUser);
187-
}
188-
};
189-
session = driver.session(sessionArgs.andThen(sessionOptionalArgs));
188+
189+
session = driver.session( builder.build() );
190190

191191
String query = activeDatabaseNameAsSetByUser.compareToIgnoreCase(SYSTEM_DB_NAME) == 0 ? "SHOW DATABASES" : "RETURN 1";
192192

cypher-shell/src/test/java/org/neo4j/shell/test/bolt/FakeDriver.java

Lines changed: 15 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -3,14 +3,13 @@
33
import org.neo4j.driver.Driver;
44
import org.neo4j.driver.Metrics;
55
import org.neo4j.driver.Session;
6-
import org.neo4j.driver.SessionParametersTemplate;
76
import org.neo4j.driver.async.AsyncSession;
87
import org.neo4j.driver.exceptions.Neo4jException;
8+
import org.neo4j.driver.internal.SessionConfig;
99
import org.neo4j.driver.reactive.RxSession;
1010
import org.neo4j.driver.types.TypeSystem;
1111

1212
import java.util.concurrent.CompletionStage;
13-
import java.util.function.Consumer;
1413

1514
public class FakeDriver implements Driver {
1615
@Override
@@ -24,7 +23,7 @@ public Session session() {
2423
}
2524

2625
@Override
27-
public Session session(Consumer<SessionParametersTemplate> templateConsumer) {
26+
public Session session( SessionConfig sessionConfig) {
2827
return new FakeSession();
2928
}
3029

@@ -50,7 +49,7 @@ public RxSession rxSession()
5049
}
5150

5251
@Override
53-
public RxSession rxSession(Consumer<SessionParametersTemplate> templateConsumer)
52+
public RxSession rxSession( SessionConfig sessionConfig )
5453
{
5554
return null;
5655
}
@@ -62,7 +61,7 @@ public AsyncSession asyncSession()
6261
}
6362

6463
@Override
65-
public AsyncSession asyncSession(Consumer<SessionParametersTemplate> templateConsumer)
64+
public AsyncSession asyncSession( SessionConfig sessionConfig )
6665
{
6766
return null;
6867
}
@@ -72,4 +71,15 @@ public TypeSystem defaultTypeSystem()
7271
{
7372
return null;
7473
}
74+
75+
@Override
76+
public void verifyConnectivity()
77+
{
78+
}
79+
80+
@Override
81+
public CompletionStage<Void> verifyConnectivityAsync()
82+
{
83+
return null;
84+
}
7585
}

0 commit comments

Comments
 (0)