Fix non-null build failures (new IntelliJ setting)

Author: spacecowboy

cypher-shell/src/main/java/org/neo4j/shell/state/BoltResult.java

@@ -19,10 +19,12 @@ public BoltResult(@Nonnull List<Record> records, @Nonnull ResultSummary summary)
         this.summary = summary;
     }
 
+    @Nonnull
     public List<Record> getRecords() {
         return records;
     }
 
+    @Nonnull
     public ResultSummary getSummary() {
         return summary;
     }

cypher-shell/src/test/java/org/neo4j/shell/CypherShellTest.java

@@ -46,6 +46,8 @@ public class CypherShellTest {
 
     @Before
     public void setup() {
+        when(mockedBoltStateHandler.getServerVersion()).thenReturn("");
+
         doReturn(System.out).when(logger).getOutputStream();
         offlineTestShell = new OfflineTestShell(logger, mockedBoltStateHandler, mockedPrettyPrinter);
 

cypher-shell/src/test/java/org/neo4j/shell/prettyprint/PrettyPrinterTest.java

@@ -71,6 +71,7 @@ public void prettyPrintList() throws Exception {
         when(record2.values()).thenReturn(asList(value2));
 
         when(result.getRecords()).thenReturn(asList(record1, record2));
+        when(result.getSummary()).thenReturn(mock(ResultSummary.class));
 
         // when
         String actual = plainPrinter.format(result);
@@ -102,6 +103,7 @@ public void prettyPrintNode() throws Exception {
         when(record.values()).thenReturn(asList(value));
 
         when(result.getRecords()).thenReturn(asList(record));
+        when(result.getSummary()).thenReturn(mock(ResultSummary.class));
 
         // when
         String actual = plainPrinter.format(result);
@@ -134,6 +136,7 @@ public void prettyPrintRelationships() throws Exception {
         when(record.values()).thenReturn(asList(value));
 
         when(result.getRecords()).thenReturn(asList(record));
+        when(result.getSummary()).thenReturn(mock(ResultSummary.class));
 
         // when
         String actual = plainPrinter.format(result);
@@ -179,6 +182,7 @@ public void printRelationshipsAndNodesWithEscapingForSpecialCharacters() throws
         when(record.values()).thenReturn(asList(relVal, nodeVal));
 
         when(result.getRecords()).thenReturn(asList(record));
+        when(result.getSummary()).thenReturn(mock(ResultSummary.class));
 
         // when
         String actual = plainPrinter.format(result);
@@ -240,6 +244,7 @@ public void prettyPrintPaths() throws Exception {
         when(record.values()).thenReturn(asList(value));
 
         when(result.getRecords()).thenReturn(asList(record));
+        when(result.getSummary()).thenReturn(mock(ResultSummary.class));
 
         // when
         String actual = plainPrinter.format(result);
@@ -287,6 +292,7 @@ public void prettyPrintSingleNodePath() throws Exception {
         when(record.values()).thenReturn(asList(value));
 
         when(result.getRecords()).thenReturn(asList(record));
+        when(result.getSummary()).thenReturn(mock(ResultSummary.class));
 
         // when
         String actual = plainPrinter.format(result);
@@ -350,6 +356,7 @@ public void prettyPrintThreeSegmentPath() throws Exception {
         when(record.values()).thenReturn(asList(value));
 
         when(result.getRecords()).thenReturn(asList(record));
+        when(result.getSummary()).thenReturn(mock(ResultSummary.class));
 
         // when
         String actual = plainPrinter.format(result);